[go: nahoru, domu]
Closed Bug 1879035 Opened 7 months ago Closed 1 month ago

Unable to Free highlight over an already Highlighted Text

Categories

(Firefox :: PDF Viewer, defect, P1)

Product:
Firefox
Component:
PDF Viewer
Platform:
Desktop
Unspecified
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- disabled
firefox-esr128 --- fix-optional
firefox122 --- disabled
firefox123 --- disabled
firefox124 --- disabled
firefox128 --- wontfix
firefox129 --- verified
firefox130 --- verified

People

(Reporter: rdoghi, Assigned: calixte)

References

Details

Attachments

(3 files)

FreeHighlight.mp4
4.06 MB, video/mp4
Details
[Editor] Disable existing highlights when drawing a new one (bug 1879035)
44 bytes, text/x-github-pull-request
Details | Review
Bug 1879035 - Disable existing highlights when drawing a new one in the pdf viewer
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
Attached video FreeHighlight.mp4 —

Found in

  • Nightly 124.0a1 (2024-02-07)

Affected versions

  • Nightly 124.0a1 (2024-02-07)

Affected platforms

  • All

Steps to reproduce

  1. Open any PDF in Firefox.
  2. Highlight any text.
  3. Start to Free Highlight from a non text area until the Highlighted text.

Expected result

  • Users should be able to free Highlight on top of other Highlighted text.

Actual result

  • The Free highlight stops working if it crosses an already Highlighted text.

Regression range
Not a Regression

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Assignee: nobody → cdenizet
Status: NEW → ASSIGNED
Priority: -- → P1

This issue is Verified as fixed in our latest Nightly build 130.0a1 (2024-07-17) by Bug 1907917.

status-firefox128: --- → affected
status-firefox129: --- → affected
status-firefox130: --- → verified
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
No longer depends on: 1907705
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch

The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(cdenizet)
Attachment #9414124 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: Small
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: See comment#0
  • Risk associated with taking this patch: Small
  • Explanation of risk level: It can only happen if a user tries to highlight some text and the pointer hovers an existing editor. So it should be pretty rare.
  • String changes made/needed: No
  • Is Android affected?: no
Flags: qe-verify+
Flags: needinfo?(cdenizet)
Attachment #9414124 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified as fixed in in 129.0b8.

status-firefox129: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: