[go: nahoru, domu]
Closed Bug 1879104 Opened 6 months ago Closed 1 month ago

The Highlight Delete and Colors menu does not work if the submenu is on top of a different highlight

Categories

(Firefox :: PDF Viewer, defect, P1)

Product:
Firefox
Component:
PDF Viewer
Platform:
Desktop
Unspecified
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- disabled
firefox-esr128 --- fix-optional
firefox122 --- disabled
firefox123 --- disabled
firefox124 --- wontfix
firefox128 --- wontfix
firefox129 --- verified
firefox130 --- verified

People

(Reporter: rdoghi, Assigned: calixte)

References

Details

Attachments

(3 files)

Deletebutton.mp4
3.48 MB, video/mp4
Details
[mozilla/pdf.js] [Editor] Make editor toolbars usable whatever their z-index (bug 1879104) (#18425)
44 bytes, text/x-github-pull-request
Details | Review
Bug 1879104 - Make editor toolbars usable whatever their z-index in the pdf viewer r=#pdfjs-reviewers
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
Attached video Deletebutton.mp4 —

Found in

  • Nightly 124.0a1 (2024-02-07)

Affected versions

  • Nightly 124.0a1 (2024-02-07)

Affected platforms

  • All

Steps to reproduce

  1. Open any PDF in Firefox.
  2. Enable the highlight tool.
  3. Highlight any text.
  4. Free Highlight some Text close to the already highlighted text so that the Delete button overlaps the already Highlighted text.

Expected result

  • Delete and Color buttons should have priority over the already highlighted text.

Actual result

  • Clicking any of the buttons from the submenu will focus the highlight underneath.

Regression range
Not a Regression

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Assignee: nobody → cdenizet
Status: NEW → ASSIGNED
Priority: -- → P1

This issue is Verified as fixed in our latest Nightly build 130.0a1 (2024-07-17) by Bug 1907917.

status-firefox128: --- → affected
status-firefox129: --- → affected
status-firefox130: --- → verified
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
No longer depends on: 1907705
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch

The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(cdenizet)
Attachment #9414119 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: Small
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: See comment#0
  • Risk associated with taking this patch: Small
  • Explanation of risk level: It just make the current selected editor in front of the others.
  • String changes made/needed: No
  • Is Android affected?: no
Flags: qe-verify+
Flags: needinfo?(cdenizet)
Attachment #9414119 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9414119 - Flags: approval-mozilla-beta+ → approval-mozilla-beta?

@calixte the phabrcator revision failed to land due to conflicts. Could you take a look?

Flags: needinfo?(cdenizet)
QA Whiteboard: [qa-triaged]
Attachment #9414119 - Attachment description: Bug 1879104 - Make editor toolbars usable whatever their z-index in the pdf viewer → Bug 1879104 - Make editor toolbars usable whatever their z-index in the pdf viewer r=#pdfjs-reviewers

:donal, done, sorry for the lag: I missed your ni.

Flags: needinfo?(cdenizet)
Attachment #9414119 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed in our latest Beta build 129.0b9.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
status-firefox129: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: