Closed
Bug 1879104
Opened 6 months ago
Closed 1 month ago
The Highlight Delete and Colors menu does not work if the submenu is on top of a different highlight
Categories
(Firefox :: PDF Viewer, defect, P1)
Tracking
()
VERIFIED
FIXED
130 Branch
People
(Reporter: rdoghi, Assigned: calixte)
References
Details
Attachments
(3 files)
Found in
- Nightly 124.0a1 (2024-02-07)
Affected versions
- Nightly 124.0a1 (2024-02-07)
Affected platforms
- All
Steps to reproduce
- Open any PDF in Firefox.
- Enable the highlight tool.
- Highlight any text.
- Free Highlight some Text close to the already highlighted text so that the Delete button overlaps the already Highlighted text.
Expected result
- Delete and Color buttons should have priority over the already highlighted text.
Actual result
- Clicking any of the buttons from the submenu will focus the highlight underneath.
Regression range
Not a Regression
Reporter | ||
Updated•6 months ago
|
Comment 1•6 months ago
|
||
:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?
Assignee | ||
Updated•1 month ago
|
Assignee: nobody → cdenizet
Status: NEW → ASSIGNED
Priority: -- → P1
Comment 3•1 month ago
|
||
Reporter | ||
Comment 4•1 month ago
|
||
This issue is Verified as fixed in our latest Nightly build 130.0a1 (2024-07-17) by Bug 1907917.
status-firefox128:
--- → affected
status-firefox129:
--- → affected
status-firefox130:
--- → verified
Updated•1 month ago
|
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
No longer depends on: 1907705
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
Comment 5•1 month ago
|
||
The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox129
towontfix
.
For more information, please visit BugBot documentation.
Flags: needinfo?(cdenizet)
Updated•1 month ago
|
Assignee | ||
Comment 6•29 days ago
|
||
Updated•29 days ago
|
Attachment #9414119 -
Flags: approval-mozilla-beta?
Comment 7•29 days ago
|
||
beta Uplift Approval Request
- User impact if declined: Small
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: See comment#0
- Risk associated with taking this patch: Small
- Explanation of risk level: It just make the current selected editor in front of the others.
- String changes made/needed: No
- Is Android affected?: no
Flags: qe-verify+
Assignee | ||
Updated•29 days ago
|
Flags: needinfo?(cdenizet)
Updated•28 days ago
|
Attachment #9414119 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•28 days ago
|
Attachment #9414119 -
Flags: approval-mozilla-beta+ → approval-mozilla-beta?
Comment 8•28 days ago
|
||
@calixte the phabrcator revision failed to land due to conflicts. Could you take a look?
Flags: needinfo?(cdenizet)
Updated•27 days ago
|
QA Whiteboard: [qa-triaged]
Updated•27 days ago
|
Attachment #9414119 -
Attachment description: Bug 1879104 - Make editor toolbars usable whatever their z-index in the pdf viewer → Bug 1879104 - Make editor toolbars usable whatever their z-index in the pdf viewer r=#pdfjs-reviewers
Assignee | ||
Comment 9•27 days ago
|
||
:donal, done, sorry for the lag: I missed your ni.
Flags: needinfo?(cdenizet)
Updated•26 days ago
|
Attachment #9414119 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•26 days ago
|
Comment 10•26 days ago
|
||
uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/19409c95127f
Reporter | ||
Comment 11•26 days ago
|
||
Verified as fixed in our latest Beta build 129.0b9.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•