[go: nahoru, domu]

Closed Bug 1889356 Opened 5 months ago Closed 1 month ago

[toolbar redesign] Hide new nav toolbar in PWA

Categories

(Fenix :: Toolbar, enhancement, P1)

Firefox 126
ARM64
Android
enhancement

Tracking

(firefox130 verified)

VERIFIED FIXED
Tracking Status
firefox130 --- verified

People

(Reporter: raj.azharuddin, Assigned: petru)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid])

Attachments

(3 files, 1 obsolete file)

User Agent: Mozilla/5.0 (Linux; Android 13; Mobile; rv:126.0) Gecko/126.0 Firefox/126.0

Steps to reproduce:

Enable new toolbar feature in nightly
Open any pwa , it is showing the new nav toolbar.. considering pwa should provide app like experience, the nav toolbar can be permanently hidden

Actual results:

Nav toolbar visible in pwa

Expected results:

Nav toolbar should not be visible in pwa..to provide app like experience please hide the nav toolbar and add the 3 dot menu to the toolbar like old implementation..also if possible add a reload button

Hardware: All → ARM64
Severity: -- → S3
Summary: Hide new nav toolbar in PWA → [toolbar redesign] Hide new nav toolbar in PWA
Whiteboard: [fxdroid]

Adding what the experience should be for PWAs. In the redesign, hadn't considered this experience. Will update when available.

I don't understand the logic..a pwa should give mobile app like experience, in that sense adding the nav bar is defeating the purpose, it no longer looks like app😕

Attached image custom tabs toolbar.png

Added a screenshot of the Chrome experience and the existing Firefox experience without the new Toolbar design.

Neither have a nav bar, though they do have a toolbar at the top (For Firefox, that's even true when "bottom toolbar" is enabled)

Aarjav says this is a beta experiment blocker.

Priority: -- → P2

To provide an app-like experience, no address bar or toolbar should be displayed when a user accesses a PWA.

Assignee: nobody → petru
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

I've made related changes in https://phabricator.services.mozilla.com/D213415.

Any ideas welcome.

Did some tests using https://paperplanes.world/ in Chrome and Fenix

 
Based on the above:

  • we properly handle custom tabs, no changes are needed
  • both the old and the new toolbars have issues for "installed" PWAs
    • with the old toolbar:
      • the PWA does not start in immersive mode - system navbar is shown
      • when entering fullscreen it shows the "Entering full screen mode" message.
    • with the new navbar
      • the PWA does not start in immersive mode - both the address bar and navbar are take space
      • when entering fullscreen it shows the "Entering full screen mode" message.
See Also: → 1902265
Attachment #9407202 - Attachment is obsolete: true

Abandoned my patch in favor of https://phabricator.services.mozilla.com/D213415 which would also solve this issue + others
And would prefer to have that land smoothly without conflicts.
Will update this for QA to validate once that patch lands.

The patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1901741 landed.
@ QA. Please help test that this issue was fixed.

Flags: qe-verify+
Depends on: 1906784
Depends on: 1906788
Depends on: 1906791

Found a bug with toolab visibility in PWA:

Steps to reproduce

  1. Enable toolbar redesign
  2. Position address bar at bottom
  3. Open a PWA
  4. Navigate a link from PWA.
  5. Rotate the device to landscape.
  6. Rotate the device back to portrait.
  7. Press back

Expected behavior
The toolbar gets hidden on the original PWA page

Actual behavior
Original PWA page keeps the tooblar visible

Flags: qe-verify+

With he help of Mike also this seems to be ready for QA validation

Flags: qe-verify+
Attached video QA.mp4

Tested on the latest Nightly 130.0a1 from 07/12 with Samsung Galaxy S22 Ultra (Android 14) and Samsung Tab S8 Ultra 5G (Android 14).

The address bar and the navigation toolbar are not displayed on PWAs installed from latest Nightly. I've tested this using the link Petru used, https://paperplanes.world/ in addition to olx.com and x.com.

However, I was able to reproduce the issue Mike described here and in ticket 1906784, but only with 1 less step compared to the initial flow.
STR:

  1. Open latest Nightly with the navigation toolbar enabled by default
  2. Position address bar at bottom
  3. Open a PWA
  4. Navigate a link from PWA.
  5. Rotate the device to landscape.
  6. Press back

Should I open a follow up issue for 1906784?

Flags: needinfo?(petru)

Increasing priority to P1 now that we're fixing toolbar phase 1's beta blockers.

Priority: P2 → P1

@Delia Thank you for checking!
Opening a new issue describing the affecting scenario and linking it to 1906784 sounds good, thank you!

Flags: needinfo?(petru)

Opened 1907939.
Discussed with Petru on Slack and we agreed that this ticket can be closed as verified fixed.

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Flags: qe-verify+
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: