[toolbar redesign] Hide new nav toolbar in PWA
Categories
(Fenix :: Toolbar, enhancement, P1)
Tracking
(firefox130 verified)
Tracking | Status | |
---|---|---|
firefox130 | --- | verified |
People
(Reporter: raj.azharuddin, Assigned: petru)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid])
Attachments
(3 files, 1 obsolete file)
User Agent: Mozilla/5.0 (Linux; Android 13; Mobile; rv:126.0) Gecko/126.0 Firefox/126.0
Steps to reproduce:
Enable new toolbar feature in nightly
Open any pwa , it is showing the new nav toolbar.. considering pwa should provide app like experience, the nav toolbar can be permanently hidden
Actual results:
Nav toolbar visible in pwa
Expected results:
Nav toolbar should not be visible in pwa..to provide app like experience please hide the nav toolbar and add the 3 dot menu to the toolbar like old implementation..also if possible add a reload button
Reporter | ||
Updated•5 months ago
|
Updated•4 months ago
|
Updated•4 months ago
|
Updated•4 months ago
|
Comment 1•4 months ago
•
|
||
Adding what the experience should be for PWAs. In the redesign, hadn't considered this experience. Will update when available.
Reporter | ||
Comment 2•4 months ago
|
||
I don't understand the logic..a pwa should give mobile app like experience, in that sense adding the nav bar is defeating the purpose, it no longer looks like app😕
Comment 3•3 months ago
|
||
Added a screenshot of the Chrome experience and the existing Firefox experience without the new Toolbar design.
Neither have a nav bar, though they do have a toolbar at the top (For Firefox, that's even true when "bottom toolbar" is enabled)
Comment 4•3 months ago
|
||
Aarjav says this is a beta experiment blocker.
Comment 5•3 months ago
|
||
To provide an app-like experience, no address bar or toolbar should be displayed when a user accesses a PWA.
Assignee | ||
Updated•2 months ago
|
Comment 6•2 months ago
|
||
I've made related changes in https://phabricator.services.mozilla.com/D213415.
Any ideas welcome.
Assignee | ||
Comment 7•2 months ago
|
||
Did some tests using https://paperplanes.world/ in Chrome and Fenix
- Custom tabs with the navbar enabled - https://drive.google.com/file/d/1EvYYT39aRXyRWcJgbiQN8lgo5nkGRS7y/view?usp=sharing
- PaperAirplanes PWA in Chrome - https://drive.google.com/file/d/1cUNtAdojVIJDdFKqRashFYIc6nJxyeni/view?usp=sharing
- PaperAirplanes PWA in Fenix with old toolbar - https://drive.google.com/file/d/1cPTXRWwbSRgh6z16y6raJq5iXYTTvRRa/view?usp=sharing
- PaperAirplanes PWA in Fenix with new toolbar - https://drive.google.com/file/d/16s1Vic7YHWMgvEfytuKdDgCJEReFebbS/view?usp=drive_link
Based on the above:
- we properly handle custom tabs, no changes are needed
- both the old and the new toolbars have issues for "installed" PWAs
- with the old toolbar:
- the PWA does not start in immersive mode - system navbar is shown
- when entering fullscreen it shows the "Entering full screen mode" message.
- with the new navbar
- the PWA does not start in immersive mode - both the address bar and navbar are take space
- when entering fullscreen it shows the "Entering full screen mode" message.
- with the old toolbar:
Assignee | ||
Comment 8•2 months ago
|
||
Updated•2 months ago
|
Assignee | ||
Comment 9•2 months ago
|
||
Abandoned my patch in favor of https://phabricator.services.mozilla.com/D213415 which would also solve this issue + others
And would prefer to have that land smoothly without conflicts.
Will update this for QA to validate once that patch lands.
Assignee | ||
Comment 10•2 months ago
|
||
The patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1901741 landed.
@ QA. Please help test that this issue was fixed.
Comment 11•1 month ago
|
||
Found a bug with toolab visibility in PWA:
Steps to reproduce
- Enable toolbar redesign
- Position address bar at bottom
- Open a PWA
- Navigate a link from PWA.
- Rotate the device to landscape.
- Rotate the device back to portrait.
- Press back
Expected behavior
The toolbar gets hidden on the original PWA page
Actual behavior
Original PWA page keeps the tooblar visible
Assignee | ||
Updated•1 month ago
|
Assignee | ||
Comment 12•1 month ago
|
||
With he help of Mike also this seems to be ready for QA validation
Comment 13•1 month ago
•
|
||
Tested on the latest Nightly 130.0a1 from 07/12 with Samsung Galaxy S22 Ultra (Android 14) and Samsung Tab S8 Ultra 5G (Android 14).
The address bar and the navigation toolbar are not displayed on PWAs installed from latest Nightly. I've tested this using the link Petru used, https://paperplanes.world/ in addition to olx.com and x.com.
However, I was able to reproduce the issue Mike described here and in ticket 1906784, but only with 1 less step compared to the initial flow.
STR:
- Open latest Nightly with the navigation toolbar enabled by default
- Position address bar at bottom
- Open a PWA
- Navigate a link from PWA.
- Rotate the device to landscape.
- Press back
Should I open a follow up issue for 1906784?
Comment 14•1 month ago
|
||
Increasing priority to P1 now that we're fixing toolbar phase 1's beta blockers.
Assignee | ||
Comment 15•1 month ago
|
||
@Delia Thank you for checking!
Opening a new issue describing the affecting scenario and linking it to 1906784 sounds good, thank you!
Assignee | ||
Updated•1 month ago
|
Comment 16•1 month ago
|
||
Opened 1907939.
Discussed with Petru on Slack and we agreed that this ticket can be closed as verified fixed.
Description
•