[go: nahoru, domu]

Closed Bug 1891615 Opened 4 months ago Closed 27 days ago

[toolbar redesign] Implement CFR for forward and back navbar buttons

Categories

(Fenix :: Toolbar, task, P1)

All
Android
task

Tracking

(firefox130 fixed)

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: royang, Assigned: tchoh)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [fxdroid])

Attachments

(2 files)

This is only to implement the CFR for the back/forward on the navigation bar.
Figma

Severity: -- → N/A
Whiteboard: [fxdroid]

Experiment Blocking

See Also: → 1889474

Setting toolbar redesign's Beta experiment blockers to priority P2 until we finish fixing our Nightly blockers.

Priority: -- → P2
Assignee: nobody → tchoh
Status: NEW → ASSIGNED

Increasing priority to P1 now that we're fixing toolbar phase 1's beta blockers.

Priority: P2 → P1

Discussed behavior with Aarjav around what triggers it:
https://mozilla.slack.com/archives/C0554F73006/p1720466233106069

Within 5 seconds, if the user does any of the following

  • Taps back button 2+ times.
  • Taps forward button 2+ times.
  • Taps back and forward 2+ times in any order.

This trigger would be satisfied and the CFR would only be shown. The CFR is only shown once irrespective of which action caused the trigger.
Arrow pointing: The arrow should point in between the 2 buttons. I have updated the designs.

Pushed by tchoh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3542fe9f15c1
CFR for forward and back navbar buttons r=android-reviewers,Roger
Status: ASSIGNED → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
Pushed by tchoh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dacb0832d9ac
updated apostrophe for string translations r=android-reviewers,Roger

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Depends on: 1912064
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: