[toolbar redesign] Snackbar blocks access to address bar or toolbar
Categories
(Fenix :: Toolbar, defect, P1)
Tracking
(firefox130 verified)
| Tracking | Status | |
|---|---|---|
| firefox130 | --- | verified |
People
(Reporter: royang, Assigned: petru)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][toolbar:130])
Attachments
(7 files, 1 obsolete file)
|
3.52 MB,
video/webm
|
Details | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
2.42 MB,
video/mp4
|
Details | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
When adding or removing a bookmark through the menu, the undo snack bar can block access to the addressbar (deleting bookmark) or toolbar (adding bookmark).
| Reporter | ||
Updated•4 months ago
|
Updated•4 months ago
|
| Reporter | ||
Updated•4 months ago
|
Comment 1•3 months ago
|
||
Setting toolbar redesign's Beta experiment blockers to priority P2 until we finish fixing our Nightly blockers.
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 2•1 month ago
|
||
| Assignee | ||
Comment 3•1 month ago
|
||
The snackbar for deleting a just added bookmark is shown from the bookmarks screen which does
not have access to browser's toolbar to anchor the snackbar to it.
The previous approach would use a boolean to know when to use the hardcoded height of the toolbar
as a padding for the snackbar.
With the navigation bar potentially doubling the height of the toolbar (when the toolbar is placed
on bottom of the screen) that approach seems like a hack that is hard to maintain.
The new approach has the browser screen informing the browser screen about a successfully deleted
bookmark and the browser screen can show a confirmation snackbar anchored to it's toolbar.
| Assignee | ||
Comment 4•1 month ago
|
||
Use the simpler method to create a snackbar for all such scenarios.
Avoid duplicated code.
| Assignee | ||
Comment 5•1 month ago
|
||
Updated•1 month ago
|
| Assignee | ||
Comment 6•1 month ago
|
||
This is useful when the text needed to be used is a literal string and not
one existing as a string resource that can be requested by it's id.
Updated•1 month ago
|
Updated•1 month ago
|
Updated•1 month ago
|
Comment 7•1 month ago
|
||
Increasing priority to P1 now that we're fixing toolbar phase 1's beta blockers.
| Assignee | ||
Comment 8•1 month ago
|
||
With the snackbar for when the bookmark is deleted moved to the AppStore when the bookmark
is deleted from the the edit screen of a bookmark we need to consume the AppState in the
bookmarks screen also.
Updated•1 month ago
|
| Assignee | ||
Comment 11•29 days ago
|
||
Test started to fail though if observing the flow everything runs as expected.
More information in bug 1909187.
Comment 12•27 days ago
|
||
Pushed by plingurar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cd462a4aa0b6 part 1 - Ensure that browser screen snackbars are shown on top of the navbar r=android-reviewers,tthibaud https://hg.mozilla.org/integration/autoland/rev/a529c2fb1e73 part 2 - Allow passing a string for snackbar text and action r=android-reviewers,gl,Roger https://hg.mozilla.org/integration/autoland/rev/705ed5a56fcd part 3 - Ensure snackbars for deleted bookmarks are shown above (vertically) the browser navbar r=android-reviewers,gl https://hg.mozilla.org/integration/autoland/rev/7506e8b6ecd8 Part 4 - Ensure snackbars for deleted bookmarks are shown in the bookmarks screen r=android-reviewers,gl https://hg.mozilla.org/integration/autoland/rev/fff95abc79d6 part 5 - Disable failing deleteBookmarkInEditModeTest r#mobiletest-reviewers r=android-reviewers,gl
Comment 13•27 days ago
|
||
Hey folks, it looks like this breaks a couple bookmark tests
- copyBookmarkURLTest
- cantSelectDefaultFoldersTest
- deleteBookmarkInEditModeTest
Petru, can you take a look?
| Assignee | ||
Comment 14•27 days ago
|
||
Indeed, there's an issue affecting bookmarks screen tests that show a snackbar, no issue in the actual functionality.
More context in bug 1909569.
Comment 15•27 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cd462a4aa0b6
https://hg.mozilla.org/mozilla-central/rev/a529c2fb1e73
https://hg.mozilla.org/mozilla-central/rev/705ed5a56fcd
https://hg.mozilla.org/mozilla-central/rev/7506e8b6ecd8
https://hg.mozilla.org/mozilla-central/rev/fff95abc79d6
Comment 16•20 days ago
|
||
Verified as fixed in the latest Nightly 130.0a1 from 07/31 with Google Pixel 8 Pro (Android 14) and Xiaomi 12 Pro (Android 13).
| Assignee | ||
Comment 17•13 days ago
|
||
Seems like there have been no new reports of related tests failing in bug 1909569.
Removing my NI which I used as a reminder to check.
Description
•