[go: nahoru, domu]
Closed Bug 1895153 Opened 4 months ago Closed 1 month ago

[Menu Redesign] Implement "Find in page..." menu functionality

Categories

(Fenix :: Toolbar, task, P1)

Product:
Fenix
Component:
Toolbar
Platform:
All
Android
Type:
task

Tracking

(firefox130 fixed)

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid] )

Attachments

(1 file, 1 obsolete file)

Bug 1895153 - Implement "Find in page..." menu functionality
48 bytes, text/x-phabricator-request
Details | Review
See Also: → 1895138
Assignee: nobody → gl
Status: NEW → ASSIGNED
Blocks: menu-redesign-main-menu
No longer blocks: menu-redesign
Severity: -- → N/A
Priority: P3 → P1
Attachment #9401343 - Attachment description: Bug 1895153 - [Menu Redesign] Implement "Find in page..." menu functionality → Bug 1895153 - Part 1: Implement "Find in page..." menu functionality

The Bugbug bot thinks this bug should belong to the 'Fenix::Toolbar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Toolbar
Attachment #9411448 - Attachment is obsolete: true
Attachment #9401343 - Attachment description: Bug 1895153 - Part 1: Implement "Find in page..." menu functionality → Bug 1895153 - Implement "Find in page..." menu functionality
Pushed by gluong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3db1258ab82
Implement "Find in page..." menu functionality r=android-reviewers,petru

Backed out for causing fenix apk test failures related to Find in page.

[task 2024-07-19T08:30:01.545Z]   SUCCESS
[task 2024-07-19T08:30:01.545Z] 
[task 2024-07-19T08:30:01.545Z]   TEST: WHEN find in page feature is started THEN record the find in page browser menu telemetry
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <manifest>: queries at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #70
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #448
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #535
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #544
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #553
[task 2024-07-19T08:30:01.645Z]     D/glean/MetricsPingSched: The 'metrics' ping was last sent on 1436572800000
[task 2024-07-19T08:30:01.645Z]     I/glean/MetricsPingSched: The 'metrics' ping was already sent today, 1721377801579.
[task 2024-07-19T08:30:01.645Z]     D/glean/MetricsPingSched: Scheduling the 'metrics' ping in 70198421ms
[task 2024-07-19T08:30:01.645Z]   TEST-UNEXPECTED-FAIL | org.mozilla.fenix.components.menu.MenuTelemetryMiddlewareTest.WHEN find in page feature is started THEN record the find in page browser menu telemetry | org.junit.ComparisonFailure: expected:<[find_in_page]> but was:<[quit]>
[task 2024-07-19T08:30:01.645Z] 
[task 2024-07-19T08:30:01.645Z]   TEST: WHEN navigating to the save to collection sheet THEN record the share browser menu telemetry
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <manifest>: queries at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #70
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #448
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #535
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #544
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #553
[task 2024-07-19T08:30:01.745Z]     D/glean/MetricsPingSched: The 'metrics' ping was last sent on 1436572800000
[task 2024-07-19T08:30:01.745Z]     I/glean/MetricsPingSched: The 'metrics' ping was already sent today, 1721377801649.
[task 2024-07-19T08:30:01.745Z]     D/glean/MetricsPingSched: Scheduling the 'metrics' ping in 70198351ms
[task 2024-07-19T08:30:01.745Z]   SUCCESS
Flags: needinfo?(gl)
Pushed by gluong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee9700ff62b0
Implement "Find in page..." menu functionality r=android-reviewers,petru
Flags: needinfo?(gl)

https://hg.mozilla.org/mozilla-central/rev/ee9700ff62b0

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: