[go: nahoru, domu]
Closed Bug 1899336 Opened 3 months ago Closed 21 days ago

Style pinned tabs and add new tab button with divider to vertical tabs

Categories

(Firefox :: Sidebar, task, P1)

Product:
Firefox
Component:
Sidebar
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: sclements, Assigned: sclements)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(1 file)

Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=Dao,#sidebar-reviewers
48 bytes, text/x-phabricator-request
Details | Review

I didn't include this in my initial patch in bug 1893655 because it looked to be more involved and requires changing how pinned tabs are positioned. See the spec. It'll also need a label added when the sidebar is in the expanded state.

There's currently a tabs-newtab-button element that's nested in the arrowscrollbox the same as tabbrowser-tabs here and that gets moved when the tabstrip moves, so we can probably repurpose that.

See Also: → 1899346
Depends on: 1893655
Summary: Add new tab button with divider to vertical tabs → Style pinned tabs and add new tab button with divider to vertical tabs
Assignee: nobody → sclements
Status: NEW → ASSIGNED
Duplicate of this bug: 1899577
Blocks: 1906888
Blocks: 1907058
  • Create a new container to house pinned tabs, new tab button and non-pinned tabs
  • Create new pinned tabs container to apply grid layout and overflow scrolling
  • Update test coverage for pinned tabs for both horizontal and vertical tabs
Attachment #9412480 - Attachment description: Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=Dao,#sidebar-reviewers → WIP: Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=Dao,#sidebar-reviewers
Attachment #9412480 - Attachment description: WIP: Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=Dao,#sidebar-reviewers → Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=Dao,#sidebar-reviewers
Blocks: 1909497
See Also: → 1909843
Duplicate of this bug: 1909691
Pushed by sclements@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f81bc4882ecc
Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane
Duplicate of this bug: 1910368

https://hg.mozilla.org/mozilla-central/rev/f81bc4882ecc

Status: ASSIGNED → RESOLVED
Closed: 21 days ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch

unpinned tab stay in pinned position on vertical sidebar until Firefox restart

Depends on: 1910576
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: