Closed
Bug 1905154
Opened 2 months ago
Closed 1 month ago
Restore dialog should remain open and display "Restoring..." while a recovery is in progress.
Categories
(Firefox :: Profile Backup, task, P1)
Firefox
Profile Backup
Tracking
()
RESOLVED
FIXED
130 Branch
| Tracking | Status | |
|---|---|---|
| firefox130 | --- | fixed |
People
(Reporter: fchasen, Assigned: mconley, NeedInfo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-device-migration])
Attachments
(1 file)
Currently the restore dialog closes on hitting confirm, but it should remain open and display "Restoring..." until it finishes or errors.
Figma: https://www.figma.com/design/vNbX4c0ws0L1qr0mxpKvsW/Fx-Backup?node-id=147-4568&t=sNX6m1uPdRT4sGPW-0
Updated•2 months ago
|
| Reporter | ||
Updated•2 months ago
|
Assignee: nobody → fchasen
Status: NEW → ASSIGNED
| Reporter | ||
Comment 1•2 months ago
|
||
- Adds a #recoveryInProgress method for BackupService to limit to one recovery at a time and update the state.
- Adds a recoveryError to the state for passing errors from recovery to components.
- Keeps the restore dialog open while the recovery is in process, disables the button and updates it's text to "Restoring..."
- Closes the restore dialog after the recovery has finished if no errors occured.
Figma: https://www.figma.com/design/vNbX4c0ws0L1qr0mxpKvsW/Fx-Backup?node-id=147-4568&t=rmWErO2I6lpY3Vz7-0
Depends on D214899
| Assignee | ||
Updated•2 months ago
|
Severity: -- → N/A
Priority: -- → P3
| Assignee | ||
Comment 2•1 month ago
|
||
fchasen is under the weather, so I'm taking this.
Assignee: fchasen → mconley
Comment 3•1 month ago
|
||
Setting a severity to pull this out of the triage queue. Marking P1 as it's assigned.
Severity: N/A → S3
Priority: P3 → P1
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d98136b45ed4 Restore dialog should remain open while a backup recovery is in progress. r=backup-reviewers,fluent-reviewers,flod,sthompson
Comment 5•1 month ago
|
||
Backed out for causing mozilla::dom::PathUtils::InitFileWithPath related mochitests failures.
- Backout link
- Push with failures
- Failure Log
- Failure line: PROCESS-CRASH | MOZ_RELEASE_ASSERT(!aPath.Contains(u'/')) (Windows paths cannot include forward slashes) [@ mozilla::dom::PathUtils::InitFileWithPath] | browser/components/backup/tests/browser/browser_settings_restore_from_backup.js
Also, please check these assertion failures.
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/26a5aac61c4b Restore dialog should remain open while a backup recovery is in progress. r=backup-reviewers,fluent-reviewers,flod,sthompson
Comment 7•1 month ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox130:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•