[go: nahoru, domu]
Closed Bug 1907641 Opened 1 month ago Closed 1 month ago

[Toolbar Redesign] In landscape version, the home button shouldn't be present in the toolbar, there is a new tab button next to tab tray icon.

Categories

(Fenix :: Toolbar, task, P1)

Product:
Fenix
Component:
Toolbar
Platform:
All
Android
Type:
task

Tracking

(firefox130 fixed)

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: aarjav, Assigned: gl)

References

Details

Attachments

(2 files)

Screenshot 2024-07-12 at 2.42.36 PM.png
3.09 MB, image/png
Details
Bug 1907641 - Remove the Home button from being shown when the navigation bar is enabled
48 bytes, text/x-phabricator-request
Details | Review

Steps to reproduce

  1. Open a website
  2. Switch to landscape mode

Expected behavior

  • There shouldn't be any home button. There should be '+' new tab button next to the tab tray icon

Actual behavior

  • There is a home button next to the forward button.

Device information

  • Firefox version: Nightly
  • Android device model: Pixel 6
  • Android OS version: Latest

Any additional information?

Figma Link: https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/Toolbar-Redesign?node-id=17733-168009&t=9COmjFtV30LRRYCe-4

Assignee: nobody → gl
Type: defect → task
Blocks: 1906558
Severity: -- → N/A
Status: NEW → ASSIGNED
Priority: -- → P3
Priority: P3 → P1

Thank you for the quick action on this Gabriel!

Seeing that there is still some work needed to get the "+" button shown instead, should we wait on removing the home button until the "+" button is there to allow users to easily add new tabs from the toolbar - without having to go through the tabstray for this?

Flags: needinfo?(gl)
Flags: needinfo?(apandya)

Saw that bug 1906560 which would add the "+" button is ready to land so this can land also.

Flags: needinfo?(gl)
Flags: needinfo?(apandya)
Pushed by gluong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/37c3ac73f3f1
Remove the Home button from being shown when the navigation bar is enabled r=android-reviewers,petru

https://hg.mozilla.org/mozilla-central/rev/37c3ac73f3f1

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: