Closed
Bug 1907646
Opened 1 month ago
Closed 1 month ago
[Toolbar Redesign] Display the correct menu items in the tab counter menu when the navigation bar is enabled
Categories
(Fenix :: Toolbar, task, P1)
Tracking
(firefox130 fixed)
RESOLVED
FIXED
130 Branch
| Tracking | Status | |
|---|---|---|
| firefox130 | --- | fixed |
People
(Reporter: aarjav, Assigned: gl)
References
Details
Attachments
(4 files)
Steps to reproduce
- Open a website
- Set toolbar placement settings to bottom.
- Long press tab tray icon.
Expected behavior
- The order of context menu items shouldn't change, it should follow the same order irrespective of the top/bottom placement of address bar.
Actual behavior
- The order is inverted when the address bar is placement at the bottom.
Device information
- Firefox version: nightly
- Android device model: Pixel 6
- Android OS version: latest
Any additional information?
| Reporter | ||
Updated•1 month ago
|
Assignee: nobody → gl
| Assignee | ||
Updated•1 month ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Comment 1•1 month ago
|
||
Increasing priority to P1 now that we're fixing toolbar phase 1's beta blockers.
Priority: P3 → P1
| Assignee | ||
Comment 2•1 month ago
|
||
| Assignee | ||
Comment 3•1 month ago
|
||
- When the navigation bar is enabled, the tab counter menu on the homepage should always display the new tab and new private tab menu item.
- Figma: https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/Toolbar-Redesign?node-id=17476-162903&t=A1phoWsupqwZNW9a-4
| Assignee | ||
Comment 4•1 month ago
|
||
- Do not reverse the menu items when the tab counter menu is displayed with the navigation bar enabled.
- Figma https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/Toolbar-Redesign?node-id=17476-163389&t=A1phoWsupqwZNW9a-4
| Assignee | ||
Updated•1 month ago
|
Summary: [Toolbar Redesign] The order of context menu items are inverted when the user has selected the placement of toolbar to bottom. → [Toolbar Redesign] Display the correct menu items in the tab counter menu when the navigation bar is enabled
Comment 5•1 month ago
|
||
Was curious about why the menu is incorrect and saw that the ticket in which the menu was recently added - bug 1894512 linked other Figma specs which said
Long Pressing Tab tray icon
User can access New tab menu on long-pressing the tab tray icon. Same as current toolbar implementation.
See Also: → 1894512
Updated•1 month ago
|
Attachment #9412653 -
Attachment description: Bug 1907646 - Part 1: Rename TabCounterMenuTest to FelixTabCounterMenuTest → Bug 1907646 - Part 1: Rename TabCounterMenuTest to FenixTabCounterMenuTest
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/052ad1c3245a Part 1: Rename TabCounterMenuTest to FenixTabCounterMenuTest r=android-reviewers,petru https://hg.mozilla.org/integration/autoland/rev/a4c4470f5f77 Part 2: Display the new tab and new private tab menu item in the Tab Counter menu on the Homepage r=android-reviewers,petru https://hg.mozilla.org/integration/autoland/rev/5f83ea63329f Part 3: Do not reverse the menu items when the tab counter menu is displayed in the navigation bar r=android-reviewers,petru
Comment 7•1 month ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/052ad1c3245a
https://hg.mozilla.org/mozilla-central/rev/a4c4470f5f77
https://hg.mozilla.org/mozilla-central/rev/5f83ea63329f
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox130:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•