Jason Haar Reporter
	Description • 19 years ago

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

When you delete an attachment, Thunderbird 1.5 replaces the attachment with MIME code like:

Content-Type: text/x-moz-deleted; name="Deleted: tibs-rescue.iso"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline; filename="Deleted:tibs-rescue.iso"
X-Mozilla-Altered: AttachmentDeleted; date="Mon Nov 21 10:45:27 2005"


There's a slight mistake there: "Deleted: " vs "Deleted:"

Maybe that filename should be created as a variable first and then used for both lines? 

Our AV triggers on that due to it looking like an attempt to pass an attachment through with different filenames...

Reproducible: Always

	Magnus Melin [:mkmelin]
	Comment 1 • 19 years ago

-> new, there is a missing space there.
Also, the string is not localizable (but the string for it is already in messenger.properties). Patch coming up.

	David :Bienvenu
	Comment 3 • 19 years ago

Comment on attachment 210044 [details] [diff] [review]
proposed fix

I'm not sure that just sticking a utf8 string in a  content type name field is the right thing to do. Maybe it is, but cc'ing jshin

	Jungshik Shin
	Comment 4 • 19 years ago

Comment on attachment 210044 [details] [diff] [review]
proposed fix

Sorry I missed this. 

> (From update of attachment 210044 [details] [diff] [review] [edit])
> I'm not sure that just sticking a utf8 string in a  content type name field is
> the right thing to do. Maybe it is, but cc'ing jshin

Per the *current* mail standard, we should use RFC 2231. The function to use is RFC2231ParmFolding at 
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompUtils.cpp#1235

It's a static function so that we have to move it somewhere else.

	Magnus Melin [:mkmelin]
	Comment 5 • 19 years ago

I guess this depends on bug 295084 then...

	Roberto Principiano
	Comment 6 • 18 years ago

The string is still not localizable and attachmentDeletePrefix from messenger.properties still not used. Added l10n@mozilla.com to CC.

	Hubert Gajewski
	Comment 7 • 18 years ago

(In reply to comment #1 and commnet #6)
blocking‑thunderbird2=?

	Scott MacGregor
	Comment 8 • 18 years ago

Moving off bugs that didn't make the deadline for Thunderbird 2. 

	Magnus Melin [:mkmelin]
	Comment 10 • 15 years ago

The space after "Deleted:" was added in bug 329915. 
Making it localizable is more work than I'd like to spend on this, so ->defaults

	Jesper Kristensen
	Comment 12 • 15 years ago

Another unlocalizable string next to it:
"You deleted an attachment from this message. The original MIME headers for the attachment were:"

	Wayne Mery (:wsmwk)
	Comment 13 • 14 years ago

Jesper, can you file a bug for this...
> Another unlocalizable string next to it:
> "You deleted an attachment from this message. The original MIME headers for the
> attachment were:"

	Jesper Kristensen
	Comment 14 • 14 years ago

(In reply to comment #13)
> Jesper, can you file a bug for this...

Isn't this the bug?

	Thomas D. (:thomas8)
	Comment 15 • 13 years ago

Simon Montagu (assignee), are you still working on this?
Otherwise, please assign to nobody.