[go: nahoru, domu]
Google Git
Sign in
chromium / chromium / src / a2a7acf06e257e7c483f18073e8760536669e3df / . / sql / sqlite_features_unittest.cc
blob: 29d42081f7904e367389f21fa0b518dc0d48fc2c [file] [log] [blame]
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stddef.h>
#include <stdint.h>
#include <string>
#include <tuple>
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/memory_mapped_file.h"
#include "base/files/scoped_temp_dir.h"
#include "base/functional/bind.h"
#include "build/build_config.h"
#include "sql/database.h"
#include "sql/statement.h"
#include "sql/test/scoped_error_expecter.h"
#include "sql/test/test_helpers.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/sqlite/sqlite3.h"
#if BUILDFLAG(IS_APPLE)
#include "base/apple/backup_util.h"
#endif
// Test that certain features are/are-not enabled in our SQLite.
namespace sql {
namespace {
using sql::test::ExecuteWithResult;
using sql::test::ExecuteWithResults;
} // namespace
class SQLiteFeaturesTest : public testing::Test {
public:
~SQLiteFeaturesTest() override = default;
void SetUp() override {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
db_path_ = temp_dir_.GetPath().AppendASCII("sqlite_features_test.sqlite");
ASSERT_TRUE(db_.Open(db_path_));
}
bool Reopen() {
db_.Close();
return db_.Open(db_path_);
}
protected:
base::ScopedTempDir temp_dir_;
base::FilePath db_path_;
Database db_;
// The error code of the most recent error.
int error_ = SQLITE_OK;
// Original statement which has caused the error.
std::string sql_text_;
};
// Do not include fts1 support, it is not useful, and nobody is
// looking at it.
TEST_F(SQLiteFeaturesTest, NoFTS1) {
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(SQLITE_ERROR);
EXPECT_FALSE(db_.Execute("CREATE VIRTUAL TABLE foo USING fts1(x)"));
EXPECT_TRUE(expecter.SawExpectedErrors());
}
// Do not include fts2 support, it is not useful, and nobody is
// looking at it.
TEST_F(SQLiteFeaturesTest, NoFTS2) {
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(SQLITE_ERROR);
EXPECT_FALSE(db_.Execute("CREATE VIRTUAL TABLE foo USING fts2(x)"));
EXPECT_TRUE(expecter.SawExpectedErrors());
}
// fts3 is exposed in WebSQL.
TEST_F(SQLiteFeaturesTest, FTS3) {
EXPECT_TRUE(db_.Execute("CREATE VIRTUAL TABLE foo USING fts3(x)"));
}
// Originally history used fts2, which Chromium patched to treat "foo*" as a
// prefix search, though the icu tokenizer would return it as two tokens {"foo",
// "*"}. Test that fts3 works correctly.
TEST_F(SQLiteFeaturesTest, FTS3_Prefix) {
db_.Close();
sql::Database db({.enable_virtual_tables_discouraged = true});
ASSERT_TRUE(db.Open(db_path_));
static constexpr char kCreateSql[] =
"CREATE VIRTUAL TABLE foo USING fts3(x, tokenize icu)";
ASSERT_TRUE(db.Execute(kCreateSql));
ASSERT_TRUE(db.Execute("INSERT INTO foo (x) VALUES ('test')"));
EXPECT_EQ("test",
ExecuteWithResult(&db, "SELECT x FROM foo WHERE x MATCH 'te*'"));
}
// Verify that Chromium's SQLite is compiled with HAVE_USLEEP defined. With
// HAVE_USLEEP, SQLite uses usleep() with millisecond granularity. Otherwise it
// uses sleep() with second granularity.
TEST_F(SQLiteFeaturesTest, UsesUsleep) {
base::TimeTicks before = base::TimeTicks::Now();
sqlite3_sleep(1);
base::TimeDelta delta = base::TimeTicks::Now() - before;
// It is not impossible for this to be over 1000 if things are compiled
// correctly, but that is very unlikely. Most platforms seem to be exactly
// 1ms, with the rest at 2ms, and the worst observed cases was ASAN at 7ms.
EXPECT_LT(delta.InMilliseconds(), 1000);
}
// Ensure that our SQLite version has working foreign key support with cascade
// delete support.
TEST_F(SQLiteFeaturesTest, ForeignKeySupport) {
ASSERT_TRUE(db_.Execute("PRAGMA foreign_keys=1"));
ASSERT_TRUE(db_.Execute("CREATE TABLE parents (id INTEGER PRIMARY KEY)"));
ASSERT_TRUE(db_.Execute(
"CREATE TABLE children ("
" id INTEGER PRIMARY KEY,"
" pid INTEGER NOT NULL REFERENCES parents(id) ON DELETE CASCADE)"));
static const char kSelectParentsSql[] = "SELECT * FROM parents ORDER BY id";
static const char kSelectChildrenSql[] = "SELECT * FROM children ORDER BY id";
// Inserting without a matching parent should fail with constraint violation.
EXPECT_EQ("", ExecuteWithResult(&db_, kSelectParentsSql));
{
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(SQLITE_CONSTRAINT | SQLITE_CONSTRAINT_FOREIGNKEY);
EXPECT_FALSE(db_.Execute("INSERT INTO children VALUES (10, 1)"));
EXPECT_TRUE(expecter.SawExpectedErrors());
}
EXPECT_EQ("", ExecuteWithResult(&db_, kSelectChildrenSql));
// Inserting with a matching parent should work.
ASSERT_TRUE(db_.Execute("INSERT INTO parents VALUES (1)"));
EXPECT_EQ("1", ExecuteWithResults(&db_, kSelectParentsSql, "|", "\n"));
EXPECT_TRUE(db_.Execute("INSERT INTO children VALUES (11, 1)"));
EXPECT_TRUE(db_.Execute("INSERT INTO children VALUES (12, 1)"));
EXPECT_EQ("11|1\n12|1",
ExecuteWithResults(&db_, kSelectChildrenSql, "|", "\n"));
// Deleting the parent should cascade, deleting the children as well.
ASSERT_TRUE(db_.Execute("DELETE FROM parents"));
EXPECT_EQ("", ExecuteWithResult(&db_, kSelectParentsSql));
EXPECT_EQ("", ExecuteWithResult(&db_, kSelectChildrenSql));
}
// Ensure that our SQLite version supports booleans.
TEST_F(SQLiteFeaturesTest, BooleanSupport) {
ASSERT_TRUE(
db_.Execute("CREATE TABLE flags ("
" id INTEGER PRIMARY KEY,"
" true_flag BOOL NOT NULL DEFAULT TRUE,"
" false_flag BOOL NOT NULL DEFAULT FALSE)"));
ASSERT_TRUE(db_.Execute(
"ALTER TABLE flags ADD COLUMN true_flag2 BOOL NOT NULL DEFAULT TRUE"));
ASSERT_TRUE(db_.Execute(
"ALTER TABLE flags ADD COLUMN false_flag2 BOOL NOT NULL DEFAULT FALSE"));
ASSERT_TRUE(db_.Execute("INSERT INTO flags (id) VALUES (1)"));
sql::Statement s(db_.GetUniqueStatement(
"SELECT true_flag, false_flag, true_flag2, false_flag2"
" FROM flags WHERE id=1;"));
ASSERT_TRUE(s.Step());
EXPECT_TRUE(s.ColumnBool(0)) << " default TRUE at table creation time";
EXPECT_TRUE(!s.ColumnBool(1)) << " default FALSE at table creation time";
EXPECT_TRUE(s.ColumnBool(2)) << " default TRUE added by altering the table";
EXPECT_TRUE(!s.ColumnBool(3)) << " default FALSE added by altering the table";
}
TEST_F(SQLiteFeaturesTest, IcuEnabled) {
sql::Statement lower_en(db_.GetUniqueStatement("SELECT lower('I', 'en_us')"));
ASSERT_TRUE(lower_en.Step());
EXPECT_EQ("i", lower_en.ColumnString(0));
sql::Statement lower_tr(db_.GetUniqueStatement("SELECT lower('I', 'tr_tr')"));
ASSERT_TRUE(lower_tr.Step());
EXPECT_EQ("\u0131", lower_tr.ColumnString(0));
}
// Verify that OS file writes are reflected in the memory mapping of a
// memory-mapped file. Normally SQLite writes to memory-mapped files using
// memcpy(), which should stay consistent. Our SQLite is slightly patched to
// mmap read only, then write using OS file writes. If the memory-mapped
// version doesn't reflect the OS file writes, SQLite's memory-mapped I/O should
// be disabled on this platform using SQLITE_MAX_MMAP_SIZE=0.
TEST_F(SQLiteFeaturesTest, Mmap) {
// Try to turn on mmap'ed I/O.
std::ignore = db_.Execute("PRAGMA mmap_size = 1048576");
{
sql::Statement s(db_.GetUniqueStatement("PRAGMA mmap_size"));
ASSERT_TRUE(s.Step());
ASSERT_GT(s.ColumnInt64(0), 0);
}
db_.Close();
const uint32_t kFlags =
base::File::FLAG_OPEN | base::File::FLAG_READ | base::File::FLAG_WRITE;
char buf[4096];
// Create a file with a block of '0', a block of '1', and a block of '2'.
{
base::File f(db_path_, kFlags);
ASSERT_TRUE(f.IsValid());
memset(buf, '0', sizeof(buf));
ASSERT_EQ(f.Write(0*sizeof(buf), buf, sizeof(buf)), (int)sizeof(buf));
memset(buf, '1', sizeof(buf));
ASSERT_EQ(f.Write(1*sizeof(buf), buf, sizeof(buf)), (int)sizeof(buf));
memset(buf, '2', sizeof(buf));
ASSERT_EQ(f.Write(2*sizeof(buf), buf, sizeof(buf)), (int)sizeof(buf));
}
// mmap the file and verify that everything looks right.
{
base::MemoryMappedFile m;
ASSERT_TRUE(m.Initialize(db_path_));
memset(buf, '0', sizeof(buf));
ASSERT_EQ(0, memcmp(buf, m.data() + 0*sizeof(buf), sizeof(buf)));
memset(buf, '1', sizeof(buf));
ASSERT_EQ(0, memcmp(buf, m.data() + 1*sizeof(buf), sizeof(buf)));
memset(buf, '2', sizeof(buf));
ASSERT_EQ(0, memcmp(buf, m.data() + 2*sizeof(buf), sizeof(buf)));
// Scribble some '3' into the first page of the file, and verify that it
// looks the same in the memory mapping.
{
base::File f(db_path_, kFlags);
ASSERT_TRUE(f.IsValid());
memset(buf, '3', sizeof(buf));
ASSERT_EQ(f.Write(0*sizeof(buf), buf, sizeof(buf)), (int)sizeof(buf));
}
ASSERT_EQ(0, memcmp(buf, m.data() + 0*sizeof(buf), sizeof(buf)));
// Repeat with a single '4' in case page-sized blocks are different.
const size_t kOffset = 1*sizeof(buf) + 123;
ASSERT_NE('4', m.data()[kOffset]);
{
base::File f(db_path_, kFlags);
ASSERT_TRUE(f.IsValid());
buf[0] = '4';
ASSERT_EQ(f.Write(kOffset, buf, 1), 1);
}
ASSERT_EQ('4', m.data()[kOffset]);
}
}
// Verify that http://crbug.com/248608 is fixed. In this bug, the
// compiled regular expression is effectively cached with the prepared
// statement, causing errors if the regular expression is rebound.
TEST_F(SQLiteFeaturesTest, CachedRegexp) {
ASSERT_TRUE(db_.Execute("CREATE TABLE r (id INTEGER UNIQUE, x TEXT)"));
ASSERT_TRUE(db_.Execute("INSERT INTO r VALUES (1, 'this is a test')"));
ASSERT_TRUE(db_.Execute("INSERT INTO r VALUES (2, 'that was a test')"));
ASSERT_TRUE(db_.Execute("INSERT INTO r VALUES (3, 'this is a stickup')"));
ASSERT_TRUE(db_.Execute("INSERT INTO r VALUES (4, 'that sucks')"));
static const char kSimpleSql[] = "SELECT SUM(id) FROM r WHERE x REGEXP ?";
sql::Statement s(db_.GetCachedStatement(SQL_FROM_HERE, kSimpleSql));
s.BindString(0, "this.*");
ASSERT_TRUE(s.Step());
EXPECT_EQ(4, s.ColumnInt(0));
s.Reset(true);
s.BindString(0, "that.*");
ASSERT_TRUE(s.Step());
EXPECT_EQ(6, s.ColumnInt(0));
s.Reset(true);
s.BindString(0, ".*test");
ASSERT_TRUE(s.Step());
EXPECT_EQ(3, s.ColumnInt(0));
s.Reset(true);
s.BindString(0, ".* s[a-z]+");
ASSERT_TRUE(s.Step());
EXPECT_EQ(7, s.ColumnInt(0));
}
TEST_F(SQLiteFeaturesTest, JsonIsDisabled) {
static constexpr char kCreateSql[] =
"CREATE TABLE rows(id INTEGER PRIMARY KEY NOT NULL, data TEXT NOT NULL)";
ASSERT_TRUE(db_.Execute(kCreateSql));
ASSERT_TRUE(db_.Execute("INSERT INTO rows(data) VALUES('{\"a\": 1}')"));
{
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(SQLITE_ERROR);
EXPECT_FALSE(db_.Execute("SELECT data -> '$.a' FROM rows"));
EXPECT_TRUE(expecter.SawExpectedErrors());
}
}
TEST_F(SQLiteFeaturesTest, WindowFunctionsAreDisabled) {
static constexpr char kCreateSql[] =
"CREATE TABLE rows(id INTEGER PRIMARY KEY NOT NULL, data TEXT NOT NULL)";
ASSERT_TRUE(db_.Execute(kCreateSql));
ASSERT_TRUE(db_.Execute("INSERT INTO rows(id, data) VALUES(1, 'a')"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows(id, data) VALUES(2, 'c')"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows(id, data) VALUES(3, 'b')"));
{
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(SQLITE_ERROR);
EXPECT_FALSE(db_.Execute(
"SELECT data, row_number() OVER (ORDER BY data) AS rank FROM rows "
"ORDER BY id"));
EXPECT_TRUE(expecter.SawExpectedErrors());
}
}
// The "No Isolation Between Operations On The Same Database Connection" section
// in https://sqlite.org/isolation.html implies that it's safe to issue multiple
// concurrent SELECTs against the same area.
//
// Chrome code is allowed to rely on this guarantee. So, we test for it here, to
// catch any regressions introduced by SQLite upgrades.
TEST_F(SQLiteFeaturesTest, ConcurrentSelects) {
ASSERT_TRUE(db_.Execute("CREATE TABLE rows(id INTEGER PRIMARY KEY, t TEXT)"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(2, 'two')"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(3, 'three')"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(4, 'four')"));
static const char kSelectAllSql[] = "SELECT id,t FROM rows";
static const char kSelectEvenSql[] = "SELECT id,t FROM rows WHERE id%2=0";
sql::Statement select1(db_.GetCachedStatement(SQL_FROM_HERE, kSelectEvenSql));
sql::Statement select2(db_.GetCachedStatement(SQL_FROM_HERE, kSelectEvenSql));
sql::Statement select3(db_.GetCachedStatement(SQL_FROM_HERE, kSelectAllSql));
ASSERT_TRUE(select1.Step());
EXPECT_EQ(select1.ColumnInt(0), 2);
EXPECT_EQ(select1.ColumnString(1), "two");
ASSERT_TRUE(select2.Step());
EXPECT_EQ(select2.ColumnInt(0), 2);
EXPECT_EQ(select2.ColumnString(1), "two");
ASSERT_TRUE(select3.Step());
EXPECT_EQ(select3.ColumnInt(0), 2);
EXPECT_EQ(select3.ColumnString(1), "two");
ASSERT_TRUE(select1.Step());
EXPECT_EQ(select1.ColumnInt(0), 4);
EXPECT_EQ(select1.ColumnString(1), "four");
ASSERT_TRUE(select3.Step());
EXPECT_EQ(select3.ColumnInt(0), 3);
EXPECT_EQ(select3.ColumnString(1), "three");
ASSERT_TRUE(select2.Step());
EXPECT_EQ(select2.ColumnInt(0), 4);
EXPECT_EQ(select2.ColumnString(1), "four");
EXPECT_FALSE(select2.Step());
ASSERT_TRUE(select3.Step());
EXPECT_EQ(select3.ColumnInt(0), 4);
EXPECT_EQ(select3.ColumnString(1), "four");
select2.Reset(/*clear_bound_vars=*/true);
ASSERT_TRUE(select2.Step());
EXPECT_EQ(select2.ColumnInt(0), 2);
EXPECT_EQ(select2.ColumnString(1), "two");
EXPECT_FALSE(select1.Step());
}
// The "No Isolation Between Operations On The Same Database Connection" section
// in https://sqlite.org/isolation.html states that it's safe to DELETE a row
// that was just returned by sqlite_step() executing a SELECT statement.
//
// Chrome code is allowed to rely on this guarantee. So, we test for it here, to
// catch any regressions introduced by SQLite upgrades.
TEST_F(SQLiteFeaturesTest, DeleteCurrentlySelectedRow) {
ASSERT_TRUE(db_.Execute("CREATE TABLE rows(id INTEGER PRIMARY KEY, t TEXT)"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(2, 'two')"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(3, 'three')"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(4, 'four')"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(5, 'five')"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(6, 'six')"));
static const char kSelectEvenSql[] = "SELECT id,t FROM rows WHERE id%2=0";
sql::Statement select(db_.GetCachedStatement(SQL_FROM_HERE, kSelectEvenSql));
ASSERT_TRUE(select.Step());
ASSERT_EQ(select.ColumnInt(0), 2);
ASSERT_EQ(select.ColumnString(1), "two");
ASSERT_TRUE(db_.Execute("DELETE FROM rows WHERE id=2"));
ASSERT_TRUE(select.Step());
ASSERT_EQ(select.ColumnInt(0), 4);
ASSERT_EQ(select.ColumnString(1), "four");
ASSERT_TRUE(db_.Execute("DELETE FROM rows WHERE id=4"));
ASSERT_TRUE(select.Step());
ASSERT_EQ(select.ColumnInt(0), 6);
ASSERT_EQ(select.ColumnString(1), "six");
ASSERT_TRUE(db_.Execute("DELETE FROM rows WHERE id=6"));
EXPECT_FALSE(select.Step());
// Check that the DELETEs were applied as expected.
static const char kSelectAllSql[] = "SELECT id,t FROM rows";
sql::Statement select_all(
db_.GetCachedStatement(SQL_FROM_HERE, kSelectAllSql));
std::vector<int> remaining_ids;
std::vector<std::string> remaining_texts;
while (select_all.Step()) {
remaining_ids.push_back(select_all.ColumnInt(0));
remaining_texts.push_back(select_all.ColumnString(1));
}
std::vector<int> expected_remaining_ids = {3, 5};
EXPECT_EQ(expected_remaining_ids, remaining_ids);
std::vector<std::string> expected_remaining_texts = {"three", "five"};
EXPECT_EQ(expected_remaining_texts, remaining_texts);
}
// The "No Isolation Between Operations On The Same Database Connection" section
// in https://sqlite.org/isolation.html states that it's safe to DELETE a row
// that was previously by sqlite_step() executing a SELECT statement.
//
// Chrome code is allowed to rely on this guarantee. So, we test for it here, to
// catch any regressions introduced by SQLite upgrades.
TEST_F(SQLiteFeaturesTest, DeletePreviouslySelectedRows) {
ASSERT_TRUE(db_.Execute("CREATE TABLE rows(id INTEGER PRIMARY KEY, t TEXT)"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(2, 'two')"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(3, 'three')"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(4, 'four')"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(5, 'five')"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows VALUES(6, 'six')"));
static const char kSelectEvenSql[] = "SELECT id,t FROM rows WHERE id%2=0";
sql::Statement select(db_.GetCachedStatement(SQL_FROM_HERE, kSelectEvenSql));
ASSERT_TRUE(select.Step());
ASSERT_EQ(select.ColumnInt(0), 2);
ASSERT_EQ(select.ColumnString(1), "two");
ASSERT_TRUE(select.Step());
ASSERT_EQ(select.ColumnInt(0), 4);
ASSERT_EQ(select.ColumnString(1), "four");
ASSERT_TRUE(db_.Execute("DELETE FROM rows WHERE id=2"));
ASSERT_TRUE(select.Step());
ASSERT_EQ(select.ColumnInt(0), 6);
ASSERT_EQ(select.ColumnString(1), "six");
ASSERT_TRUE(db_.Execute("DELETE FROM rows WHERE id=4"));
ASSERT_TRUE(db_.Execute("DELETE FROM rows WHERE id=6"));
EXPECT_FALSE(select.Step());
// Check that the DELETEs were applied as expected.
static const char kSelectAllSql[] = "SELECT id,t FROM rows";
sql::Statement select_all(
db_.GetCachedStatement(SQL_FROM_HERE, kSelectAllSql));
std::vector<int> remaining_ids;
std::vector<std::string> remaining_texts;
while (select_all.Step()) {
remaining_ids.push_back(select_all.ColumnInt(0));
remaining_texts.push_back(select_all.ColumnString(1));
}
std::vector<int> expected_remaining_ids = {3, 5};
EXPECT_EQ(expected_remaining_ids, remaining_ids);
std::vector<std::string> expected_remaining_texts = {"three", "five"};
EXPECT_EQ(expected_remaining_texts, remaining_texts);
}
// The "No Isolation Between Operations On The Same Database Connection" section
// in https://sqlite.org/isolation.html states that it's safe to DELETE a row
// while a SELECT statement executes, but the DELETEd row may or may not show up
// in the SELECT results. (See the test above for a case where the DELETEd row
// is guaranteed to now show up in the SELECT results.)
//
// This seems to imply that DELETEing from a table that is not read by the
// concurrent SELECT statement is safe and well-defined, as the DELETEd row(s)
// cannot possibly show up in the SELECT results.
//
// Chrome features are allowed to rely on the implication above, because it
// comes in very handy for DELETEing data across multiple tables. This test
// ensures that our assumption remains valid.
TEST_F(SQLiteFeaturesTest, DeleteWhileSelectingFromDifferentTable) {
ASSERT_TRUE(db_.Execute("CREATE TABLE main(id INTEGER PRIMARY KEY, t TEXT)"));
ASSERT_TRUE(db_.Execute("INSERT INTO main VALUES(2, 'two')"));
ASSERT_TRUE(db_.Execute("INSERT INTO main VALUES(3, 'three')"));
ASSERT_TRUE(db_.Execute("INSERT INTO main VALUES(4, 'four')"));
ASSERT_TRUE(db_.Execute("INSERT INTO main VALUES(5, 'five')"));
ASSERT_TRUE(db_.Execute("INSERT INTO main VALUES(6, 'six')"));
ASSERT_TRUE(
db_.Execute("CREATE TABLE other(id INTEGER PRIMARY KEY, t TEXT)"));
ASSERT_TRUE(db_.Execute("INSERT INTO other VALUES(1, 'one')"));
ASSERT_TRUE(db_.Execute("INSERT INTO other VALUES(2, 'two')"));
ASSERT_TRUE(db_.Execute("INSERT INTO other VALUES(3, 'three')"));
ASSERT_TRUE(db_.Execute("INSERT INTO other VALUES(4, 'four')"));
ASSERT_TRUE(db_.Execute("INSERT INTO other VALUES(5, 'five')"));
ASSERT_TRUE(db_.Execute("INSERT INTO other VALUES(6, 'six')"));
ASSERT_TRUE(db_.Execute("INSERT INTO other VALUES(7, 'seven')"));
static const char kSelectEvenSql[] = "SELECT id,t FROM main WHERE id%2=0";
sql::Statement select(db_.GetCachedStatement(SQL_FROM_HERE, kSelectEvenSql));
ASSERT_TRUE(select.Step());
ASSERT_EQ(select.ColumnInt(0), 2);
ASSERT_EQ(select.ColumnString(1), "two");
EXPECT_TRUE(db_.Execute("DELETE FROM other WHERE id=2"));
ASSERT_TRUE(select.Step());
ASSERT_EQ(select.ColumnInt(0), 4);
ASSERT_EQ(select.ColumnString(1), "four");
ASSERT_TRUE(select.Step());
ASSERT_EQ(select.ColumnInt(0), 6);
ASSERT_EQ(select.ColumnString(1), "six");
ASSERT_TRUE(db_.Execute("DELETE FROM other WHERE id=4"));
ASSERT_TRUE(db_.Execute("DELETE FROM other WHERE id=5"));
ASSERT_TRUE(db_.Execute("DELETE FROM other WHERE id=6"));
EXPECT_FALSE(select.Step());
// Check that the DELETEs were applied as expected.
static const char kSelectAllSql[] = "SELECT id,t FROM other";
sql::Statement select_all(
db_.GetCachedStatement(SQL_FROM_HERE, kSelectAllSql));
std::vector<int> remaining_ids;
std::vector<std::string> remaining_texts;
while (select_all.Step()) {
remaining_ids.push_back(select_all.ColumnInt(0));
remaining_texts.push_back(select_all.ColumnString(1));
}
std::vector<int> expected_remaining_ids = {1, 3, 7};
EXPECT_EQ(expected_remaining_ids, remaining_ids);
std::vector<std::string> expected_remaining_texts = {"one", "three", "seven"};
EXPECT_EQ(expected_remaining_texts, remaining_texts);
}
// The "No Isolation Between Operations On The Same Database Connection" section
// in https://sqlite.org/isolation.html states that it's possible to INSERT in
// a table while concurrently executing a SELECT statement reading from it, but
// it's undefined whether the row will show up in the SELECT statement's results
// or not.
//
// Given this ambiguity, Chrome code is not allowed to INSERT in the same table
// as a concurrent SELECT. However, it is allowed to INSERT in a table which is
// not covered by SELECT, because this greatly simplifes migrations. So, we test
// the ability to INSERT in a table while SELECTing from another table, to
// catch any regressions introduced by SQLite upgrades.
TEST_F(SQLiteFeaturesTest, InsertWhileSelectingFromDifferentTable) {
ASSERT_TRUE(db_.Execute("CREATE TABLE src(id INTEGER PRIMARY KEY, t TEXT)"));
ASSERT_TRUE(db_.Execute("CREATE TABLE dst(id INTEGER PRIMARY KEY, t TEXT)"));
ASSERT_TRUE(db_.Execute("INSERT INTO src VALUES(2, 'two')"));
ASSERT_TRUE(db_.Execute("INSERT INTO src VALUES(3, 'three')"));
ASSERT_TRUE(db_.Execute("INSERT INTO src VALUES(4, 'four')"));
ASSERT_TRUE(db_.Execute("INSERT INTO src VALUES(5, 'five')"));
ASSERT_TRUE(db_.Execute("INSERT INTO src VALUES(6, 'six')"));
static const char kSelectSrcEvenSql[] = "SELECT id,t FROM src WHERE id%2=0";
sql::Statement select_src(
db_.GetCachedStatement(SQL_FROM_HERE, kSelectSrcEvenSql));
ASSERT_TRUE(select_src.Step());
ASSERT_EQ(select_src.ColumnInt(0), 2);
ASSERT_EQ(select_src.ColumnString(1), "two");
EXPECT_TRUE(db_.Execute("INSERT INTO dst VALUES(2, 'two')"));
ASSERT_TRUE(db_.Execute("INSERT INTO dst VALUES(3, 'three')"));
ASSERT_TRUE(select_src.Step());
ASSERT_EQ(select_src.ColumnInt(0), 4);
ASSERT_EQ(select_src.ColumnString(1), "four");
ASSERT_TRUE(db_.Execute("INSERT INTO dst VALUES(4, 'four')"));
ASSERT_TRUE(select_src.Step());
ASSERT_EQ(select_src.ColumnInt(0), 6);
ASSERT_EQ(select_src.ColumnString(1), "six");
ASSERT_TRUE(db_.Execute("INSERT INTO dst VALUES(5, 'five')"));
ASSERT_TRUE(db_.Execute("INSERT INTO dst VALUES(6, 'six')"));
EXPECT_FALSE(select_src.Step());
static const char kSelectDstSql[] = "SELECT id,t FROM dst";
sql::Statement select_dst(
db_.GetCachedStatement(SQL_FROM_HERE, kSelectDstSql));
std::vector<int> dst_ids;
std::vector<std::string> dst_texts;
while (select_dst.Step()) {
dst_ids.push_back(select_dst.ColumnInt(0));
dst_texts.push_back(select_dst.ColumnString(1));
}
std::vector<int> expected_dst_ids = {2, 3, 4, 5, 6};
EXPECT_EQ(expected_dst_ids, dst_ids);
std::vector<std::string> expected_dst_texts = {"two", "three", "four", "five",
"six"};
EXPECT_EQ(expected_dst_texts, dst_texts);
}
#if BUILDFLAG(IS_APPLE)
// If a database file is marked to be excluded from backups, verify that journal
// files are also excluded.
TEST_F(SQLiteFeaturesTest, TimeMachine) {
ASSERT_TRUE(db_.Execute("CREATE TABLE t (id INTEGER PRIMARY KEY)"));
db_.Close();
base::FilePath journal_path = sql::Database::JournalPath(db_path_);
ASSERT_TRUE(base::PathExists(db_path_));
ASSERT_TRUE(base::PathExists(journal_path));
// Not excluded to start.
EXPECT_FALSE(base::apple::GetBackupExclusion(db_path_));
EXPECT_FALSE(base::apple::GetBackupExclusion(journal_path));
// Exclude the main database file.
EXPECT_TRUE(base::apple::SetBackupExclusion(db_path_));
EXPECT_TRUE(base::apple::GetBackupExclusion(db_path_));
EXPECT_FALSE(base::apple::GetBackupExclusion(journal_path));
EXPECT_TRUE(db_.Open(db_path_));
ASSERT_TRUE(db_.Execute("INSERT INTO t VALUES (1)"));
EXPECT_TRUE(base::apple::GetBackupExclusion(db_path_));
EXPECT_TRUE(base::apple::GetBackupExclusion(journal_path));
// TODO(shess): In WAL mode this will touch -wal and -shm files. -shm files
// could be always excluded.
}
#endif
#if !BUILDFLAG(IS_FUCHSIA)
// SQLite WAL mode defaults to checkpointing the WAL on close. This would push
// additional work into Chromium shutdown. Verify that SQLite supports a config
// option to not checkpoint on close.
TEST_F(SQLiteFeaturesTest, WALNoClose) {
base::FilePath wal_path = sql::Database::WriteAheadLogPath(db_path_);
// Turn on WAL mode, then verify that the mode changed (WAL is supported).
ASSERT_TRUE(db_.Execute("PRAGMA journal_mode = WAL"));
ASSERT_EQ("wal", ExecuteWithResult(&db_, "PRAGMA journal_mode"));
// The WAL file is created lazily on first change.
ASSERT_TRUE(db_.Execute("CREATE TABLE foo (a, b)"));
// By default, the WAL is checkpointed then deleted on close.
ASSERT_TRUE(base::PathExists(wal_path));
db_.Close();
ASSERT_FALSE(base::PathExists(wal_path));
// Reopen and configure the database to not checkpoint WAL on close.
ASSERT_TRUE(Reopen());
ASSERT_TRUE(db_.Execute("PRAGMA journal_mode = WAL"));
ASSERT_TRUE(db_.Execute("ALTER TABLE foo ADD COLUMN c"));
ASSERT_EQ(
SQLITE_OK,
sqlite3_db_config(db_.db_, SQLITE_DBCONFIG_NO_CKPT_ON_CLOSE, 1, nullptr));
ASSERT_TRUE(base::PathExists(wal_path));
db_.Close();
ASSERT_TRUE(base::PathExists(wal_path));
}
#endif
} // namespace sql