[go: nahoru, domu]

Remove V8 use counter for matchAll with non-g RegExp

We've gathered sufficient data, so the use counter can now be removed
again.

The use counter was originally added here:

- V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/1718145
- Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/1718367

BUG=v8:9551

Change-Id: I7f8ab0cd19000e9259686d4166eb2bb484270fb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839851
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702795}
diff --git a/third_party/blink/public/mojom/web_feature/web_feature.mojom b/third_party/blink/public/mojom/web_feature/web_feature.mojom
index e118839..2c39e19 100644
--- a/third_party/blink/public/mojom/web_feature/web_feature.mojom
+++ b/third_party/blink/public/mojom/web_feature/web_feature.mojom
@@ -2360,7 +2360,6 @@
   kAutoplayDynamicDelegation = 2977,
   kToggleEventHandlerDuringParsing = 2978,
   kFragmentDoubleHash = 2979,
-  kV8RegExpMatchAllWithNonGlobalRegExp = 2980,
   kOBSOLETE_CSSValueOverflowXOverlay = 2981,
   kOBSOLETE_CSSValueOverflowYOverlay = 2982,
   kContentIndexAdd = 2983,
diff --git a/third_party/blink/renderer/bindings/core/v8/use_counter_callback.cc b/third_party/blink/renderer/bindings/core/v8/use_counter_callback.cc
index a381af0..46acbdc2 100644
--- a/third_party/blink/renderer/bindings/core/v8/use_counter_callback.cc
+++ b/third_party/blink/renderer/bindings/core/v8/use_counter_callback.cc
@@ -234,9 +234,6 @@
     case v8::Isolate::kCallSiteAPIGetThisSloppyCall:
       blink_feature = WebFeature::kV8CallSiteAPIGetThisSloppyCall;
       break;
-    case v8::Isolate::kRegExpMatchAllWithNonGlobalRegExp:
-      blink_feature = WebFeature::kV8RegExpMatchAllWithNonGlobalRegExp;
-      break;
     default:
       // This can happen if V8 has added counters that this version of Blink
       // does not know about. It's harmless.
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index cc7aa3b..2a4648e3 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -24783,7 +24783,7 @@
   <int value="2977" label="AutoplayDynamicDelegation"/>
   <int value="2978" label="ToggleEventHandlerDuringParsing"/>
   <int value="2979" label="FragmentDoubleHash"/>
-  <int value="2980" label="V8RegExpMatchAllWithNonGlobalRegExp"/>
+  <int value="2980" label="V8RegExpMatchAllWithNonGlobalRegExp (obsolete)"/>
   <int value="2981" label="OBSOLETE_CSSValueOverflowXOverlay"/>
   <int value="2982" label="OBSOLETE_CSSValueOverflowYOverlay"/>
   <int value="2983" label="ContentIndexAdd"/>