| // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| |
| // Disable everything on windows only. http://crbug.com/306144 |
| #include "chrome/browser/extensions/api/downloads/downloads_api.h" |
| |
| #include <stddef.h> |
| #include <stdint.h> |
| |
| #include <algorithm> |
| #include <memory> |
| |
| #include "base/bind.h" |
| #include "base/callback_helpers.h" |
| #include "base/containers/circular_deque.h" |
| #include "base/files/file_util.h" |
| #include "base/guid.h" |
| #include "base/json/json_reader.h" |
| #include "base/memory/ptr_util.h" |
| #include "base/memory/raw_ptr.h" |
| #include "base/run_loop.h" |
| #include "base/scoped_observation.h" |
| #include "base/strings/stringprintf.h" |
| #include "base/test/bind.h" |
| #include "base/test/scoped_feature_list.h" |
| #include "base/threading/thread_restrictions.h" |
| #include "base/threading/thread_task_runner_handle.h" |
| #include "base/time/time.h" |
| #include "build/build_config.h" |
| #include "chrome/browser/download/download_core_service.h" |
| #include "chrome/browser/download/download_core_service_factory.h" |
| #include "chrome/browser/download/download_file_icon_extractor.h" |
| #include "chrome/browser/download/download_open_prompt.h" |
| #include "chrome/browser/download/download_prefs.h" |
| #include "chrome/browser/download/download_test_file_activity_observer.h" |
| #include "chrome/browser/extensions/api/downloads_internal/downloads_internal_api.h" |
| #include "chrome/browser/extensions/extension_apitest.h" |
| #include "chrome/browser/extensions/extension_function_test_utils.h" |
| #include "chrome/browser/platform_util_internal.h" |
| #include "chrome/browser/profiles/profile.h" |
| #include "chrome/browser/ui/browser.h" |
| #include "chrome/browser/ui/browser_tabstrip.h" |
| #include "chrome/browser/ui/extensions/extension_action_test_helper.h" |
| #include "chrome/common/extensions/api/downloads.h" |
| #include "chrome/common/pref_names.h" |
| #include "chrome/test/base/in_process_browser_test.h" |
| #include "chrome/test/base/ui_test_utils.h" |
| #include "components/download/public/common/download_item.h" |
| #include "components/prefs/pref_service.h" |
| #include "content/public/browser/browser_context.h" |
| #include "content/public/browser/browser_task_traits.h" |
| #include "content/public/browser/browser_thread.h" |
| #include "content/public/browser/download_manager.h" |
| #include "content/public/browser/render_frame_host.h" |
| #include "content/public/browser/render_process_host.h" |
| #include "content/public/browser/storage_partition.h" |
| #include "content/public/browser/storage_partition_config.h" |
| #include "content/public/browser/web_contents.h" |
| #include "content/public/test/browser_test.h" |
| #include "content/public/test/browser_test_utils.h" |
| #include "content/public/test/download_test_observer.h" |
| #include "content/public/test/slow_download_http_response.h" |
| #include "content/public/test/test_download_http_response.h" |
| #include "content/public/test/test_navigation_observer.h" |
| #include "content/public/test/test_utils.h" |
| #include "extensions/browser/event_router.h" |
| #include "extensions/common/manifest_handlers/incognito_info.h" |
| #include "net/base/data_url.h" |
| #include "net/dns/mock_host_resolver.h" |
| #include "net/test/embedded_test_server/controllable_http_response.h" |
| #include "net/test/embedded_test_server/embedded_test_server.h" |
| #include "net/test/embedded_test_server/http_response.h" |
| #include "services/network/public/cpp/features.h" |
| #include "storage/browser/file_system/file_system_context.h" |
| #include "storage/browser/file_system/file_system_operation_runner.h" |
| #include "storage/browser/file_system/file_system_url.h" |
| #include "third_party/abseil-cpp/absl/types/optional.h" |
| #include "ui/base/page_transition_types.h" |
| #include "url/origin.h" |
| |
| using content::BrowserContext; |
| using content::BrowserThread; |
| using content::DownloadManager; |
| using download::DownloadItem; |
| |
| namespace errors = download_extension_errors; |
| |
| namespace extensions { |
| namespace downloads = api::downloads; |
| |
| namespace { |
| |
| const char kFirstDownloadUrl[] = "/download1"; |
| const char kSecondDownloadUrl[] = "/download2"; |
| const int kDownloadSize = 1024 * 10; |
| |
| void OnFileDeleted(bool success) {} |
| |
| // Comparator that orders download items by their ID. Can be used with |
| // std::sort. |
| struct DownloadIdComparator { |
| bool operator() (DownloadItem* first, DownloadItem* second) { |
| return first->GetId() < second->GetId(); |
| } |
| }; |
| |
| bool IsDownloadExternallyRemoved(download::DownloadItem* item) { |
| return item->GetFileExternallyRemoved(); |
| } |
| |
| void OnOpenPromptCreated(download::DownloadItem* item, |
| DownloadOpenPrompt* prompt) { |
| EXPECT_FALSE(item->GetOpened()); |
| // Posts a task to accept the DownloadOpenPrompt. |
| content::GetUIThreadTaskRunner({})->PostTask( |
| FROM_HERE, |
| base::BindOnce(&DownloadOpenPrompt::AcceptConfirmationDialogForTesting, |
| base::Unretained(prompt))); |
| } |
| |
| class DownloadsEventsListener : public EventRouter::TestObserver { |
| public: |
| explicit DownloadsEventsListener(Profile* profile) |
| : waiting_(false), profile_(profile) {} |
| |
| DownloadsEventsListener(const DownloadsEventsListener&) = delete; |
| DownloadsEventsListener& operator=(const DownloadsEventsListener&) = delete; |
| |
| ~DownloadsEventsListener() override = default; |
| |
| void ClearEvents() { events_.clear(); } |
| |
| class Event { |
| public: |
| Event(Profile* profile, |
| const std::string& event_name, |
| const base::Value& args, |
| base::Time caught) |
| : profile_(profile), |
| event_name_(event_name), |
| args_(args.Clone()), |
| caught_(caught) {} |
| |
| Event(const Event&) = delete; |
| Event& operator=(const Event&) = delete; |
| |
| const base::Time& caught() { return caught_; } |
| |
| bool Satisfies(const Event& other) const { |
| return other.SatisfiedBy(*this); |
| } |
| |
| bool SatisfiedBy(const Event& other) const { |
| // Only match profile iff restrict_to_browser_context is non-null when |
| // the event is dispatched from |
| // ExtensionDownloadsEventRouter::DispatchEvent. Event names always have |
| // to match. |
| if ((profile_ && other.profile_ && profile_ != other.profile_) || |
| (event_name_ != other.event_name_)) |
| return false; |
| |
| if (((event_name_ == downloads::OnDeterminingFilename::kEventName) || |
| (event_name_ == downloads::OnCreated::kEventName) || |
| (event_name_ == downloads::OnChanged::kEventName))) { |
| // We expect a non-empty list for these events. |
| if (!args_.is_list() || !other.args_.is_list() || |
| args_.GetListDeprecated().empty() || |
| other.args_.GetListDeprecated().empty()) |
| return false; |
| const base::Value& left_dict = args_.GetListDeprecated()[0]; |
| const base::Value& right_dict = other.args_.GetListDeprecated()[0]; |
| if (!left_dict.is_dict() || !right_dict.is_dict()) |
| return false; |
| // Expect that all keys present in both dictionaries are equal. If a key |
| // is only present in one of the dictionaries, ignore it. This allows us |
| // to verify the properties we care about in the test without needing to |
| // specify each. |
| for (auto it : left_dict.DictItems()) { |
| const base::Value* right_value = right_dict.FindKey(it.first); |
| if (!right_value || *right_value != it.second) |
| return false; |
| } |
| return true; |
| } |
| return args_ == other.args_; |
| } |
| |
| std::string Debug() { |
| return base::StringPrintf("Event(%p, %s, %f)", profile_.get(), |
| event_name_.c_str(), caught_.ToJsTime()); |
| } |
| |
| private: |
| raw_ptr<Profile> profile_; |
| std::string event_name_; |
| std::string json_args_; |
| base::Value args_; |
| base::Time caught_; |
| }; |
| |
| // extensions::EventRouter::TestObserver: |
| void OnWillDispatchEvent(const extensions::Event& event) override { |
| // TestObserver receives notifications for all events but only needs to |
| // check download events. |
| if (!base::StartsWith(event.event_name, "downloads")) |
| return; |
| |
| Event* new_event = new Event( |
| Profile::FromBrowserContext(event.restrict_to_browser_context), |
| event.event_name, *event.event_args.get(), base::Time::Now()); |
| events_.push_back(base::WrapUnique(new_event)); |
| if (waiting_ && waiting_for_.get() && new_event->Satisfies(*waiting_for_)) { |
| waiting_ = false; |
| base::RunLoop::QuitCurrentWhenIdleDeprecated(); |
| } |
| } |
| |
| // extensions::EventRouter::TestObserver: |
| void OnDidDispatchEventToProcess(const extensions::Event& event) override {} |
| |
| bool WaitFor(Profile* profile, |
| const std::string& event_name, |
| const std::string& json_args) { |
| base::Value args = base::JSONReader::Read(json_args).value(); |
| waiting_for_ = |
| std::make_unique<Event>(profile, event_name, args, base::Time()); |
| for (const auto& event : events_) { |
| if (event->Satisfies(*waiting_for_)) |
| return true; |
| } |
| waiting_ = true; |
| content::RunMessageLoop(); |
| bool success = !waiting_; |
| if (waiting_) { |
| // Print the events that were caught since the last WaitFor() call to help |
| // find the erroneous event. |
| // TODO(benjhayden) Fuzzy-match and highlight the erroneous event. |
| for (const auto& event : events_) { |
| if (event->caught() > last_wait_) { |
| LOG(INFO) << "Caught " << event->Debug(); |
| } |
| } |
| if (waiting_for_.get()) { |
| LOG(INFO) << "Timed out waiting for " << waiting_for_->Debug(); |
| } |
| waiting_ = false; |
| } |
| waiting_for_.reset(); |
| last_wait_ = base::Time::Now(); |
| return success; |
| } |
| |
| void UpdateProfile(Profile* profile) { profile_ = profile; } |
| |
| base::circular_deque<std::unique_ptr<Event>>* events() { return &events_; } |
| |
| private: |
| bool waiting_; |
| base::Time last_wait_; |
| std::unique_ptr<Event> waiting_for_; |
| base::circular_deque<std::unique_ptr<Event>> events_; |
| raw_ptr<Profile> profile_; |
| }; |
| |
| // Object waiting for a download open event. |
| class DownloadOpenObserver : public download::DownloadItem::Observer { |
| public: |
| explicit DownloadOpenObserver(download::DownloadItem* item) : item_(item) { |
| open_observation_.Observe(item); |
| } |
| |
| DownloadOpenObserver(const DownloadOpenObserver&) = delete; |
| DownloadOpenObserver& operator=(const DownloadOpenObserver&) = delete; |
| |
| ~DownloadOpenObserver() override = default; |
| |
| void WaitForEvent() { |
| if (item_ && !item_->GetOpened()) { |
| base::RunLoop run_loop; |
| completion_closure_ = run_loop.QuitClosure(); |
| run_loop.Run(); |
| } |
| } |
| |
| private: |
| // download::DownloadItem::Observer |
| void OnDownloadOpened(download::DownloadItem* item) override { |
| if (!completion_closure_.is_null()) |
| std::move(completion_closure_).Run(); |
| } |
| |
| void OnDownloadDestroyed(download::DownloadItem* item) override { |
| DCHECK(open_observation_.IsObservingSource(item)); |
| open_observation_.Reset(); |
| item_ = nullptr; |
| } |
| |
| base::ScopedObservation<download::DownloadItem, |
| download::DownloadItem::Observer> |
| open_observation_{this}; |
| raw_ptr<download::DownloadItem> item_; |
| base::OnceClosure completion_closure_; |
| }; |
| |
| } // namespace |
| |
| class DownloadExtensionTest : public ExtensionApiTest { |
| public: |
| DownloadExtensionTest() |
| : extension_(nullptr), |
| incognito_browser_(nullptr), |
| current_browser_(nullptr) {} |
| |
| DownloadExtensionTest(const DownloadExtensionTest&) = delete; |
| DownloadExtensionTest& operator=(const DownloadExtensionTest&) = delete; |
| |
| protected: |
| // Used with CreateHistoryDownloads |
| struct HistoryDownloadInfo { |
| // Filename to use. CreateHistoryDownloads will append this filename to the |
| // temporary downloads directory specified by downloads_directory(). |
| const base::FilePath::CharType* filename; |
| |
| // State for the download. Note that IN_PROGRESS downloads will be created |
| // as CANCELLED. |
| DownloadItem::DownloadState state; |
| |
| // Danger type for the download. Only use DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS |
| // and DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT. |
| download::DownloadDangerType danger_type; |
| }; |
| |
| void LoadExtension(const char* name, bool enable_file_access = false) { |
| // Store the created Extension object so that we can attach it to |
| // ExtensionFunctions. Also load the extension in incognito profiles for |
| // testing incognito. |
| extension_ = ExtensionBrowserTest::LoadExtension( |
| test_data_dir_.AppendASCII(name), |
| {.allow_in_incognito = true, .allow_file_access = enable_file_access}); |
| CHECK(extension_); |
| content::WebContents* tab = chrome::AddSelectedTabWithURL( |
| current_browser(), |
| extension_->GetResourceURL("empty.html"), |
| ui::PAGE_TRANSITION_LINK); |
| EXPECT_TRUE(content::WaitForLoadStop(tab)); |
| EventRouter::Get(current_browser()->profile()) |
| ->AddEventListener(downloads::OnCreated::kEventName, |
| tab->GetMainFrame()->GetProcess(), GetExtensionId()); |
| EventRouter::Get(current_browser()->profile()) |
| ->AddEventListener(downloads::OnChanged::kEventName, |
| tab->GetMainFrame()->GetProcess(), GetExtensionId()); |
| EventRouter::Get(current_browser()->profile()) |
| ->AddEventListener(downloads::OnErased::kEventName, |
| tab->GetMainFrame()->GetProcess(), GetExtensionId()); |
| } |
| |
| content::RenderProcessHost* AddFilenameDeterminer() { |
| ExtensionDownloadsEventRouter::SetDetermineFilenameTimeoutSecondsForTesting( |
| 2); |
| content::WebContents* tab = chrome::AddSelectedTabWithURL( |
| current_browser(), |
| extension_->GetResourceURL("empty.html"), |
| ui::PAGE_TRANSITION_LINK); |
| EventRouter::Get(current_browser()->profile()) |
| ->AddEventListener(downloads::OnDeterminingFilename::kEventName, |
| tab->GetMainFrame()->GetProcess(), GetExtensionId()); |
| return tab->GetMainFrame()->GetProcess(); |
| } |
| |
| void RemoveFilenameDeterminer(content::RenderProcessHost* host) { |
| EventRouter::Get(current_browser()->profile())->RemoveEventListener( |
| downloads::OnDeterminingFilename::kEventName, host, GetExtensionId()); |
| } |
| |
| Browser* current_browser() { return current_browser_; } |
| |
| // InProcessBrowserTest |
| void SetUpOnMainThread() override { |
| ExtensionApiTest::SetUpOnMainThread(); |
| GoOnTheRecord(); |
| current_browser()->profile()->GetPrefs()->SetBoolean( |
| prefs::kPromptForDownload, false); |
| // Create event listener using current profile. |
| events_listener_ = |
| std::make_unique<DownloadsEventsListener>(current_browser()->profile()); |
| extensions::EventRouter::Get(current_browser()->profile()) |
| ->AddObserverForTesting(events_listener()); |
| // Disable file chooser for current profile. |
| DownloadTestFileActivityObserver observer(current_browser()->profile()); |
| observer.EnableFileChooser(false); |
| |
| first_download_ = |
| std::make_unique<net::test_server::ControllableHttpResponse>( |
| embedded_test_server(), kFirstDownloadUrl); |
| second_download_ = |
| std::make_unique<net::test_server::ControllableHttpResponse>( |
| embedded_test_server(), kSecondDownloadUrl); |
| |
| host_resolver()->AddRule("*", "127.0.0.1"); |
| } |
| |
| // InProcessBrowserTest |
| void TearDownOnMainThread() override { |
| EventRouter::Get(current_browser()->profile()) |
| ->RemoveObserverForTesting(events_listener_.get()); |
| ExtensionApiTest::TearDownOnMainThread(); |
| } |
| |
| void GoOnTheRecord() { |
| current_browser_ = browser(); |
| if (events_listener_.get()) |
| events_listener_->UpdateProfile(current_browser()->profile()); |
| } |
| |
| void GoOffTheRecord() { |
| if (!incognito_browser_) { |
| incognito_browser_ = CreateIncognitoBrowser(); |
| // Disable file chooser for incognito profile. |
| DownloadTestFileActivityObserver observer(incognito_browser_->profile()); |
| observer.EnableFileChooser(false); |
| } |
| current_browser_ = incognito_browser_; |
| if (events_listener_.get()) |
| events_listener_->UpdateProfile(current_browser()->profile()); |
| } |
| |
| bool WaitFor(const std::string& event_name, const std::string& json_args) { |
| return events_listener_->WaitFor( |
| current_browser()->profile(), event_name, json_args); |
| } |
| |
| bool WaitForInterruption(DownloadItem* item, |
| download::DownloadInterruptReason expected_error, |
| const std::string& on_created_event) { |
| if (!WaitFor(downloads::OnCreated::kEventName, on_created_event)) |
| return false; |
| // Now, onCreated is always fired before interruption. |
| return WaitFor( |
| downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"error\": {\"current\": \"%s\"}," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"interrupted\"}}]", |
| item->GetId(), |
| download::DownloadInterruptReasonToString(expected_error).c_str())); |
| } |
| |
| void ClearEvents() { |
| events_listener_->ClearEvents(); |
| } |
| |
| std::string GetExtensionURL() { |
| return extension_->url().spec(); |
| } |
| content::StoragePartitionConfig GetExtensionStoragePartitionConfig() { |
| return browser() |
| ->profile() |
| ->GetDownloadManager() |
| ->GetStoragePartitionConfigForSiteUrl(extension_->url()); |
| } |
| std::string GetExtensionId() { |
| return extension_->id(); |
| } |
| |
| std::string GetFilename(const char* path) { |
| std::string result = downloads_directory().AppendASCII(path).AsUTF8Unsafe(); |
| #if BUILDFLAG(IS_WIN) |
| for (std::string::size_type next = result.find("\\"); |
| next != std::string::npos; |
| next = result.find("\\", next)) { |
| result.replace(next, 1, "\\\\"); |
| next += 2; |
| } |
| #endif |
| return result; |
| } |
| |
| DownloadManager* GetOnRecordManager() { |
| return browser()->profile()->GetDownloadManager(); |
| } |
| DownloadManager* GetOffRecordManager() { |
| return browser() |
| ->profile() |
| ->GetPrimaryOTRProfile(/*create_if_needed=*/true) |
| ->GetDownloadManager(); |
| } |
| DownloadManager* GetCurrentManager() { |
| return (current_browser_ == incognito_browser_) ? |
| GetOffRecordManager() : GetOnRecordManager(); |
| } |
| |
| // Creates a set of history downloads based on the provided |history_info| |
| // array. |count| is the number of elements in |history_info|. On success, |
| // |items| will contain |count| DownloadItems in the order that they were |
| // specified in |history_info|. Returns true on success and false otherwise. |
| bool CreateHistoryDownloads(const HistoryDownloadInfo* history_info, |
| size_t count, |
| DownloadManager::DownloadVector* items) { |
| DownloadIdComparator download_id_comparator; |
| base::Time current = base::Time::Now(); |
| items->clear(); |
| GetOnRecordManager()->GetAllDownloads(items); |
| CHECK_EQ(0, static_cast<int>(items->size())); |
| std::vector<GURL> url_chain; |
| url_chain.push_back(GURL()); |
| for (size_t i = 0; i < count; ++i) { |
| DownloadItem* item = GetOnRecordManager()->CreateDownloadItem( |
| base::GenerateGUID(), download::DownloadItem::kInvalidId + 1 + i, |
| downloads_directory().Append(history_info[i].filename), |
| downloads_directory().Append(history_info[i].filename), url_chain, |
| GURL(), |
| content::StoragePartitionConfig::CreateDefault(browser()->profile()), |
| GURL(), GURL(), url::Origin(), std::string(), |
| std::string(), // mime_type, original_mime_type |
| current, |
| current, // start_time, end_time |
| std::string(), |
| std::string(), // etag, last_modified |
| 1, |
| 1, // received_bytes, total_bytes |
| std::string(), // hash |
| history_info[i].state, // state |
| history_info[i].danger_type, |
| (history_info[i].state != download::DownloadItem::CANCELLED |
| ? download::DOWNLOAD_INTERRUPT_REASON_NONE |
| : download::DOWNLOAD_INTERRUPT_REASON_USER_CANCELED), |
| false, // opened |
| current, // last_access_time |
| false, std::vector<DownloadItem::ReceivedSlice>(), |
| download::DownloadItemRerouteInfo()); |
| items->push_back(item); |
| } |
| |
| // Order by ID so that they are in the order that we created them. |
| std::sort(items->begin(), items->end(), download_id_comparator); |
| return true; |
| } |
| |
| void CreateTwoDownloads(DownloadManager::DownloadVector* items) { |
| CreateFirstSlowTestDownload(); |
| CreateSecondSlowTestDownload(); |
| |
| GetCurrentManager()->GetAllDownloads(items); |
| ASSERT_EQ(2u, items->size()); |
| } |
| |
| DownloadItem* CreateFirstSlowTestDownload() { |
| DownloadManager* manager = GetCurrentManager(); |
| |
| EXPECT_EQ(0, manager->NonMaliciousInProgressCount()); |
| EXPECT_EQ(0, manager->InProgressCount()); |
| if (manager->InProgressCount() != 0) |
| return NULL; |
| return CreateSlowTestDownload(first_download_.get(), kFirstDownloadUrl); |
| } |
| |
| DownloadItem* CreateSecondSlowTestDownload() { |
| return CreateSlowTestDownload(second_download_.get(), kSecondDownloadUrl); |
| } |
| |
| DownloadItem* CreateSlowTestDownload( |
| net::test_server::ControllableHttpResponse* response, |
| const std::string& path) { |
| if (!embedded_test_server()->Started()) |
| StartEmbeddedTestServer(); |
| std::unique_ptr<content::DownloadTestObserver> observer( |
| CreateInProgressDownloadObserver(1)); |
| DownloadManager* manager = GetCurrentManager(); |
| |
| const GURL url = embedded_test_server()->GetURL(path); |
| ui_test_utils::NavigateToURLWithDisposition( |
| current_browser(), url, WindowOpenDisposition::CURRENT_TAB, |
| ui_test_utils::BROWSER_TEST_NONE); |
| |
| response->WaitForRequest(); |
| response->Send( |
| "HTTP/1.1 200 OK\r\n" |
| "Content-type: application/octet-stream\r\n" |
| "Cache-Control: max-age=0\r\n" |
| "\r\n"); |
| response->Send(std::string(kDownloadSize, '*')); |
| |
| observer->WaitForFinished(); |
| EXPECT_EQ(1u, observer->NumDownloadsSeenInState(DownloadItem::IN_PROGRESS)); |
| |
| DownloadManager::DownloadVector items; |
| manager->GetAllDownloads(&items); |
| EXPECT_TRUE(!items.empty()); |
| return items.back(); |
| } |
| |
| void FinishFirstSlowDownloads() { |
| FinishSlowDownloads(first_download_.get()); |
| } |
| |
| void FinishSecondSlowDownloads() { |
| FinishSlowDownloads(second_download_.get()); |
| } |
| |
| void FinishSlowDownloads( |
| net::test_server::ControllableHttpResponse* response) { |
| std::unique_ptr<content::DownloadTestObserver> observer( |
| CreateDownloadObserver(1)); |
| response->Done(); |
| observer->WaitForFinished(); |
| EXPECT_EQ(1u, observer->NumDownloadsSeenInState(DownloadItem::COMPLETE)); |
| } |
| |
| content::DownloadTestObserver* CreateDownloadObserver(size_t download_count) { |
| return new content::DownloadTestObserverTerminal( |
| GetCurrentManager(), download_count, |
| content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL); |
| } |
| |
| content::DownloadTestObserver* CreateInProgressDownloadObserver( |
| size_t download_count) { |
| return new content::DownloadTestObserverInProgress( |
| GetCurrentManager(), download_count); |
| } |
| |
| bool RunFunction(ExtensionFunction* function, const std::string& args) { |
| scoped_refptr<ExtensionFunction> delete_function(function); |
| SetUpExtensionFunction(function); |
| bool result = extension_function_test_utils::RunFunction( |
| function, args, current_browser(), GetFlags()); |
| if (!result) { |
| LOG(ERROR) << function->GetError(); |
| } |
| return result; |
| } |
| |
| api_test_utils::RunFunctionFlags GetFlags() { |
| return current_browser()->profile()->IsOffTheRecord() |
| ? api_test_utils::INCLUDE_INCOGNITO |
| : api_test_utils::NONE; |
| } |
| |
| // extension_function_test_utils::RunFunction*() only uses browser for its |
| // profile(), so pass it the on-record browser so that it always uses the |
| // on-record profile to match real-life behavior. |
| |
| std::unique_ptr<base::Value> RunFunctionAndReturnResult( |
| scoped_refptr<ExtensionFunction> function, |
| const std::string& args) { |
| SetUpExtensionFunction(function.get()); |
| return extension_function_test_utils::RunFunctionAndReturnSingleResult( |
| function.get(), args, current_browser(), GetFlags()); |
| } |
| |
| std::string RunFunctionAndReturnError( |
| scoped_refptr<ExtensionFunction> function, |
| const std::string& args) { |
| SetUpExtensionFunction(function.get()); |
| return extension_function_test_utils::RunFunctionAndReturnError( |
| function.get(), args, current_browser(), GetFlags()); |
| } |
| |
| bool RunFunctionAndReturnString(scoped_refptr<ExtensionFunction> function, |
| const std::string& args, |
| std::string* result_string) { |
| SetUpExtensionFunction(function.get()); |
| std::unique_ptr<base::Value> result( |
| RunFunctionAndReturnResult(function, args)); |
| EXPECT_TRUE(result.get()); |
| if (result.get() && result->is_string()) { |
| *result_string = result->GetString(); |
| return true; |
| } |
| return false; |
| } |
| |
| std::string DownloadItemIdAsArgList(const DownloadItem* download_item) { |
| return base::StringPrintf("[%d]", download_item->GetId()); |
| } |
| |
| base::FilePath downloads_directory() { |
| return DownloadPrefs(current_browser()->profile()).DownloadPath(); |
| } |
| |
| DownloadsEventsListener* events_listener() { return events_listener_.get(); } |
| |
| const Extension* extension() { return extension_; } |
| |
| private: |
| void SetUpExtensionFunction(ExtensionFunction* function) { |
| if (extension_) { |
| const GURL url = current_browser_ == incognito_browser_ && |
| !IncognitoInfo::IsSplitMode(extension_) |
| ? GURL(url::kAboutBlankURL) |
| : extension_->GetResourceURL("empty.html"); |
| // Watch and wait for the navigation to take place. |
| auto observer = std::make_unique<content::TestNavigationObserver>(url); |
| observer->WatchExistingWebContents(); |
| observer->StartWatchingNewWebContents(); |
| // Recreate the tab each time for insulation. |
| content::WebContents* tab = chrome::AddSelectedTabWithURL( |
| current_browser(), url, ui::PAGE_TRANSITION_LINK); |
| observer->WaitForNavigationFinished(); |
| function->set_extension(extension_.get()); |
| function->SetRenderFrameHost(tab->GetMainFrame()); |
| function->set_source_process_id( |
| tab->GetMainFrame()->GetProcess()->GetID()); |
| } |
| } |
| |
| raw_ptr<const Extension> extension_; |
| raw_ptr<Browser> incognito_browser_; |
| raw_ptr<Browser> current_browser_; |
| std::unique_ptr<DownloadsEventsListener> events_listener_; |
| |
| std::unique_ptr<net::test_server::ControllableHttpResponse> first_download_; |
| std::unique_ptr<net::test_server::ControllableHttpResponse> second_download_; |
| }; |
| |
| namespace { |
| |
| class MockIconExtractorImpl : public DownloadFileIconExtractor { |
| public: |
| MockIconExtractorImpl(const base::FilePath& path, |
| IconLoader::IconSize icon_size, |
| const std::string& response) |
| : expected_path_(path), |
| expected_icon_size_(icon_size), |
| response_(response) { |
| } |
| ~MockIconExtractorImpl() override {} |
| |
| bool ExtractIconURLForPath(const base::FilePath& path, |
| float scale, |
| IconLoader::IconSize icon_size, |
| IconURLCallback callback) override { |
| EXPECT_STREQ(expected_path_.value().c_str(), path.value().c_str()); |
| EXPECT_EQ(expected_icon_size_, icon_size); |
| if (expected_path_ == path && |
| expected_icon_size_ == icon_size) { |
| callback_ = std::move(callback); |
| content::GetUIThreadTaskRunner({})->PostTask( |
| FROM_HERE, base::BindOnce(&MockIconExtractorImpl::RunCallback, |
| base::Unretained(this))); |
| return true; |
| } else { |
| return false; |
| } |
| } |
| |
| private: |
| void RunCallback() { |
| DCHECK(callback_); |
| std::move(callback_).Run(response_); |
| // Drop the reference on extension function to avoid memory leaks. |
| callback_ = IconURLCallback(); |
| } |
| |
| base::FilePath expected_path_; |
| IconLoader::IconSize expected_icon_size_; |
| std::string response_; |
| IconURLCallback callback_; |
| }; |
| |
| bool ItemNotInProgress(DownloadItem* item) { |
| return item->GetState() != DownloadItem::IN_PROGRESS; |
| } |
| |
| // Cancels the underlying DownloadItem when the ScopedCancellingItem goes out of |
| // scope. Like a scoped_ptr, but for DownloadItems. |
| class ScopedCancellingItem { |
| public: |
| explicit ScopedCancellingItem(DownloadItem* item) : item_(item) {} |
| |
| ScopedCancellingItem(const ScopedCancellingItem&) = delete; |
| ScopedCancellingItem& operator=(const ScopedCancellingItem&) = delete; |
| |
| ~ScopedCancellingItem() { |
| item_->Cancel(true); |
| content::DownloadUpdatedObserver observer( |
| item_, base::BindRepeating(&ItemNotInProgress)); |
| observer.WaitForEvent(); |
| } |
| DownloadItem* get() { return item_; } |
| private: |
| raw_ptr<DownloadItem> item_; |
| }; |
| |
| // Cancels all the underlying DownloadItems when the ScopedItemVectorCanceller |
| // goes out of scope. Generalization of ScopedCancellingItem to many |
| // DownloadItems. |
| class ScopedItemVectorCanceller { |
| public: |
| explicit ScopedItemVectorCanceller(DownloadManager::DownloadVector* items) |
| : items_(items) { |
| } |
| |
| ScopedItemVectorCanceller(const ScopedItemVectorCanceller&) = delete; |
| ScopedItemVectorCanceller& operator=(const ScopedItemVectorCanceller&) = |
| delete; |
| |
| ~ScopedItemVectorCanceller() { |
| for (DownloadManager::DownloadVector::const_iterator item = items_->begin(); |
| item != items_->end(); ++item) { |
| if ((*item)->GetState() == DownloadItem::IN_PROGRESS) |
| (*item)->Cancel(true); |
| content::DownloadUpdatedObserver observer( |
| (*item), base::BindRepeating(&ItemNotInProgress)); |
| observer.WaitForEvent(); |
| } |
| } |
| |
| private: |
| raw_ptr<DownloadManager::DownloadVector> items_; |
| }; |
| |
| // Writes an HTML5 file so that it can be downloaded. |
| class HTML5FileWriter { |
| public: |
| static bool CreateFileForTesting(storage::FileSystemContext* context, |
| const storage::FileSystemURL& path, |
| const char* data, |
| int length) { |
| base::ScopedAllowBlockingForTesting allow_blocking; |
| // Create a temp file. |
| base::FilePath temp_file; |
| if (!base::CreateTemporaryFile(&temp_file) || |
| base::WriteFile(temp_file, data, length) != length) { |
| return false; |
| } |
| // Invoke the fileapi to copy it into the sandboxed filesystem. |
| bool result = false; |
| base::RunLoop run_loop; |
| content::GetIOThreadTaskRunner({})->PostTask( |
| FROM_HERE, |
| base::BindOnce(&CreateFileForTestingOnIOThread, |
| base::Unretained(context), path, temp_file, |
| base::Unretained(&result), run_loop.QuitClosure())); |
| // Wait for that to finish. |
| run_loop.Run(); |
| base::DeleteFile(temp_file); |
| return result; |
| } |
| |
| private: |
| static void CopyInCompletion(bool* result, |
| base::OnceClosure quit_closure, |
| base::File::Error error) { |
| DCHECK_CURRENTLY_ON(BrowserThread::IO); |
| *result = error == base::File::FILE_OK; |
| content::GetUIThreadTaskRunner({})->PostTask(FROM_HERE, |
| std::move(quit_closure)); |
| } |
| |
| static void CreateFileForTestingOnIOThread( |
| storage::FileSystemContext* context, |
| const storage::FileSystemURL& path, |
| const base::FilePath& temp_file, |
| bool* result, |
| base::OnceClosure quit_closure) { |
| DCHECK_CURRENTLY_ON(BrowserThread::IO); |
| context->operation_runner()->CopyInForeignFile( |
| temp_file, path, |
| base::BindOnce(&CopyInCompletion, base::Unretained(result), |
| std::move(quit_closure))); |
| } |
| }; |
| |
| // TODO(benjhayden) Merge this with the other TestObservers. |
| class JustInProgressDownloadObserver |
| : public content::DownloadTestObserverInProgress { |
| public: |
| JustInProgressDownloadObserver( |
| DownloadManager* download_manager, size_t wait_count) |
| : content::DownloadTestObserverInProgress(download_manager, wait_count) { |
| } |
| |
| JustInProgressDownloadObserver(const JustInProgressDownloadObserver&) = |
| delete; |
| JustInProgressDownloadObserver& operator=( |
| const JustInProgressDownloadObserver&) = delete; |
| |
| ~JustInProgressDownloadObserver() override {} |
| |
| private: |
| bool IsDownloadInFinalState(DownloadItem* item) override { |
| return item->GetState() == DownloadItem::IN_PROGRESS; |
| } |
| }; |
| |
| bool ItemIsInterrupted(DownloadItem* item) { |
| return item->GetState() == DownloadItem::INTERRUPTED; |
| } |
| |
| download::DownloadInterruptReason InterruptReasonExtensionToComponent( |
| downloads::InterruptReason error) { |
| switch (error) { |
| case downloads::INTERRUPT_REASON_NONE: |
| return download::DOWNLOAD_INTERRUPT_REASON_NONE; |
| #define INTERRUPT_REASON(name, value) \ |
| case downloads::INTERRUPT_REASON_##name: \ |
| return download::DOWNLOAD_INTERRUPT_REASON_##name; |
| #include "components/download/public/common/download_interrupt_reason_values.h" |
| #undef INTERRUPT_REASON |
| } |
| NOTREACHED(); |
| return download::DOWNLOAD_INTERRUPT_REASON_NONE; |
| } |
| |
| downloads::InterruptReason InterruptReasonContentToExtension( |
| download::DownloadInterruptReason error) { |
| switch (error) { |
| case download::DOWNLOAD_INTERRUPT_REASON_NONE: |
| return downloads::INTERRUPT_REASON_NONE; |
| #define INTERRUPT_REASON(name, value) \ |
| case download::DOWNLOAD_INTERRUPT_REASON_##name: \ |
| return downloads::INTERRUPT_REASON_##name; |
| #include "components/download/public/common/download_interrupt_reason_values.h" |
| #undef INTERRUPT_REASON |
| } |
| NOTREACHED(); |
| return downloads::INTERRUPT_REASON_NONE; |
| } |
| |
| } // namespace |
| |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, DownloadExtensionTest_Open) { |
| platform_util::internal::DisableShellOperationsForTesting(); |
| |
| LoadExtension("downloads_split"); |
| DownloadsOpenFunction* open_function = new DownloadsOpenFunction(); |
| open_function->set_user_gesture(true); |
| EXPECT_STREQ(errors::kInvalidId, |
| RunFunctionAndReturnError( |
| open_function, |
| "[-42]").c_str()); |
| |
| DownloadItem* download_item = CreateFirstSlowTestDownload(); |
| ASSERT_TRUE(download_item); |
| EXPECT_FALSE(download_item->GetOpened()); |
| EXPECT_FALSE(download_item->GetOpenWhenComplete()); |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"application/octet-stream\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_item->GetURL().spec().c_str()))); |
| open_function = new DownloadsOpenFunction(); |
| open_function->set_user_gesture(true); |
| EXPECT_STREQ(errors::kNotComplete, |
| RunFunctionAndReturnError( |
| open_function, |
| DownloadItemIdAsArgList(download_item)).c_str()); |
| |
| FinishFirstSlowDownloads(); |
| EXPECT_FALSE(download_item->GetOpened()); |
| |
| open_function = new DownloadsOpenFunction(); |
| EXPECT_STREQ(errors::kUserGesture, |
| RunFunctionAndReturnError( |
| open_function, |
| DownloadItemIdAsArgList(download_item)).c_str()); |
| current_browser()->tab_strip_model()->GetActiveWebContents(); |
| EXPECT_FALSE(download_item->GetOpened()); |
| |
| scoped_refptr<DownloadsOpenFunction> scoped_open(new DownloadsOpenFunction()); |
| scoped_open->set_user_gesture(true); |
| base::Value args_list(base::Value::Type::LIST); |
| args_list.Append(static_cast<int>(download_item->GetId())); |
| scoped_open->SetArgs(std::move(args_list)); |
| scoped_open->set_extension(extension()); |
| DownloadsOpenFunction::OnPromptCreatedCallback callback = |
| base::BindOnce(&OnOpenPromptCreated, base::Unretained(download_item)); |
| DownloadsOpenFunction::set_on_prompt_created_cb_for_testing(&callback); |
| api_test_utils::SendResponseHelper response_helper(scoped_open.get()); |
| std::unique_ptr<ExtensionFunctionDispatcher> dispatcher( |
| new ExtensionFunctionDispatcher(current_browser()->profile())); |
| scoped_open->SetDispatcher(dispatcher->AsWeakPtr()); |
| scoped_open->RunWithValidation()->Execute(); |
| response_helper.WaitForResponse(); |
| EXPECT_TRUE(response_helper.has_response()); |
| EXPECT_TRUE(response_helper.GetResponse()); |
| DownloadOpenObserver observer(download_item); |
| observer.WaitForEvent(); |
| EXPECT_TRUE(download_item->GetOpened()); |
| } |
| |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_PauseResumeCancelErase) { |
| DownloadItem* download_item = CreateFirstSlowTestDownload(); |
| ASSERT_TRUE(download_item); |
| std::string error; |
| |
| // Call pause(). It should succeed and the download should be paused on |
| // return. |
| EXPECT_TRUE(RunFunction(new DownloadsPauseFunction(), |
| DownloadItemIdAsArgList(download_item))); |
| EXPECT_TRUE(download_item->IsPaused()); |
| |
| // Calling removeFile on a non-active download yields kNotComplete |
| // and should not crash. http://crbug.com/319984 |
| error = RunFunctionAndReturnError(new DownloadsRemoveFileFunction(), |
| DownloadItemIdAsArgList(download_item)); |
| EXPECT_STREQ(errors::kNotComplete, error.c_str()); |
| |
| // Calling pause() twice shouldn't be an error. |
| EXPECT_TRUE(RunFunction(new DownloadsPauseFunction(), |
| DownloadItemIdAsArgList(download_item))); |
| EXPECT_TRUE(download_item->IsPaused()); |
| |
| // Now try resuming this download. It should succeed. |
| EXPECT_TRUE(RunFunction(new DownloadsResumeFunction(), |
| DownloadItemIdAsArgList(download_item))); |
| EXPECT_FALSE(download_item->IsPaused()); |
| |
| // Resume again. Resuming a download that wasn't paused is not an error. |
| EXPECT_TRUE(RunFunction(new DownloadsResumeFunction(), |
| DownloadItemIdAsArgList(download_item))); |
| EXPECT_FALSE(download_item->IsPaused()); |
| |
| // Pause again. |
| EXPECT_TRUE(RunFunction(new DownloadsPauseFunction(), |
| DownloadItemIdAsArgList(download_item))); |
| EXPECT_TRUE(download_item->IsPaused()); |
| |
| // And now cancel. |
| EXPECT_TRUE(RunFunction(new DownloadsCancelFunction(), |
| DownloadItemIdAsArgList(download_item))); |
| EXPECT_EQ(DownloadItem::CANCELLED, download_item->GetState()); |
| |
| // Cancel again. Shouldn't have any effect. |
| EXPECT_TRUE(RunFunction(new DownloadsCancelFunction(), |
| DownloadItemIdAsArgList(download_item))); |
| EXPECT_EQ(DownloadItem::CANCELLED, download_item->GetState()); |
| |
| // Calling paused on a non-active download yields kNotInProgress. |
| error = RunFunctionAndReturnError( |
| new DownloadsPauseFunction(), DownloadItemIdAsArgList(download_item)); |
| EXPECT_STREQ(errors::kNotInProgress, error.c_str()); |
| |
| // Calling resume on a non-active download yields kNotResumable |
| error = RunFunctionAndReturnError( |
| new DownloadsResumeFunction(), DownloadItemIdAsArgList(download_item)); |
| EXPECT_STREQ(errors::kNotResumable, error.c_str()); |
| |
| // Calling pause on a non-existent download yields kInvalidId. |
| error = RunFunctionAndReturnError( |
| new DownloadsPauseFunction(), "[-42]"); |
| EXPECT_STREQ(errors::kInvalidId, error.c_str()); |
| |
| // Calling resume on a non-existent download yields kInvalidId |
| error = RunFunctionAndReturnError( |
| new DownloadsResumeFunction(), "[-42]"); |
| EXPECT_STREQ(errors::kInvalidId, error.c_str()); |
| |
| // Calling removeFile on a non-existent download yields kInvalidId. |
| error = RunFunctionAndReturnError( |
| new DownloadsRemoveFileFunction(), "[-42]"); |
| EXPECT_STREQ(errors::kInvalidId, error.c_str()); |
| |
| int id = download_item->GetId(); |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsEraseFunction(), base::StringPrintf("[{\"id\": %d}]", id))); |
| DownloadManager::DownloadVector items; |
| GetCurrentManager()->GetAllDownloads(&items); |
| EXPECT_EQ(0UL, items.size()); |
| ASSERT_TRUE(result); |
| download_item = NULL; |
| ASSERT_TRUE(result->is_list()); |
| base::Value::ListView result_list = result->GetListDeprecated(); |
| ASSERT_EQ(1UL, result_list.size()); |
| ASSERT_TRUE(result_list[0].is_int()); |
| EXPECT_EQ(id, result_list[0].GetInt()); |
| } |
| |
| scoped_refptr<ExtensionFunction> MockedGetFileIconFunction( |
| const base::FilePath& expected_path, |
| IconLoader::IconSize icon_size, |
| const std::string& response) { |
| scoped_refptr<DownloadsGetFileIconFunction> function( |
| new DownloadsGetFileIconFunction()); |
| function->SetIconExtractorForTesting(new MockIconExtractorImpl( |
| expected_path, icon_size, response)); |
| return function; |
| } |
| |
| // Test downloads.getFileIcon() on in-progress, finished, cancelled and deleted |
| // download items. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_FileIcon_Active) { |
| DownloadItem* download_item = CreateFirstSlowTestDownload(); |
| ASSERT_TRUE(download_item); |
| ASSERT_FALSE(download_item->GetTargetFilePath().empty()); |
| std::string args32(base::StringPrintf("[%d, {\"size\": 32}]", |
| download_item->GetId())); |
| std::string result_string; |
| |
| // Get the icon for the in-progress download. This call should succeed even |
| // if the file type isn't registered. |
| // Test whether the correct path is being pased into the icon extractor. |
| EXPECT_TRUE(RunFunctionAndReturnString(MockedGetFileIconFunction( |
| download_item->GetTargetFilePath(), IconLoader::NORMAL, "foo"), |
| base::StringPrintf("[%d, {}]", download_item->GetId()), &result_string)); |
| |
| // Now try a 16x16 icon. |
| EXPECT_TRUE(RunFunctionAndReturnString(MockedGetFileIconFunction( |
| download_item->GetTargetFilePath(), IconLoader::SMALL, "foo"), |
| base::StringPrintf("[%d, {\"size\": 16}]", download_item->GetId()), |
| &result_string)); |
| |
| // Explicitly asking for 32x32 should give us a 32x32 icon. |
| EXPECT_TRUE(RunFunctionAndReturnString(MockedGetFileIconFunction( |
| download_item->GetTargetFilePath(), IconLoader::NORMAL, "foo"), |
| args32, &result_string)); |
| |
| // Finish the download and try again. |
| FinishFirstSlowDownloads(); |
| EXPECT_EQ(DownloadItem::COMPLETE, download_item->GetState()); |
| EXPECT_TRUE(RunFunctionAndReturnString(MockedGetFileIconFunction( |
| download_item->GetTargetFilePath(), IconLoader::NORMAL, "foo"), |
| args32, &result_string)); |
| |
| // Check the path passed to the icon extractor post-completion. |
| EXPECT_TRUE(RunFunctionAndReturnString(MockedGetFileIconFunction( |
| download_item->GetTargetFilePath(), IconLoader::NORMAL, "foo"), |
| args32, &result_string)); |
| download_item->Remove(); |
| |
| // Now create another download. |
| download_item = CreateSecondSlowTestDownload(); |
| ASSERT_TRUE(download_item); |
| ASSERT_FALSE(download_item->GetTargetFilePath().empty()); |
| args32 = base::StringPrintf("[%d, {\"size\": 32}]", download_item->GetId()); |
| |
| // Cancel the download. As long as the download has a target path, we should |
| // be able to query the file icon. |
| download_item->Cancel(true); |
| ASSERT_FALSE(download_item->GetTargetFilePath().empty()); |
| // Let cleanup complete on blocking threads. |
| content::RunAllTasksUntilIdle(); |
| // Check the path passed to the icon extractor post-cancellation. |
| EXPECT_TRUE(RunFunctionAndReturnString(MockedGetFileIconFunction( |
| download_item->GetTargetFilePath(), IconLoader::NORMAL, "foo"), |
| args32, |
| &result_string)); |
| |
| // Simulate an error during icon load by invoking the mock with an empty |
| // result string. |
| std::string error = RunFunctionAndReturnError( |
| MockedGetFileIconFunction(download_item->GetTargetFilePath(), |
| IconLoader::NORMAL, |
| std::string()), |
| args32); |
| EXPECT_STREQ(errors::kIconNotFound, error.c_str()); |
| |
| // Once the download item is deleted, we should return kInvalidId. |
| int id = download_item->GetId(); |
| download_item->Remove(); |
| download_item = nullptr; |
| EXPECT_EQ(nullptr, GetCurrentManager()->GetDownload(id)); |
| error = RunFunctionAndReturnError(new DownloadsGetFileIconFunction(), args32); |
| EXPECT_STREQ(errors::kInvalidId, |
| error.c_str()); |
| } |
| |
| // Test that we can acquire file icons for history downloads regardless of |
| // whether they exist or not. If the file doesn't exist we should receive a |
| // generic icon from the OS/toolkit that may or may not be specific to the file |
| // type. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_FileIcon_History) { |
| const HistoryDownloadInfo kHistoryInfo[] = { |
| {FILE_PATH_LITERAL("real.txt"), DownloadItem::COMPLETE, |
| download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS}, |
| {FILE_PATH_LITERAL("fake.txt"), DownloadItem::COMPLETE, |
| download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS}}; |
| DownloadManager::DownloadVector all_downloads; |
| ASSERT_TRUE(CreateHistoryDownloads(kHistoryInfo, std::size(kHistoryInfo), |
| &all_downloads)); |
| |
| base::FilePath real_path = all_downloads[0]->GetTargetFilePath(); |
| base::FilePath fake_path = all_downloads[1]->GetTargetFilePath(); |
| |
| { |
| base::ScopedAllowBlockingForTesting allow_blocking; |
| EXPECT_EQ(0, base::WriteFile(real_path, "", 0)); |
| ASSERT_TRUE(base::PathExists(real_path)); |
| ASSERT_FALSE(base::PathExists(fake_path)); |
| } |
| |
| for (auto iter = all_downloads.begin(); iter != all_downloads.end(); ++iter) { |
| std::string result_string; |
| // Use a MockIconExtractorImpl to test if the correct path is being passed |
| // into the DownloadFileIconExtractor. |
| EXPECT_TRUE(RunFunctionAndReturnString(MockedGetFileIconFunction( |
| (*iter)->GetTargetFilePath(), IconLoader::NORMAL, "hello"), |
| base::StringPrintf("[%d, {\"size\": 32}]", (*iter)->GetId()), |
| &result_string)); |
| EXPECT_STREQ("hello", result_string.c_str()); |
| } |
| } |
| |
| // Test passing the empty query to search(). |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_SearchEmptyQuery) { |
| ScopedCancellingItem item(CreateFirstSlowTestDownload()); |
| ASSERT_TRUE(item.get()); |
| |
| std::unique_ptr<base::Value> result( |
| RunFunctionAndReturnResult(new DownloadsSearchFunction(), "[{}]")); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_list()); |
| ASSERT_EQ(1UL, result->GetListDeprecated().size()); |
| } |
| |
| // Test that file existence check should be performed after search. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, FileExistenceCheckAfterSearch) { |
| base::ScopedAllowBlockingForTesting allow_blocking; |
| DownloadItem* download_item = CreateFirstSlowTestDownload(); |
| ASSERT_TRUE(download_item); |
| ASSERT_FALSE(download_item->GetTargetFilePath().empty()); |
| |
| // Finish the download and try again. |
| FinishFirstSlowDownloads(); |
| base::DeleteFile(download_item->GetTargetFilePath()); |
| |
| ASSERT_FALSE(download_item->GetFileExternallyRemoved()); |
| std::unique_ptr<base::Value> result( |
| RunFunctionAndReturnResult(new DownloadsSearchFunction(), "[{}]")); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_list()); |
| ASSERT_EQ(1UL, result->GetListDeprecated().size()); |
| |
| // Check file removal update will eventually come. WaitForEvent() will |
| // immediately return if the file is already removed. |
| content::DownloadUpdatedObserver( |
| download_item, base::BindRepeating(&IsDownloadExternallyRemoved)) |
| .WaitForEvent(); |
| } |
| |
| #if !BUILDFLAG(IS_CHROMEOS_ASH) |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadsShowFunction) { |
| platform_util::internal::DisableShellOperationsForTesting(); |
| ScopedCancellingItem item(CreateFirstSlowTestDownload()); |
| ASSERT_TRUE(item.get()); |
| |
| RunFunction(new DownloadsShowFunction(), DownloadItemIdAsArgList(item.get())); |
| } |
| |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadsShowDefaultFolderFunction) { |
| platform_util::internal::DisableShellOperationsForTesting(); |
| ScopedCancellingItem item(CreateFirstSlowTestDownload()); |
| ASSERT_TRUE(item.get()); |
| |
| RunFunction(new DownloadsShowDefaultFolderFunction(), |
| DownloadItemIdAsArgList(item.get())); |
| } |
| #endif |
| |
| |
| // Test the |filenameRegex| parameter for search(). |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_SearchFilenameRegex) { |
| const HistoryDownloadInfo kHistoryInfo[] = { |
| {FILE_PATH_LITERAL("foobar"), DownloadItem::COMPLETE, |
| download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS}, |
| {FILE_PATH_LITERAL("baz"), DownloadItem::COMPLETE, |
| download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS}}; |
| DownloadManager::DownloadVector all_downloads; |
| ASSERT_TRUE(CreateHistoryDownloads(kHistoryInfo, std::size(kHistoryInfo), |
| &all_downloads)); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsSearchFunction(), "[{\"filenameRegex\": \"foobar\"}]")); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_list()); |
| ASSERT_EQ(1UL, result->GetListDeprecated().size()); |
| const base::Value& item_value = result->GetListDeprecated()[0]; |
| ASSERT_TRUE(item_value.is_dict()); |
| absl::optional<int> item_id = item_value.FindIntKey("id"); |
| ASSERT_TRUE(item_id); |
| ASSERT_EQ(all_downloads[0]->GetId(), static_cast<uint32_t>(*item_id)); |
| } |
| |
| // Test the |id| parameter for search(). |
| // |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, DownloadExtensionTest_SearchId) { |
| DownloadManager::DownloadVector items; |
| CreateTwoDownloads(&items); |
| ScopedItemVectorCanceller delete_items(&items); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsSearchFunction(), |
| base::StringPrintf("[{\"id\": %u}]", items[0]->GetId()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_list()); |
| ASSERT_EQ(1UL, result->GetListDeprecated().size()); |
| const base::Value& item_value = result->GetListDeprecated()[0]; |
| ASSERT_TRUE(item_value.is_dict()); |
| absl::optional<int> item_id = item_value.FindIntKey("id"); |
| ASSERT_TRUE(item_id); |
| ASSERT_EQ(items[0]->GetId(), static_cast<uint32_t>(*item_id)); |
| } |
| |
| // Test specifying both the |id| and |filename| parameters for search(). |
| // |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_SearchIdAndFilename) { |
| DownloadManager::DownloadVector items; |
| CreateTwoDownloads(&items); |
| ScopedItemVectorCanceller delete_items(&items); |
| |
| std::unique_ptr<base::Value> result( |
| RunFunctionAndReturnResult(new DownloadsSearchFunction(), |
| "[{\"id\": 0, \"filename\": \"foobar\"}]")); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_list()); |
| ASSERT_EQ(0UL, result->GetListDeprecated().size()); |
| } |
| |
| // Test a single |orderBy| parameter for search(). |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_SearchOrderBy) { |
| const HistoryDownloadInfo kHistoryInfo[] = { |
| {FILE_PATH_LITERAL("zzz"), DownloadItem::COMPLETE, |
| download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS}, |
| {FILE_PATH_LITERAL("baz"), DownloadItem::COMPLETE, |
| download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS}}; |
| DownloadManager::DownloadVector items; |
| ASSERT_TRUE( |
| CreateHistoryDownloads(kHistoryInfo, std::size(kHistoryInfo), &items)); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsSearchFunction(), "[{\"orderBy\": [\"filename\"]}]")); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_list()); |
| ASSERT_EQ(2UL, result->GetListDeprecated().size()); |
| const base::Value& item0_value = result->GetListDeprecated()[0]; |
| const base::Value& item1_value = result->GetListDeprecated()[1]; |
| ASSERT_TRUE(item0_value.is_dict()); |
| ASSERT_TRUE(item1_value.is_dict()); |
| const std::string* item0_name = item0_value.FindStringKey("filename"); |
| const std::string* item1_name = item1_value.FindStringKey("filename"); |
| ASSERT_TRUE(item0_name); |
| ASSERT_TRUE(item1_name); |
| ASSERT_GT(items[0]->GetTargetFilePath().value(), |
| items[1]->GetTargetFilePath().value()); |
| ASSERT_LT(*item0_name, *item1_name); |
| } |
| |
| // Test specifying an empty |orderBy| parameter for search(). |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_SearchOrderByEmpty) { |
| const HistoryDownloadInfo kHistoryInfo[] = { |
| {FILE_PATH_LITERAL("zzz"), DownloadItem::COMPLETE, |
| download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS}, |
| {FILE_PATH_LITERAL("baz"), DownloadItem::COMPLETE, |
| download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS}}; |
| DownloadManager::DownloadVector items; |
| ASSERT_TRUE( |
| CreateHistoryDownloads(kHistoryInfo, std::size(kHistoryInfo), &items)); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsSearchFunction(), "[{\"orderBy\": []}]")); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_list()); |
| ASSERT_EQ(2UL, result->GetListDeprecated().size()); |
| const base::Value& item0_value = result->GetListDeprecated()[0]; |
| const base::Value& item1_value = result->GetListDeprecated()[1]; |
| ASSERT_TRUE(item0_value.is_dict()); |
| ASSERT_TRUE(item1_value.is_dict()); |
| const std::string* item0_name = item0_value.FindStringKey("filename"); |
| const std::string* item1_name = item1_value.FindStringKey("filename"); |
| ASSERT_TRUE(item0_name); |
| ASSERT_TRUE(item1_name); |
| ASSERT_GT(items[0]->GetTargetFilePath().value(), |
| items[1]->GetTargetFilePath().value()); |
| // The order of results when orderBy is empty is unspecified. When there are |
| // no sorters, DownloadQuery does not call sort(), so the order of the results |
| // depends on the order of the items in DownloadManagerImpl::downloads_, |
| // which is unspecified and differs between libc++ and libstdc++. |
| // http://crbug.com/365334 |
| } |
| |
| // Test the |danger| option for search(). |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_SearchDanger) { |
| const HistoryDownloadInfo kHistoryInfo[] = { |
| {FILE_PATH_LITERAL("zzz"), DownloadItem::COMPLETE, |
| download::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT}, |
| {FILE_PATH_LITERAL("baz"), DownloadItem::COMPLETE, |
| download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS}}; |
| DownloadManager::DownloadVector items; |
| ASSERT_TRUE( |
| CreateHistoryDownloads(kHistoryInfo, std::size(kHistoryInfo), &items)); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsSearchFunction(), "[{\"danger\": \"content\"}]")); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_list()); |
| ASSERT_EQ(1UL, result->GetListDeprecated().size()); |
| } |
| |
| // Test the |state| option for search(). |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_SearchState) { |
| DownloadManager::DownloadVector items; |
| CreateTwoDownloads(&items); |
| ScopedItemVectorCanceller delete_items(&items); |
| |
| items[0]->Cancel(true); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsSearchFunction(), "[{\"state\": \"in_progress\"}]")); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_list()); |
| ASSERT_EQ(1UL, result->GetListDeprecated().size()); |
| } |
| |
| // Test the |limit| option for search(). |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_SearchLimit) { |
| DownloadManager::DownloadVector items; |
| CreateTwoDownloads(&items); |
| ScopedItemVectorCanceller delete_items(&items); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsSearchFunction(), "[{\"limit\": 1}]")); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_list()); |
| ASSERT_EQ(1UL, result->GetListDeprecated().size()); |
| } |
| |
| // Test invalid search parameters. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_SearchInvalid) { |
| std::string error = RunFunctionAndReturnError( |
| new DownloadsSearchFunction(), "[{\"filenameRegex\": \"(\"}]"); |
| EXPECT_STREQ(errors::kInvalidFilter, |
| error.c_str()); |
| error = RunFunctionAndReturnError( |
| new DownloadsSearchFunction(), "[{\"orderBy\": [\"goat\"]}]"); |
| EXPECT_STREQ(errors::kInvalidOrderBy, |
| error.c_str()); |
| error = RunFunctionAndReturnError( |
| new DownloadsSearchFunction(), "[{\"limit\": -1}]"); |
| EXPECT_STREQ(errors::kInvalidQueryLimit, |
| error.c_str()); |
| } |
| |
| // Test searching using multiple conditions through multiple downloads. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_SearchPlural) { |
| const HistoryDownloadInfo kHistoryInfo[] = { |
| {FILE_PATH_LITERAL("aaa"), DownloadItem::CANCELLED, |
| download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS}, |
| {FILE_PATH_LITERAL("zzz"), DownloadItem::COMPLETE, |
| download::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT}, |
| {FILE_PATH_LITERAL("baz"), DownloadItem::COMPLETE, |
| download::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT}, |
| }; |
| DownloadManager::DownloadVector items; |
| ASSERT_TRUE( |
| CreateHistoryDownloads(kHistoryInfo, std::size(kHistoryInfo), &items)); |
| |
| std::unique_ptr<base::Value> result( |
| RunFunctionAndReturnResult(new DownloadsSearchFunction(), |
| "[{" |
| "\"state\": \"complete\", " |
| "\"danger\": \"content\", " |
| "\"orderBy\": [\"filename\"], " |
| "\"limit\": 1}]")); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_list()); |
| ASSERT_EQ(1UL, result->GetListDeprecated().size()); |
| const base::Value& item_value = result->GetListDeprecated()[0]; |
| ASSERT_TRUE(item_value.is_dict()); |
| const std::string* item_name = item_value.FindStringKey("filename"); |
| ASSERT_TRUE(item_name); |
| ASSERT_EQ(items[2]->GetTargetFilePath().AsUTF8Unsafe(), *item_name); |
| } |
| |
| // Test that incognito downloads are only visible in incognito contexts, and |
| // test that on-record downloads are visible in both incognito and on-record |
| // contexts, for DownloadsSearchFunction, DownloadsPauseFunction, |
| // DownloadsResumeFunction, and DownloadsCancelFunction. |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| DownloadExtensionTest_SearchPauseResumeCancelGetFileIconIncognito) { |
| std::unique_ptr<base::Value> result_value; |
| std::string error; |
| std::string result_string; |
| |
| // Set up one on-record item and one off-record item. |
| // Set up the off-record item first because otherwise there are mysteriously 3 |
| // items total instead of 2. |
| // TODO(benjhayden): Figure out where the third item comes from. |
| GoOffTheRecord(); |
| DownloadItem* off_item = CreateFirstSlowTestDownload(); |
| ASSERT_TRUE(off_item); |
| const std::string off_item_arg = DownloadItemIdAsArgList(off_item); |
| |
| GoOnTheRecord(); |
| DownloadItem* on_item = CreateSecondSlowTestDownload(); |
| ASSERT_TRUE(on_item); |
| const std::string on_item_arg = DownloadItemIdAsArgList(on_item); |
| ASSERT_TRUE(on_item->GetTargetFilePath() != off_item->GetTargetFilePath()); |
| |
| // Extensions running in the incognito window should have access to both |
| // items because the Test extension is in spanning mode. |
| GoOffTheRecord(); |
| result_value = |
| RunFunctionAndReturnResult(new DownloadsSearchFunction(), "[{}]"); |
| ASSERT_TRUE(result_value.get()); |
| ASSERT_TRUE(result_value->is_list()); |
| ASSERT_EQ(2UL, result_value->GetListDeprecated().size()); |
| { |
| const base::Value& result_dict = result_value->GetListDeprecated()[0]; |
| ASSERT_TRUE(result_dict.is_dict()); |
| const std::string* filename = result_dict.FindStringKey("filename"); |
| ASSERT_TRUE(filename); |
| absl::optional<bool> is_incognito = result_dict.FindBoolKey("incognito"); |
| ASSERT_TRUE(is_incognito.has_value()); |
| EXPECT_TRUE(on_item->GetTargetFilePath() == |
| base::FilePath::FromUTF8Unsafe(*filename)); |
| EXPECT_FALSE(is_incognito.value()); |
| } |
| { |
| const base::Value& result_dict = result_value->GetListDeprecated()[1]; |
| ASSERT_TRUE(result_dict.is_dict()); |
| const std::string* filename = result_dict.FindStringKey("filename"); |
| ASSERT_TRUE(filename); |
| absl::optional<bool> is_incognito = result_dict.FindBoolKey("incognito"); |
| ASSERT_TRUE(is_incognito.has_value()); |
| EXPECT_TRUE(off_item->GetTargetFilePath() == |
| base::FilePath::FromUTF8Unsafe(*filename)); |
| EXPECT_TRUE(is_incognito.value()); |
| } |
| |
| // Extensions running in the on-record window should have access only to the |
| // on-record item. |
| GoOnTheRecord(); |
| result_value = |
| RunFunctionAndReturnResult(new DownloadsSearchFunction(), "[{}]"); |
| ASSERT_TRUE(result_value.get()); |
| ASSERT_TRUE(result_value->is_list()); |
| ASSERT_EQ(1UL, result_value->GetListDeprecated().size()); |
| { |
| const base::Value& result_dict = result_value->GetListDeprecated()[0]; |
| ASSERT_TRUE(result_dict.is_dict()); |
| const std::string* filename = result_dict.FindStringKey("filename"); |
| ASSERT_TRUE(filename); |
| EXPECT_TRUE(on_item->GetTargetFilePath() == |
| base::FilePath::FromUTF8Unsafe(*filename)); |
| absl::optional<bool> is_incognito = result_dict.FindBoolKey("incognito"); |
| ASSERT_TRUE(is_incognito.has_value()); |
| EXPECT_FALSE(is_incognito.value()); |
| } |
| |
| // Pausing/Resuming the off-record item while on the record should return an |
| // error. Cancelling "non-existent" downloads is not an error. |
| error = RunFunctionAndReturnError(new DownloadsPauseFunction(), off_item_arg); |
| EXPECT_STREQ(errors::kInvalidId, |
| error.c_str()); |
| error = RunFunctionAndReturnError(new DownloadsResumeFunction(), |
| off_item_arg); |
| EXPECT_STREQ(errors::kInvalidId, |
| error.c_str()); |
| error = RunFunctionAndReturnError( |
| new DownloadsGetFileIconFunction(), |
| base::StringPrintf("[%d, {}]", off_item->GetId())); |
| EXPECT_STREQ(errors::kInvalidId, |
| error.c_str()); |
| |
| GoOffTheRecord(); |
| |
| // Do the FileIcon test for both the on- and off-items while off the record. |
| // NOTE(benjhayden): This does not include the FileIcon test from history, |
| // just active downloads. This shouldn't be a problem. |
| EXPECT_TRUE(RunFunctionAndReturnString(MockedGetFileIconFunction( |
| on_item->GetTargetFilePath(), IconLoader::NORMAL, "foo"), |
| base::StringPrintf("[%d, {}]", on_item->GetId()), &result_string)); |
| EXPECT_TRUE(RunFunctionAndReturnString(MockedGetFileIconFunction( |
| off_item->GetTargetFilePath(), IconLoader::NORMAL, "foo"), |
| base::StringPrintf("[%d, {}]", off_item->GetId()), &result_string)); |
| |
| // Do the pause/resume/cancel test for both the on- and off-items while off |
| // the record. |
| EXPECT_TRUE(RunFunction(new DownloadsPauseFunction(), on_item_arg)); |
| EXPECT_TRUE(on_item->IsPaused()); |
| EXPECT_TRUE(RunFunction(new DownloadsPauseFunction(), on_item_arg)); |
| EXPECT_TRUE(on_item->IsPaused()); |
| EXPECT_TRUE(RunFunction(new DownloadsResumeFunction(), on_item_arg)); |
| EXPECT_FALSE(on_item->IsPaused()); |
| EXPECT_TRUE(RunFunction(new DownloadsResumeFunction(), on_item_arg)); |
| EXPECT_FALSE(on_item->IsPaused()); |
| EXPECT_TRUE(RunFunction(new DownloadsPauseFunction(), on_item_arg)); |
| EXPECT_TRUE(on_item->IsPaused()); |
| EXPECT_TRUE(RunFunction(new DownloadsCancelFunction(), on_item_arg)); |
| EXPECT_EQ(DownloadItem::CANCELLED, on_item->GetState()); |
| EXPECT_TRUE(RunFunction(new DownloadsCancelFunction(), on_item_arg)); |
| EXPECT_EQ(DownloadItem::CANCELLED, on_item->GetState()); |
| error = RunFunctionAndReturnError(new DownloadsPauseFunction(), on_item_arg); |
| EXPECT_STREQ(errors::kNotInProgress, error.c_str()); |
| error = RunFunctionAndReturnError(new DownloadsResumeFunction(), on_item_arg); |
| EXPECT_STREQ(errors::kNotResumable, error.c_str()); |
| EXPECT_TRUE(RunFunction(new DownloadsPauseFunction(), off_item_arg)); |
| EXPECT_TRUE(off_item->IsPaused()); |
| EXPECT_TRUE(RunFunction(new DownloadsPauseFunction(), off_item_arg)); |
| EXPECT_TRUE(off_item->IsPaused()); |
| EXPECT_TRUE(RunFunction(new DownloadsResumeFunction(), off_item_arg)); |
| EXPECT_FALSE(off_item->IsPaused()); |
| EXPECT_TRUE(RunFunction(new DownloadsResumeFunction(), off_item_arg)); |
| EXPECT_FALSE(off_item->IsPaused()); |
| EXPECT_TRUE(RunFunction(new DownloadsPauseFunction(), off_item_arg)); |
| EXPECT_TRUE(off_item->IsPaused()); |
| EXPECT_TRUE(RunFunction(new DownloadsCancelFunction(), off_item_arg)); |
| EXPECT_EQ(DownloadItem::CANCELLED, off_item->GetState()); |
| EXPECT_TRUE(RunFunction(new DownloadsCancelFunction(), off_item_arg)); |
| EXPECT_EQ(DownloadItem::CANCELLED, off_item->GetState()); |
| error = RunFunctionAndReturnError(new DownloadsPauseFunction(), off_item_arg); |
| EXPECT_STREQ(errors::kNotInProgress, error.c_str()); |
| error = RunFunctionAndReturnError(new DownloadsResumeFunction(), |
| off_item_arg); |
| EXPECT_STREQ(errors::kNotResumable, error.c_str()); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_Download_Basic \ |
| DISABLED_DownloadExtensionTest_Download_Basic |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_Basic \ |
| DownloadExtensionTest_Download_Basic |
| #endif |
| // Test that we can start a download and that the correct sequence of events is |
| // fired for it. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_Basic) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| GoOnTheRecord(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| ASSERT_EQ(GetExtensionStoragePartitionConfig(), |
| GetCurrentManager() |
| ->SerializedEmbedderDownloadDataToStoragePartitionConfig( |
| item->GetSerializedEmbedderDownloadData())); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"finalUrl\": \"%s\"," |
| " \"url\": \"%s\"}]", |
| download_url.c_str(), |
| download_url.c_str()))); |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_Download_Redirect \ |
| DISABLED_DownloadExtensionTest_Download_Redirect |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_Redirect \ |
| DownloadExtensionTest_Download_Redirect |
| #endif |
| // Test that we can start a download that gets redirected and that the correct |
| // sequence of events is fired for it. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_Redirect) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| GURL download_final_url(embedded_test_server()->GetURL("/slow?0")); |
| GURL download_url(embedded_test_server()->GetURL("/server-redirect?" + |
| download_final_url.spec())); |
| |
| GoOnTheRecord(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.spec().c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl()); |
| ASSERT_EQ(GetExtensionStoragePartitionConfig(), |
| GetCurrentManager() |
| ->SerializedEmbedderDownloadDataToStoragePartitionConfig( |
| item->GetSerializedEmbedderDownloadData())); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"finalUrl\": \"%s\"," |
| " \"url\": \"%s\"}]", |
| download_final_url.spec().c_str(), |
| download_url.spec().c_str()))); |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // Test that we can start a download from an incognito context, and that the |
| // download knows that it's incognito. |
| #if BUILDFLAG(IS_WIN) |
| // TODO(https://crbug.com/1245173) Flaky on Win7 |
| #define MAYBE_DownloadExtensionTest_Download_Incognito \ |
| DISABLED_DownloadExtensionTest_Download_Incognito |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_Incognito \ |
| DownloadExtensionTest_Download_Incognito |
| #endif |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_Incognito) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| GoOffTheRecord(); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(GetCurrentManager()->GetBrowserContext()->IsOffTheRecord()); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": true," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\":%d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\":%d," |
| " \"state\": {" |
| " \"current\": \"complete\"," |
| " \"previous\": \"in_progress\"}}]", |
| result_id))); |
| } |
| |
| // Test that if file name with disallowed characters are provided, the |
| // characters will be replaced. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_Disallowed_Character_In_Filename) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| GoOnTheRecord(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\", \"filename\": \"foo%%bar\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| std::unique_ptr<content::DownloadTestObserver> obs(CreateDownloadObserver(1)); |
| obs->WaitForFinished(); |
| EXPECT_EQ(FILE_PATH_LITERAL("foo_bar"), |
| item->GetFileNameToReportUser().value()); |
| } |
| |
| namespace { |
| |
| class CustomResponse : public net::test_server::HttpResponse { |
| public: |
| CustomResponse(base::OnceClosure* callback, |
| base::TaskRunner** task_runner, |
| bool first_request) |
| : callback_(callback), |
| task_runner_(task_runner), |
| first_request_(first_request) {} |
| |
| CustomResponse(const CustomResponse&) = delete; |
| CustomResponse& operator=(const CustomResponse&) = delete; |
| |
| ~CustomResponse() override {} |
| |
| void SendResponse( |
| base::WeakPtr<net::test_server::HttpResponseDelegate> delegate) override { |
| base::StringPairs headers = { |
| //"HTTP/1.1 200 OK\r\n" |
| {"Content-type", "application/octet-stream"}, |
| {"Cache-Control", "max-age=0"}, |
| }; |
| std::string contents = std::string(kDownloadSize, '*'); |
| |
| if (first_request_) { |
| *callback_ = base::BindOnce( |
| &net::test_server::HttpResponseDelegate::FinishResponse, delegate); |
| *task_runner_ = base::ThreadTaskRunnerHandle::Get().get(); |
| delegate->SendResponseHeaders(net::HTTP_OK, "OK", headers); |
| delegate->SendContents(contents); |
| } else { |
| delegate->SendHeadersContentAndFinish(net::HTTP_OK, "OK", headers, |
| contents); |
| } |
| } |
| |
| private: |
| raw_ptr<base::OnceClosure> callback_; |
| raw_ptr<base::TaskRunner*> task_runner_; |
| bool first_request_; |
| }; |
| |
| } // namespace |
| |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_Download_InterruptAndResume) { |
| LoadExtension("downloads_split"); |
| |
| DownloadItem* item = nullptr; |
| |
| base::OnceClosure complete_callback; |
| base::TaskRunner* embedded_test_server_io_runner = nullptr; |
| const char kThirdDownloadUrl[] = "/download3"; |
| bool first_request = true; |
| embedded_test_server()->RegisterRequestHandler(base::BindLambdaForTesting( |
| [&](const net::test_server::HttpRequest& request) { |
| std::unique_ptr<net::test_server::HttpResponse> rv; |
| if (request.relative_url == kThirdDownloadUrl) { |
| rv = std::make_unique<CustomResponse>(&complete_callback, |
| &embedded_test_server_io_runner, |
| first_request); |
| first_request = false; |
| } |
| return rv; |
| })); |
| |
| StartEmbeddedTestServer(); |
| const GURL download_url = embedded_test_server()->GetURL(kThirdDownloadUrl); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.spec().c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl()); |
| ASSERT_EQ(GetExtensionStoragePartitionConfig(), |
| GetCurrentManager() |
| ->SerializedEmbedderDownloadDataToStoragePartitionConfig( |
| item->GetSerializedEmbedderDownloadData())); |
| |
| item->SimulateErrorForTesting( |
| download::DOWNLOAD_INTERRUPT_REASON_NETWORK_FAILED); |
| embedded_test_server_io_runner->PostTask(FROM_HERE, |
| std::move(complete_callback)); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\":%d," |
| " \"state\": {" |
| " \"current\": \"interrupted\"," |
| " \"previous\": \"in_progress\"}}]", |
| result_id))); |
| |
| EXPECT_TRUE(RunFunction(new DownloadsResumeFunction(), |
| DownloadItemIdAsArgList(item))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\":%d," |
| " \"state\": {" |
| " \"current\": \"in_progress\"," |
| " \"previous\": \"interrupted\"}}]", |
| result_id))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\":%d," |
| " \"state\": {" |
| " \"current\": \"complete\"," |
| " \"previous\": \"in_progress\"}}]", |
| result_id))); |
| } |
| |
| // Test that we disallow certain headers case-insensitively. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_Download_UnsafeHeaders) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| GoOnTheRecord(); |
| |
| static const char* const kUnsafeHeaders[] = { |
| "Accept-chArsEt", |
| "accept-eNcoding", |
| "coNNection", |
| "coNteNt-leNgth", |
| "cooKIE", |
| "cOOkie2", |
| "dAtE", |
| "DNT", |
| "ExpEcT", |
| "hOsT", |
| "kEEp-aLivE", |
| "rEfErEr", |
| "tE", |
| "trAilER", |
| "trANsfer-eNcodiNg", |
| "upGRAde", |
| "usER-agENt", |
| "viA", |
| "pRoxY-", |
| "sEc-", |
| "pRoxY-probably-not-evil", |
| "sEc-probably-not-evil", |
| "oRiGiN", |
| "Access-Control-Request-Headers", |
| "Access-Control-Request-Method", |
| }; |
| |
| for (size_t index = 0; index < std::size(kUnsafeHeaders); ++index) { |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| EXPECT_STREQ(errors::kInvalidHeaderUnsafe, |
| RunFunctionAndReturnError(new DownloadsDownloadFunction(), |
| base::StringPrintf( |
| "[{\"url\": \"%s\"," |
| " \"filename\": \"unsafe-header-%d.txt\"," |
| " \"headers\": [{" |
| " \"name\": \"%s\"," |
| " \"value\": \"unsafe\"}]}]", |
| download_url.c_str(), |
| static_cast<int>(index), |
| kUnsafeHeaders[index])).c_str()); |
| } |
| } |
| |
| // Tests that invalid header names and values are rejected. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_Download_InvalidHeaders) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| GoOnTheRecord(); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| EXPECT_STREQ(errors::kInvalidHeaderName, |
| RunFunctionAndReturnError(new DownloadsDownloadFunction(), |
| base::StringPrintf( |
| "[{\"url\": \"%s\"," |
| " \"filename\": \"unsafe-header-crlf.txt\"," |
| " \"headers\": [{" |
| " \"name\": \"Header\\r\\nSec-Spoof: Hey\\r\\nX-Split:X\"," |
| " \"value\": \"unsafe\"}]}]", |
| download_url.c_str())).c_str()); |
| |
| EXPECT_STREQ(errors::kInvalidHeaderValue, |
| RunFunctionAndReturnError(new DownloadsDownloadFunction(), |
| base::StringPrintf( |
| "[{\"url\": \"%s\"," |
| " \"filename\": \"unsafe-header-crlf.txt\"," |
| " \"headers\": [{" |
| " \"name\": \"Invalid-value\"," |
| " \"value\": \"hey\\r\\nSec-Spoof: Hey\"}]}]", |
| download_url.c_str())).c_str()); |
| } |
| |
| // This test is very flaky on Win. http://crbug.com/248438 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_Download_Subdirectory\ |
| DISABLED_DownloadExtensionTest_Download_Subdirectory |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_Subdirectory\ |
| DownloadExtensionTest_Download_Subdirectory |
| #endif |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_Subdirectory) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| GoOnTheRecord(); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"," |
| " \"filename\": \"sub/dir/ect/ory.txt\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, |
| GetFilename("sub/dir/ect/ory.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // Test that invalid filenames are disallowed. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_Download_InvalidFilename) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| GoOnTheRecord(); |
| |
| EXPECT_STREQ(errors::kInvalidFilename, |
| RunFunctionAndReturnError(new DownloadsDownloadFunction(), |
| base::StringPrintf( |
| "[{\"url\": \"%s\"," |
| " \"filename\": \"../../../../../etc/passwd\"}]", |
| download_url.c_str())).c_str()); |
| } |
| |
| // Test that downloading invalid URLs immediately returns kInvalidURLError. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_Download_InvalidURLs1) { |
| static constexpr const char* kInvalidURLs[] = { |
| "foo bar", "../hello", "/hello", "http://", |
| "#frag", "foo/bar.html#frag", "google.com/", |
| }; |
| |
| for (const char* url : kInvalidURLs) { |
| EXPECT_STREQ(errors::kInvalidURL, |
| RunFunctionAndReturnError( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", url)) |
| .c_str()) |
| << url; |
| } |
| } |
| |
| // Test various failure modes for downloading invalid URLs. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_Download_InvalidURLs2) { |
| LoadExtension("downloads_split"); |
| GoOnTheRecord(); |
| |
| int result_id = -1; |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| "[{\"url\": \"javascript:document.write(\\\"hello\\\");\"}]")); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ASSERT_TRUE(WaitForInterruption( |
| item, download::DOWNLOAD_INTERRUPT_REASON_NETWORK_INVALID_REQUEST, |
| "[{\"state\": \"in_progress\"," |
| " \"url\": \"javascript:document.write(\\\"hello\\\");\"}]")); |
| |
| result = |
| RunFunctionAndReturnResult(new DownloadsDownloadFunction(), |
| "[{\"url\": \"javascript:return false;\"}]"); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| result_id = result->GetInt(); |
| item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ASSERT_TRUE(WaitForInterruption( |
| item, download::DOWNLOAD_INTERRUPT_REASON_NETWORK_INVALID_REQUEST, |
| "[{\"state\": \"in_progress\"," |
| " \"url\": \"javascript:return false;\"}]")); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_Download_URLFragment \ |
| DISABLED_DownloadExtensionTest_Download_URLFragment |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_URLFragment \ |
| DownloadExtensionTest_Download_URLFragment |
| #endif |
| // Valid URLs plus fragments are still valid URLs. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_URLFragment) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = |
| embedded_test_server()->GetURL("/slow?0#fragment").spec(); |
| GoOnTheRecord(); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // conflictAction may be specified without filename. |
| #if BUILDFLAG(IS_WIN) |
| // TODO(https://crbug.com/1245173) Flaky on Win7 |
| #define MAYBE_DownloadExtensionTest_Download_ConflictAction \ |
| DISABLED_DownloadExtensionTest_Download_ConflictAction |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_ConflictAction \ |
| DownloadExtensionTest_Download_ConflictAction |
| #endif |
| |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_ConflictAction) { |
| static char kFilename[] = "download.txt"; |
| LoadExtension("downloads_split"); |
| std::string download_url = "data:text/plain,hello"; |
| GoOnTheRecord(); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, |
| GetFilename(kFilename).c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| |
| result = RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf( |
| "[{\"url\": \"%s\", \"conflictAction\": \"overwrite\"}]", |
| download_url.c_str())); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| result_id = result->GetInt(); |
| item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller2(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, |
| GetFilename(kFilename).c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_Download_DataURL \ |
| DISABLED_DownloadExtensionTest_Download_DataURL |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_DataURL \ |
| DownloadExtensionTest_Download_DataURL |
| #endif |
| // Valid data URLs are valid URLs. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_DataURL) { |
| LoadExtension("downloads_split"); |
| std::string download_url = "data:text/plain,hello"; |
| GoOnTheRecord(); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"," |
| " \"filename\": \"data.txt\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, |
| GetFilename("data.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // Valid file URLs are valid URLs. |
| #if BUILDFLAG(IS_WIN) |
| // Disabled due to crbug.com/175711 |
| #define MAYBE_DownloadExtensionTest_Download_File \ |
| DISABLED_DownloadExtensionTest_Download_File |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_File \ |
| DownloadExtensionTest_Download_File |
| #endif |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_File) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split", /*enable_file_access=*/true); |
| std::string download_url = "file:///"; |
| #if BUILDFLAG(IS_WIN) |
| download_url += "C:/"; |
| #endif |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"," |
| " \"filename\": \"file.txt\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"text/html\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| // Extension for file URLs will not change even if the mime type is text/html. |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("file").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // Test that auth-basic-succeed would fail if the resource requires the |
| // Authorization header and chrome fails to propagate it back to the server. |
| // This tests both that testserver.py does not succeed when it should fail as |
| // well as how the downloads extension API exposes the failure to extensions. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_Download_AuthBasic_Fail) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = |
| embedded_test_server()->GetURL("/auth-basic").spec(); |
| GoOnTheRecord(); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"," |
| " \"filename\": \"auth-basic-fail.txt\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitForInterruption( |
| item, download::DOWNLOAD_INTERRUPT_REASON_SERVER_UNAUTHORIZED, |
| base::StringPrintf("[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_Download_Headers \ |
| DISABLED_DownloadExtensionTest_Download_Headers |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_Headers \ |
| DownloadExtensionTest_Download_Headers |
| #endif |
| // Test that DownloadsDownloadFunction propagates |headers| to the URLRequest. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_Headers) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = |
| embedded_test_server() |
| ->GetURL( |
| "/downloads/" |
| "a_zip_file.zip?expected_headers=Foo:bar&expected_headers=Qx:yo") |
| .spec(); |
| GoOnTheRecord(); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"," |
| " \"filename\": \"headers-succeed.txt\"," |
| " \"headers\": [" |
| " {\"name\": \"Foo\", \"value\": \"bar\"}," |
| " {\"name\": \"Qx\", \"value\":\"yo\"}]}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"application/octet-stream\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, |
| GetFilename("headers-succeed.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // Test that headers-succeed would fail if the resource requires the headers and |
| // chrome fails to propagate them back to the server. This tests both that |
| // testserver.py does not succeed when it should fail as well as how the |
| // downloads extension api exposes the failure to extensions. |
| // TODO(https://crbug.com/1249757): DownloadExtensionTest's are flaky |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_Download_Headers_Fail \ |
| DISABLED_DownloadExtensionTest_Download_Headers_Fail |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_Headers_Fail \ |
| DownloadExtensionTest_Download_Headers_Fail |
| #endif |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_Headers_Fail) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = |
| embedded_test_server() |
| ->GetURL( |
| "/downloads/" |
| "a_zip_file.zip?expected_headers=Foo:bar&expected_headers=Qx:yo") |
| .spec(); |
| GoOnTheRecord(); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"," |
| " \"filename\": \"headers-fail.txt\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitForInterruption( |
| item, download::DOWNLOAD_INTERRUPT_REASON_SERVER_BAD_CONTENT, |
| base::StringPrintf("[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"bytesReceived\": 0.0," |
| " \"fileSize\": 0.0," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| } |
| |
| // Test that DownloadsDownloadFunction propagates the Authorization header |
| // correctly. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_Download_AuthBasic) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = |
| embedded_test_server()->GetURL("/auth-basic").spec(); |
| // This is just base64 of 'username:secret'. |
| static const char kAuthorization[] = "dXNlcm5hbWU6c2VjcmV0"; |
| GoOnTheRecord(); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"," |
| " \"filename\": \"auth-basic-succeed.txt\"," |
| " \"headers\": [{" |
| " \"name\": \"Authorization\"," |
| " \"value\": \"Basic %s\"}]}]", |
| download_url.c_str(), kAuthorization))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"bytesReceived\": 0.0," |
| " \"mime\": \"text/html\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // Test that DownloadsDownloadFunction propagates the |method| and |body| |
| // parameters to the URLRequest. |
| #if BUILDFLAG(IS_WIN) |
| // TODO(https://crbug.com/1245173) Flaky on Win7 |
| #define MAYBE_DownloadExtensionTest_Download_Post \ |
| DISABLED_DownloadExtensionTest_Download_Post |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_Post \ |
| DownloadExtensionTest_Download_Post |
| #endif |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_Post) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server() |
| ->GetURL( |
| "/post/downloads/" |
| "a_zip_file.zip?expected_body=BODY") |
| .spec(); |
| GoOnTheRecord(); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"," |
| " \"filename\": \"post-succeed.txt\"," |
| " \"method\": \"POST\"," |
| " \"body\": \"BODY\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"application/octet-stream\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, |
| GetFilename("post-succeed.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // Test that downloadPostSuccess would fail if the resource requires the POST |
| // method, and chrome fails to propagate the |method| parameter back to the |
| // server. This tests both that testserver.py does not succeed when it should |
| // fail, and this tests how the downloads extension api exposes the failure to |
| // extensions. |
| // TODO(https://crbug.com/1249757): DownloadExtensionTest's are flaky |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_Download_Post_Get \ |
| DISABLED_DownloadExtensionTest_Download_Post_Get |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_Post_Get \ |
| DownloadExtensionTest_Download_Post_Get |
| #endif |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_Post_Get) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server() |
| ->GetURL( |
| "/post/downloads/" |
| "a_zip_file.zip?expected_body=BODY") |
| .spec(); |
| GoOnTheRecord(); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"," |
| " \"body\": \"BODY\"," |
| " \"filename\": \"post-get.txt\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitForInterruption( |
| item, download::DOWNLOAD_INTERRUPT_REASON_SERVER_BAD_CONTENT, |
| base::StringPrintf("[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"id\": %d," |
| " \"url\": \"%s\"}]", |
| result_id, download_url.c_str()))); |
| } |
| |
| // Test that downloadPostSuccess would fail if the resource requires the POST |
| // method, and chrome fails to propagate the |body| parameter back to the |
| // server. This tests both that testserver.py does not succeed when it should |
| // fail, and this tests how the downloads extension api exposes the failure to |
| // extensions. |
| // TODO(https://crbug.com/1249757): DownloadExtensionTest's are flaky |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_Download_Post_NoBody \ |
| DISABLED_DownloadExtensionTest_Download_Post_NoBody |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_Post_NoBody \ |
| DownloadExtensionTest_Download_Post_NoBody |
| #endif |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_Post_NoBody) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server() |
| ->GetURL( |
| "/post/downloads/" |
| "a_zip_file.zip?expected_body=BODY") |
| .spec(); |
| GoOnTheRecord(); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"," |
| " \"method\": \"POST\"," |
| " \"filename\": \"post-nobody.txt\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitForInterruption( |
| item, download::DOWNLOAD_INTERRUPT_REASON_SERVER_BAD_CONTENT, |
| base::StringPrintf("[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"id\": %d," |
| " \"url\": \"%s\"}]", |
| result_id, download_url.c_str()))); |
| } |
| |
| // Test that cancel()ing an in-progress download causes its state to transition |
| // to interrupted, and test that that state transition is detectable by an |
| // onChanged event listener. TODO(benjhayden): Test other sources of |
| // interruptions such as server death. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_Download_Cancel) { |
| LoadExtension("downloads_split"); |
| embedded_test_server()->RegisterRequestHandler(base::BindRepeating( |
| &content::SlowDownloadHttpResponse::HandleSlowDownloadRequest)); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = |
| embedded_test_server()->GetURL("/download-known-size").spec(); |
| GoOnTheRecord(); |
| |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"application/octet-stream\"," |
| " \"paused\": false," |
| " \"id\": %d," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| item->Cancel(true); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"error\": {\"current\":\"USER_CANCELED\"}," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"interrupted\"}}]", |
| result_id))); |
| } |
| |
| // TODO(https://crbug.com/392288): Flaky on macOS |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_Download_FileSystemURL \ |
| DISABLED_DownloadExtensionTest_Download_FileSystemURL |
| #else |
| #define MAYBE_DownloadExtensionTest_Download_FileSystemURL \ |
| DownloadExtensionTest_Download_FileSystemURL |
| #endif |
| |
| // Test downloading filesystem: URLs. |
| // NOTE: chrome disallows creating HTML5 FileSystem Files in incognito. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_Download_FileSystemURL) { |
| static const char kPayloadData[] = "on the record\ndata"; |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| |
| const std::string download_url = "filesystem:" + GetExtensionURL() + |
| "temporary/on_record.txt"; |
| |
| // Setup a file in the filesystem which we can download. |
| ASSERT_TRUE(HTML5FileWriter::CreateFileForTesting( |
| current_browser() |
| ->profile() |
| ->GetDefaultStoragePartition() |
| ->GetFileSystemContext(), |
| storage::FileSystemURL::CreateForTest(GURL(download_url)), kPayloadData, |
| strlen(kPayloadData))); |
| |
| // Now download it. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, |
| GetFilename("on_record.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| base::ScopedAllowBlockingForTesting allow_blocking; |
| std::string disk_data; |
| EXPECT_TRUE(base::ReadFileToString(item->GetTargetFilePath(), &disk_data)); |
| EXPECT_STREQ(kPayloadData, disk_data.c_str()); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_NoChange \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_NoChange |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_NoChange \ |
| DownloadExtensionTest_OnDeterminingFilename_NoChange |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_NoChange) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| // Wait for the onCreated and onDeterminingFilename events. |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| std::string error; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(), downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_EQ("", error); |
| |
| // The download should complete successfully. |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // Disabled due to cross-platform flakes; http://crbug.com/370531. |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_Timeout) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| ExtensionDownloadsEventRouter::SetDetermineFilenameTimeoutSecondsForTesting( |
| 0); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| // Wait for the onCreated and onDeterminingFilename events. |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf("[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor( |
| downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Do not respond to the onDeterminingFilename. |
| |
| // The download should complete successfully. |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_Twice \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_Twice |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_Twice \ |
| DownloadExtensionTest_OnDeterminingFilename_Twice |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_Twice) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| // Wait for the onCreated and onDeterminingFilename events. |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf("[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor( |
| downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| std::string error; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(), downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_EQ("", error); |
| |
| // Calling DetermineFilename again should return an error instead of calling |
| // DownloadTargetDeterminer. |
| ASSERT_FALSE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(FILE_PATH_LITERAL("different")), |
| downloads::FILENAME_CONFLICT_ACTION_OVERWRITE, &error)); |
| EXPECT_EQ(errors::kTooManyListeners, error); |
| |
| // The download should complete successfully. |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // Tests downloadsInternal.determineFilename. |
| // Regression test for https://crbug.com/815362. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadsInternalDetermineFilename) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf(R"([{"url": "%s"}])", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| // Wait for the onCreated and onDeterminingFilename events. |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf(R"([{ |
| "danger": "safe", |
| "incognito": false, |
| "id": %d, |
| "mime": "text/plain", |
| "paused": false, |
| "url": "%s" |
| }])", |
| result_id, download_url.c_str()))); |
| ASSERT_TRUE( |
| WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| R"([{"id": %d, "filename": "slow.txt"}])", result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| std::unique_ptr<base::Value> determine_result(RunFunctionAndReturnResult( |
| new DownloadsInternalDetermineFilenameFunction(), |
| base::StringPrintf(R"([%d, "", "uniquify"])", result_id))); |
| EXPECT_FALSE(determine_result.get()); // No return value. |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_DangerousOverride \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_DangerousOverride |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_DangerousOverride \ |
| DownloadExtensionTest_OnDeterminingFilename_DangerousOverride |
| #endif |
| // Tests that overriding a safe file extension to a dangerous extension will not |
| // trigger the dangerous prompt and will not change the extension. |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_DangerousOverride) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename with a dangerous extension. |
| std::string error; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(FILE_PATH_LITERAL("overridden.swf")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_EQ("", error); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| EXPECT_EQ(downloads_directory().AppendASCII("overridden.txt"), |
| item->GetTargetFilePath()); |
| } |
| |
| // Tests that overriding a dangerous file extension to a safe extension will |
| // trigger the dangerous prompt and will not change the extension. |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| DownloadExtensionTest_OnDeterminingFilename_SafeOverride) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| |
| std::string download_url = "data:application/x-shockwave-flash,"; |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor( |
| downloads::OnCreated::kEventName, |
| base::StringPrintf("[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"application/x-shockwave-flash\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\":\"download.swf\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename with a safe extension. |
| std::string error; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(FILE_PATH_LITERAL("overridden.txt")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_EQ("", error); |
| |
| // Dangerous download prompt will be shown. |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d, " |
| " \"danger\": {" |
| " \"previous\": \"safe\"," |
| " \"current\": \"file\"}}]", |
| result_id))); |
| |
| item->ValidateDangerousDownload(); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"danger\": {" |
| " \"previous\":\"file\"," |
| " \"current\":\"accepted\"}}]", |
| result_id))); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| EXPECT_EQ(downloads_directory().AppendASCII("overridden.swf"), |
| item->GetTargetFilePath()); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_ReferencesParentInvalid \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_ReferencesParentInvalid |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_ReferencesParentInvalid \ |
| DownloadExtensionTest_OnDeterminingFilename_ReferencesParentInvalid |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_ReferencesParentInvalid) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| std::string error; |
| ASSERT_FALSE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(FILE_PATH_LITERAL("sneaky/../../sneaky.txt")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_STREQ(errors::kInvalidFilename, error.c_str()); |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_IllegalFilename \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_IllegalFilename |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_IllegalFilename \ |
| DownloadExtensionTest_OnDeterminingFilename_IllegalFilename |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_IllegalFilename) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| std::string error; |
| ASSERT_FALSE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(FILE_PATH_LITERAL("<")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_STREQ(errors::kInvalidFilename, error.c_str()); |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_IllegalFilenameExtension \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_IllegalFilenameExtension |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_IllegalFilenameExtension \ |
| DownloadExtensionTest_OnDeterminingFilename_IllegalFilenameExtension |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_IllegalFilenameExtension) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| std::string error; |
| ASSERT_FALSE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(FILE_PATH_LITERAL( |
| "My Computer.{20D04FE0-3AEA-1069-A2D8-08002B30309D}/foo")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_STREQ(errors::kInvalidFilename, error.c_str()); |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_ReservedFilename\ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_ReservedFilename |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_ReservedFilename\ |
| DownloadExtensionTest_OnDeterminingFilename_ReservedFilename |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_ReservedFilename) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| std::string error; |
| ASSERT_FALSE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(FILE_PATH_LITERAL("con.foo")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_STREQ(errors::kInvalidFilename, error.c_str()); |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_CurDirInvalid \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_CurDirInvalid |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_CurDirInvalid \ |
| DownloadExtensionTest_OnDeterminingFilename_CurDirInvalid |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_CurDirInvalid) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| std::string error; |
| ASSERT_FALSE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(FILE_PATH_LITERAL(".")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_STREQ(errors::kInvalidFilename, error.c_str()); |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_ParentDirInvalid \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_ParentDirInvalid |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_ParentDirInvalid \ |
| DownloadExtensionTest_OnDeterminingFilename_ParentDirInvalid |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_ParentDirInvalid) { |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| std::string error; |
| ASSERT_FALSE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(FILE_PATH_LITERAL("..")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_STREQ(errors::kInvalidFilename, error.c_str()); |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_AbsPathInvalid \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_AbsPathInvalid |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_AbsPathInvalid \ |
| DownloadExtensionTest_OnDeterminingFilename_AbsPathInvalid |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_AbsPathInvalid) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. Absolute paths should be rejected. |
| std::string error; |
| ASSERT_FALSE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| downloads_directory().Append(FILE_PATH_LITERAL("sneaky.txt")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_STREQ(errors::kInvalidFilename, error.c_str()); |
| |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // Flaky. crbug.com/1147804 |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_EmptyBasenameInvalid) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. Empty basenames should be rejected. |
| std::string error; |
| ASSERT_FALSE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(FILE_PATH_LITERAL("foo/")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_STREQ(errors::kInvalidFilename, error.c_str()); |
| |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_Overwrite \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_Overwrite |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_Overwrite \ |
| DownloadExtensionTest_OnDeterminingFilename_Overwrite |
| #endif |
| // conflictAction may be specified without filename. |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_Overwrite) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| std::string error; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(), downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_EQ("", error); |
| |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| |
| // Start downloading a file. |
| result = RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str())); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| result_id = result->GetInt(); |
| item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller2(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| // Also test that DetermineFilename allows (chrome) extensions to set |
| // filenames without (filename) extensions. (Don't ask about v8 extensions or |
| // python extensions or kernel extensions or firefox extensions...) |
| error = ""; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(), downloads::FILENAME_CONFLICT_ACTION_OVERWRITE, &error)); |
| EXPECT_EQ("", error); |
| |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_Override \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_Override |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_Override \ |
| DownloadExtensionTest_OnDeterminingFilename_Override |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_Override) { |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| AddFilenameDeterminer(); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| std::string error; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(), downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, &error)); |
| EXPECT_EQ("", error); |
| |
| ASSERT_TRUE( |
| WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf("[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, GetFilename("slow.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| |
| // Start downloading a file. |
| result = RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str())); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| result_id = result->GetInt(); |
| item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller2(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| // Also test that DetermineFilename allows (chrome) extensions to set |
| // filenames without (filename) extensions. (Don't ask about v8 extensions or |
| // python extensions or kernel extensions or firefox extensions...) |
| error = ""; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), false, GetExtensionId(), result_id, |
| base::FilePath(FILE_PATH_LITERAL("foo")), |
| downloads::FILENAME_CONFLICT_ACTION_OVERWRITE, &error)); |
| EXPECT_EQ("", error); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, |
| GetFilename("foo").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // TODO test precedence rules: install_time |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_RemoveFilenameDeterminer \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_RemoveFilenameDeterminer |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_RemoveFilenameDeterminer \ |
| DownloadExtensionTest_OnDeterminingFilename_RemoveFilenameDeterminer |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_RemoveFilenameDeterminer) { |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| content::RenderProcessHost* host = AddFilenameDeterminer(); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Remove a determiner while waiting for it. |
| RemoveFilenameDeterminer(host); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // This test is flaky on Linux ASan LSan Tests bot. https://crbug.com/1114226 |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if ((BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)) && \ |
| defined(ADDRESS_SANITIZER)) || \ |
| BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_IncognitoSplit \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_IncognitoSplit |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_IncognitoSplit \ |
| DownloadExtensionTest_OnDeterminingFilename_IncognitoSplit |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_IncognitoSplit) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| GoOnTheRecord(); |
| AddFilenameDeterminer(); |
| |
| GoOffTheRecord(); |
| AddFilenameDeterminer(); |
| |
| // Start an on-record download. |
| GoOnTheRecord(); |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_FALSE(GetCurrentManager()->GetBrowserContext()->IsOffTheRecord()); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| // Wait for the onCreated and onDeterminingFilename events. |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"incognito\": false," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename events. |
| std::string error; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), |
| false, |
| GetExtensionId(), |
| result_id, |
| base::FilePath(FILE_PATH_LITERAL("42.txt")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, |
| &error)); |
| EXPECT_EQ("", error); |
| |
| // The download should complete successfully. |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, |
| GetFilename("42.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| |
| // Start an incognito download for comparison. |
| GoOffTheRecord(); |
| result = RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str())); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| result_id = result->GetInt(); |
| item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(GetCurrentManager()->GetBrowserContext()->IsOffTheRecord()); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller2(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": true," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| // On-Record renderers should not see events for off-record items. |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"incognito\": true," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| error = ""; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), |
| false, |
| GetExtensionId(), |
| result_id, |
| base::FilePath(FILE_PATH_LITERAL("5.txt")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, |
| &error)); |
| EXPECT_EQ("", error); |
| |
| // The download should complete successfully. |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, |
| GetFilename("5.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_IncognitoSpanning \ |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_IncognitoSpanning |
| #else |
| #define MAYBE_DownloadExtensionTest_OnDeterminingFilename_IncognitoSpanning \ |
| DownloadExtensionTest_OnDeterminingFilename_IncognitoSpanning |
| #endif |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_OnDeterminingFilename_IncognitoSpanning) { |
| LoadExtension("downloads_spanning"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| GoOnTheRecord(); |
| AddFilenameDeterminer(); |
| |
| // There is a single extension renderer that sees both on-record and |
| // off-record events. The extension functions see the on-record profile with |
| // include_incognito=true. |
| |
| // Start an on-record download. |
| GoOnTheRecord(); |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_FALSE(GetCurrentManager()->GetBrowserContext()->IsOffTheRecord()); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| // Wait for the onCreated and onDeterminingFilename events. |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"incognito\": false," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename events. |
| std::string error; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), |
| true, |
| GetExtensionId(), |
| result_id, |
| base::FilePath(FILE_PATH_LITERAL("42.txt")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, |
| &error)); |
| EXPECT_EQ("", error); |
| |
| // The download should complete successfully. |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, |
| GetFilename("42.txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| |
| // Start an incognito download for comparison. |
| GoOffTheRecord(); |
| result = RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str())); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| result_id = result->GetInt(); |
| item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(GetCurrentManager()->GetBrowserContext()->IsOffTheRecord()); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller2(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": true," |
| " \"id\": %d," |
| " \"mime\": \"text/plain\"," |
| " \"paused\": false," |
| " \"url\": \"%s\"}]", |
| result_id, |
| download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"incognito\": true," |
| " \"filename\":\"slow.txt\"}]", |
| result_id))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| // Respond to the onDeterminingFilename. |
| error = ""; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), |
| true, |
| GetExtensionId(), |
| result_id, |
| base::FilePath(FILE_PATH_LITERAL("42.txt")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, |
| &error)); |
| EXPECT_EQ("", error); |
| |
| // The download should complete successfully. |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| result_id, |
| GetFilename("42 (1).txt").c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| result_id))); |
| } |
| |
| // This test is very flaky on Win XP and Aura. http://crbug.com/248438 |
| // Also flaky on Linux. http://crbug.com/700382 |
| // Also flaky on Mac ASAN. |
| // Test download interruption while extensions determining filename. Should not |
| // re-dispatch onDeterminingFilename. |
| IN_PROC_BROWSER_TEST_F( |
| DownloadExtensionTest, |
| DISABLED_DownloadExtensionTest_OnDeterminingFilename_InterruptedResume) { |
| LoadExtension("downloads_split"); |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| GoOnTheRecord(); |
| content::RenderProcessHost* host = AddFilenameDeterminer(); |
| |
| // Start a download. |
| DownloadItem* item = NULL; |
| { |
| DownloadManager* manager = GetCurrentManager(); |
| std::unique_ptr<content::DownloadTestObserver> observer( |
| new JustInProgressDownloadObserver(manager, 1)); |
| ASSERT_EQ(0, manager->InProgressCount()); |
| ASSERT_EQ(0, manager->NonMaliciousInProgressCount()); |
| // Tabs created just for a download are automatically closed, invalidating |
| // the download's WebContents. Downloads without WebContents cannot be |
| // resumed. http://crbug.com/225901 |
| ui_test_utils::NavigateToURLWithDisposition( |
| current_browser(), |
| // This code used to use a mock class that no longer works, due to the |
| // NetworkService shipping. |
| // TODO(https://crbug.com/700382): Fix or delete this test. |
| GURL(), WindowOpenDisposition::CURRENT_TAB, |
| ui_test_utils::BROWSER_TEST_NONE); |
| observer->WaitForFinished(); |
| EXPECT_EQ(1u, observer->NumDownloadsSeenInState(DownloadItem::IN_PROGRESS)); |
| DownloadManager::DownloadVector items; |
| manager->GetAllDownloads(&items); |
| for (auto iter = items.begin(); iter != items.end(); ++iter) { |
| if ((*iter)->GetState() == DownloadItem::IN_PROGRESS) { |
| // There should be only one IN_PROGRESS item. |
| EXPECT_EQ(NULL, item); |
| item = *iter; |
| } |
| } |
| ASSERT_TRUE(item); |
| } |
| ScopedCancellingItem canceller(item); |
| |
| // Wait for the onCreated and onDeterminingFilename event. |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf( |
| "[{\"danger\": \"safe\"," |
| " \"incognito\": false," |
| " \"id\": %d," |
| " \"mime\": \"application/octet-stream\"," |
| " \"paused\": false}]", |
| item->GetId()))); |
| ASSERT_TRUE(WaitFor(downloads::OnDeterminingFilename::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"incognito\": false," |
| " \"filename\":\"download-unknown-size\"}]", |
| item->GetId()))); |
| ASSERT_TRUE(item->GetTargetFilePath().empty()); |
| ASSERT_EQ(DownloadItem::IN_PROGRESS, item->GetState()); |
| |
| ClearEvents(); |
| ui_test_utils::NavigateToURLWithDisposition( |
| current_browser(), |
| // This code used to use a mock class that no longer works, due to the |
| // NetworkService shipping. |
| // TODO(https://crbug.com/700382): Fix or delete this test. |
| GURL(), WindowOpenDisposition::NEW_BACKGROUND_TAB, |
| ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP); |
| |
| // Errors caught before filename determination are delayed until after |
| // filename determination. |
| std::string error; |
| ASSERT_TRUE(ExtensionDownloadsEventRouter::DetermineFilename( |
| current_browser()->profile(), |
| false, |
| GetExtensionId(), |
| item->GetId(), |
| base::FilePath(FILE_PATH_LITERAL("42.txt")), |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY, |
| &error)) |
| << error; |
| EXPECT_EQ("", error); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"filename\": {" |
| " \"previous\": \"\"," |
| " \"current\": \"%s\"}}]", |
| item->GetId(), |
| GetFilename("42.txt").c_str()))); |
| |
| content::DownloadUpdatedObserver interrupted( |
| item, base::BindRepeating(ItemIsInterrupted)); |
| ASSERT_TRUE(interrupted.WaitForEvent()); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"error\":{\"current\":\"NETWORK_FAILED\"}," |
| " \"state\":{" |
| " \"previous\":\"in_progress\"," |
| " \"current\":\"interrupted\"}}]", |
| item->GetId()))); |
| |
| ClearEvents(); |
| // Downloads that are restarted on resumption trigger another download target |
| // determination. |
| RemoveFilenameDeterminer(host); |
| item->Resume(true); |
| |
| // Errors caught before filename determination is complete are delayed until |
| // after filename determination so that, on resumption, filename determination |
| // does not need to be re-done. So, there will not be a second |
| // onDeterminingFilename event. |
| |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"error\":{\"previous\":\"NETWORK_FAILED\"}," |
| " \"state\":{" |
| " \"previous\":\"interrupted\"," |
| " \"current\":\"in_progress\"}}]", |
| item->GetId()))); |
| |
| ClearEvents(); |
| FinishFirstSlowDownloads(); |
| |
| // The download should complete successfully. |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d," |
| " \"state\": {" |
| " \"previous\": \"in_progress\"," |
| " \"current\": \"complete\"}}]", |
| item->GetId()))); |
| } |
| |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| DownloadExtensionTest_SetShelfEnabled) { |
| LoadExtension("downloads_split"); |
| EXPECT_TRUE(RunFunction(new DownloadsSetShelfEnabledFunction(), "[false]")); |
| EXPECT_FALSE(DownloadCoreServiceFactory::GetForBrowserContext( |
| current_browser()->profile()) |
| ->IsShelfEnabled()); |
| EXPECT_TRUE(RunFunction(new DownloadsSetShelfEnabledFunction(), "[true]")); |
| EXPECT_TRUE(DownloadCoreServiceFactory::GetForBrowserContext( |
| current_browser()->profile()) |
| ->IsShelfEnabled()); |
| // TODO(benjhayden) Test that existing shelves are hidden. |
| // TODO(benjhayden) Test multiple extensions. |
| // TODO(benjhayden) Test disabling extensions. |
| // TODO(benjhayden) Test that browsers associated with other profiles are not |
| // affected. |
| // TODO(benjhayden) Test incognito. |
| } |
| |
| // TODO(benjhayden) Figure out why DisableExtension() does not fire |
| // OnListenerRemoved. |
| |
| // TODO(benjhayden) Test that the shelf is shown for download() both with and |
| // without a WebContents. |
| |
| void OnDangerPromptCreated(DownloadDangerPrompt* prompt) { |
| prompt->InvokeActionForTesting(DownloadDangerPrompt::ACCEPT); |
| } |
| |
| #if BUILDFLAG(IS_MAC) && !defined(NDEBUG) |
| // Flaky on Mac debug, failing with a timeout. |
| // http://crbug.com/180759 |
| #define MAYBE_DownloadExtensionTest_AcceptDanger \ |
| DISABLED_DownloadExtensionTest_AcceptDanger |
| #else |
| #define MAYBE_DownloadExtensionTest_AcceptDanger \ |
| DownloadExtensionTest_AcceptDanger |
| #endif |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_AcceptDanger) { |
| // Download a file that will be marked dangerous; click the browser action |
| // button; the browser action poup will call acceptDanger(); when the |
| // DownloadDangerPrompt is created, pretend that the user clicks the Accept |
| // button; wait until the download completes. |
| LoadExtension("downloads_split"); |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| "[{\"url\": \"data:application/x-shockwave-flash,\", \"filename\": " |
| "\"dangerous.swf\"}]")); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf( |
| "[{\"id\": %d, " |
| " \"danger\": {" |
| " \"previous\": \"safe\"," |
| " \"current\": \"file\"}}]", |
| result_id))); |
| ASSERT_TRUE(item->IsDangerous()); |
| ScopedCancellingItem canceller(item); |
| std::unique_ptr<content::DownloadTestObserver> observer( |
| new content::DownloadTestObserverTerminal( |
| GetCurrentManager(), 1, |
| content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_IGNORE)); |
| DownloadsAcceptDangerFunction::OnPromptCreatedCallback callback = |
| base::BindOnce(&OnDangerPromptCreated); |
| DownloadsAcceptDangerFunction::OnPromptCreatedForTesting( |
| &callback); |
| ExtensionActionTestHelper::Create(current_browser())->Press(GetExtensionId()); |
| observer->WaitForFinished(); |
| } |
| |
| // TODO(https://crbug.com/1244128): Flaky on Win7 |
| #if BUILDFLAG(IS_WIN) |
| #define MAYBE_DownloadExtensionTest_DeleteFileAfterCompletion \ |
| DISABLED_DownloadExtensionTest_DeleteFileAfterCompletion |
| #else |
| #define MAYBE_DownloadExtensionTest_DeleteFileAfterCompletion \ |
| DownloadExtensionTest_DeleteFileAfterCompletion |
| #endif |
| // Test that file deletion event is correctly generated after download |
| // completion. |
| IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, |
| MAYBE_DownloadExtensionTest_DeleteFileAfterCompletion) { |
| ASSERT_TRUE(StartEmbeddedTestServer()); |
| GoOnTheRecord(); |
| LoadExtension("downloads_split"); |
| std::string download_url = embedded_test_server()->GetURL("/slow?0").spec(); |
| |
| // Start downloading a file. |
| std::unique_ptr<base::Value> result(RunFunctionAndReturnResult( |
| new DownloadsDownloadFunction(), |
| base::StringPrintf("[{\"url\": \"%s\"}]", download_url.c_str()))); |
| ASSERT_TRUE(result.get()); |
| ASSERT_TRUE(result->is_int()); |
| int result_id = result->GetInt(); |
| DownloadItem* item = GetCurrentManager()->GetDownload(result_id); |
| ASSERT_TRUE(item); |
| ScopedCancellingItem canceller(item); |
| ASSERT_EQ(download_url, item->GetOriginalUrl().spec()); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnCreated::kEventName, |
| base::StringPrintf(R"([{"danger": "safe",)" |
| R"( "incognito": false,)" |
| R"( "id": %d,)" |
| R"( "mime": "text/plain",)" |
| R"( "paused": false,)" |
| R"( "url": "%s"}])", |
| result_id, download_url.c_str()))); |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf(R"([{"id": %d,)" |
| R"( "state": {)" |
| R"( "previous": "in_progress",)" |
| R"( "current": "complete"}}])", |
| result_id))); |
| |
| item->DeleteFile(base::BindOnce(OnFileDeleted)); |
| |
| ASSERT_TRUE(WaitFor(downloads::OnChanged::kEventName, |
| base::StringPrintf(R"([{"id": %d,)" |
| R"( "exists": {)" |
| R"( "previous": true,)" |
| R"( "current": false}}])", |
| result_id))); |
| } |
| |
| class DownloadsApiTest : public ExtensionApiTest { |
| public: |
| DownloadsApiTest() {} |
| |
| DownloadsApiTest(const DownloadsApiTest&) = delete; |
| DownloadsApiTest& operator=(const DownloadsApiTest&) = delete; |
| |
| ~DownloadsApiTest() override {} |
| }; |
| |
| |
| IN_PROC_BROWSER_TEST_F(DownloadsApiTest, DownloadsApiTest) { |
| ASSERT_TRUE(RunExtensionTest("downloads")) << message_; |
| } |
| |
| TEST(DownloadInterruptReasonEnumsSynced, |
| DownloadInterruptReasonEnumsSynced) { |
| #define INTERRUPT_REASON(name, value) \ |
| EXPECT_EQ(InterruptReasonContentToExtension( \ |
| download::DOWNLOAD_INTERRUPT_REASON_##name), \ |
| downloads::INTERRUPT_REASON_##name); \ |
| EXPECT_EQ( \ |
| InterruptReasonExtensionToComponent(downloads::INTERRUPT_REASON_##name), \ |
| download::DOWNLOAD_INTERRUPT_REASON_##name); |
| #include "build/chromeos_buildflags.h" |
| #include "components/download/public/common/download_interrupt_reason_values.h" |
| #undef INTERRUPT_REASON |
| } |
| |
| TEST(ExtensionDetermineDownloadFilenameInternal, |
| ExtensionDetermineDownloadFilenameInternal) { |
| std::string winner_id; |
| base::FilePath filename; |
| downloads::FilenameConflictAction conflict_action = |
| downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY; |
| WarningSet warnings; |
| |
| // Empty incumbent determiner |
| warnings.clear(); |
| ExtensionDownloadsEventRouter::DetermineFilenameInternal( |
| base::FilePath(FILE_PATH_LITERAL("a")), |
| downloads::FILENAME_CONFLICT_ACTION_OVERWRITE, |
| "suggester", |
| base::Time::Now(), |
| "", |
| base::Time(), |
| &winner_id, |
| &filename, |
| &conflict_action, |
| &warnings); |
| EXPECT_EQ("suggester", winner_id); |
| EXPECT_EQ(FILE_PATH_LITERAL("a"), filename.value()); |
| EXPECT_EQ(downloads::FILENAME_CONFLICT_ACTION_OVERWRITE, conflict_action); |
| EXPECT_TRUE(warnings.empty()); |
| |
| // Incumbent wins |
| warnings.clear(); |
| ExtensionDownloadsEventRouter::DetermineFilenameInternal( |
| base::FilePath(FILE_PATH_LITERAL("b")), |
| downloads::FILENAME_CONFLICT_ACTION_PROMPT, "suggester", |
| base::Time::Now() - base::Days(1), "incumbent", base::Time::Now(), |
| &winner_id, &filename, &conflict_action, &warnings); |
| EXPECT_EQ("incumbent", winner_id); |
| EXPECT_EQ(FILE_PATH_LITERAL("a"), filename.value()); |
| EXPECT_EQ(downloads::FILENAME_CONFLICT_ACTION_OVERWRITE, conflict_action); |
| EXPECT_FALSE(warnings.empty()); |
| EXPECT_EQ(Warning::kDownloadFilenameConflict, |
| warnings.begin()->warning_type()); |
| EXPECT_EQ("suggester", warnings.begin()->extension_id()); |
| |
| // Suggester wins |
| warnings.clear(); |
| ExtensionDownloadsEventRouter::DetermineFilenameInternal( |
| base::FilePath(FILE_PATH_LITERAL("b")), |
| downloads::FILENAME_CONFLICT_ACTION_PROMPT, "suggester", |
| base::Time::Now(), "incumbent", base::Time::Now() - base::Days(1), |
| &winner_id, &filename, &conflict_action, &warnings); |
| EXPECT_EQ("suggester", winner_id); |
| EXPECT_EQ(FILE_PATH_LITERAL("b"), filename.value()); |
| EXPECT_EQ(downloads::FILENAME_CONFLICT_ACTION_PROMPT, conflict_action); |
| EXPECT_FALSE(warnings.empty()); |
| EXPECT_EQ(Warning::kDownloadFilenameConflict, |
| warnings.begin()->warning_type()); |
| EXPECT_EQ("incumbent", warnings.begin()->extension_id()); |
| } |
| |
| } // namespace extensions |