| commit | 46996b6805f952ea79b1bca6cdd5f75c062a1b0e | [log] [tgz] |
|---|---|---|
| author | Paul Adedeji <pauladedeji@google.com> | Mon Mar 11 19:52:28 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 11 19:52:28 2024 |
| tree | e30dcfda346c7f425e3ec0d93133d65db70473af | |
| parent | 6d60691a8b7152949a45cb6e2174ce6c9c8c5746 [diff] |
[M123] Toggle NTP Wallpaper Search button w/ Wallpaper Search setting 1. Toggles visibility of NTP Wallpaper Search button whenever its setting is changed. *video demo in bug comments We add SettingsEnabledObserver [1] to new_tab_page_handler.cc, and communicate changes to settings via Mojo to the renderer. 2. Restructures wallpaper_search_interactive_uitest.cc into two test suites. *The only "new" test is |NTPWallpaperSearchButtonVisibilityDependsOnSettings|. Setting changes are not observed if MockOptimizationGuideKeyedService is being used [2], so we create a separate suite for tests that rely on MockOptimizationGuideKeyedService. [1]https://source.chromium.org/chromium/chromium/src/+/main:components/optimization_guide/core/model_execution/settings_enabled_observer.h [2]https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/optimization_guide/optimization_guide_keyed_service.cc;drc=7484b91192bc20728f4c653f258694f72ba7c572;l=282 (cherry picked from commit 9387cff6b5e90fad3b7c1598ce224b8c7cf8f547) Change-Id: If509a7b4c614741f4eddb87a132d05aa11dc29f2 Bug: 328085545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5345524 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Paul Adedeji <pauladedeji@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1269015} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5361535 Auto-Submit: Paul Adedeji <pauladedeji@google.com> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/branch-heads/6312@{#522} Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.