| commit | 59ac8227c5dd59754331b3f7f9f85e1a947f1242 | [log] [tgz] |
|---|---|---|
| author | Arthur Sonzogni <arthursonzogni@chromium.org> | Fri Nov 10 09:46:54 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 10 09:46:54 2023 |
| tree | db4a770af7773f7a2ec19c186f932a9020c9dec5 | |
| parent | ab9bd16e5d42893cbe1bbb0a87ea2d5173d1e36d [diff] |
Rename {absl => std}::optional in minor top-level dirs
Automated patch, intended to be effectively a no-op.
This patch gather the changes for every top-level directories with less
than 150 files modified:
# directory
--- ---------------
150 remoting
98 gpu
87 chromecast
79 mojo
70 storage
65 fuchsia_web
46 sandbox
44 android_webview
38 google_apis
27 pdf
25 printing
20 headless
13 ipc
11 crypto
10 sql
3 dbus
2 testing
2 skia
2 gin
2 apps
1 rlz
1 codelabs
Context:
https://groups.google.com/a/chromium.org/g/cxx/c/nBD_1LaanTc/m/ghh-ZZhWAwAJ?utm_medium=email&utm_source=footer
As of https://crrev.com/1204351, absl::optional is now a type alias for
std::optional. We should migrate toward it.
Script:
```
function replace {
echo "Replacing $1 by $2"
git grep -l "$1" \
| cut -f1 -d: \
| grep \
-e "^codelabs" \
-e "^rlz" \
-e "^apps" \
-e "^gin" \
-e "^skia" \
-e "^testing" \
-e "^dbus" \
-e "^sql" \
-e "^crypto" \
-e "^ipc" \
-e "^headless" \
-e "^printing" \
-e "^pdf" \
-e "^google_apis" \
-e "^android_webview" \
-e "^sandbox" \
-e "^fuchsia_web" \
-e "^storage" \
-e "^mojo" \
-e "^chromecast" \
-e "^gpu" \
-e "^remoting" \
| sort \
| uniq \
| grep \
-e "\.h" \
-e "\.cc" \
-e "\.mm" \
-e "\.py" \
| xargs sed -i "s/$1/$2/g"
}
replace "absl::make_optional" "std::make_optional"
replace "absl::optional" "std::optional"
replace "absl::nullopt" "std::nullopt"
replace "absl::in_place" "std::in_place"
replace "absl::in_place_t" "std::in_place_t"
replace "\"third_party\/abseil-cpp\/absl\/types\/optional.h\"" "<optional>"
git cl format
```
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
Bug: chromium:1500249
Change-Id: I0eca8ff96f5712ba746ac8d8da93d03a86d8292c
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5009410
Reviewed-by: danakj <danakj@chromium.org>
Owners-Override: danakj <danakj@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1222826}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.