commit | 59de2a5281526bdd3380d2449b46c92ed9ce34f3 | [log] [tgz] |
---|---|---|
author | sbingler <bingler@chromium.org> | Thu Feb 01 16:56:20 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Feb 01 16:56:20 2024 |
tree | 5e1aa353da10c5041453cc1438171a50d6fd0da3 | |
parent | e1678d4bbdc0c9518c427b1d276188d18646c654 [diff] |
Rename CanonicalCookie::IsSecure to SecureAttribute CanonicalCookie::IsSecure() is a simple getter that returns if a cookie's "Secure" attribute was set or not. I.e.: Set-Cookie: "foo=bar; Secure" With the introduction of "source_scheme" a cookie could also be considered secure if their setting scheme was secure. To try and help reduce potential confusion this CL renames IsSecure() to SecureAttribute() to hopefully indicate that this is a getter and not a function which is trying to answer the question "was this cookie created in a secure context?". This CL is a simple renaming and does not change any logic. Bug: 1170548 Change-Id: I01141da043604e793eed2277fe28b4bb8ff58bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5245913 Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255100}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.