[go: nahoru, domu]

[OOPIF PDF] Fix presentation mode not working correctly

Fix presentation mode failing to work by changing the PDF outer <embed>
to an <iframe>. Give the iframe the 'allow' attribute and allow
fullscreen for all origins so that the PDF extension in the iframe can
use Element.requestFullscreen().

The web spec for Element.requestFullscreen() requires that the element
requesting fullscreen must be in the top-level document or in an
<iframe> with the 'allow' attribute allowing fullscreen. The element
requesting fullscreen resides in the PDF extension.

In GuestView PDF viewer, the PDF extension is in the top-level document
of the inner WebContents, so the element is allowed to fullscreen.

In OOPIF PDF viewer, the PDF extension is no longer in the top-level
document. This CL uses the other <iframe> requirement to allow
fullscreen.

The <embed> used to be an <iframe>, but was changed in
https://crrev.com/659508. After https://crrev.com/1257705, OOPIF tests
don't need the element to be an <embed> anymore.

Bug: 41495166
Change-Id: I4031c782f24e7f3656c430767f2a6e67ba8d01b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5269765
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1262032}
2 files changed
tree: 6f06e94fd844f2bf5b847dd6b2a03af95e263c7c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.