commit | 917ce177502eb0e3fd5ca37aefc31ecafa35d719 | [log] [tgz] |
---|---|---|
author | Joao Victor Almeida <joalmei@microsoft.com> | Tue Jul 07 20:56:12 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jul 07 20:56:12 2020 |
tree | 2b52a355ec535a532795636bbd15f1f088cc0e40 | |
parent | ae21c927bc06224a045de7353cf6ca2a78772a6a [diff] |
Decouple AverageLagTracker and LatencyInfo. Moving the event collection to LayerTreeHostImpl is an initial step towards a new version of the AverageLag metrics using PresentationFeedback times instead of GpuSwap times, which are available through LayerTreeHostImpl. Moving them from LatencyTracker is also interesting as it aggregates events across all viz clients at the end of the GPU pipeline, which can potentially mix up events from multiple sources. Tracking events by viz client (through LayerTreeHostImpl) avoids it. As AverageLagTracker should be dedicated to Telemetry, it is interesting to remove all LatencyInfo preprocessing from it, as LatencyInfo stores a lot of information that is irrelevant to AverageLagTracker. This CL proposes to move the scroll events collection from LatencyTracker to LayerTreeHostImpl. It also proposes an AverageLagTrackingManager, an intermediary class for using AverageLagTracker that preprocesses LatencyInfo objects so AverageLagTracker can be independent from it. As the event collection is moved to LayerTreeHostImpl, the AverageLagTrackingManager also serves to encapsulate any preprocessing from LayerTreeHostImpl and AverageLagTrakcer. Bug: 1079024, 989207 Change-Id: I2e73e244eee9565239a638f00dfbf19d5658eadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189633 Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#785975}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.