George Burgess IV | 1fdfdeb | 2019-10-24 18:53:29 | [diff] [blame] | 1 | --- |
George Burgess IV | f828a224 | 2022-04-19 19:30:15 | [diff] [blame] | 2 | # TODO(crbug.com/1282228): reenable google-readability-casting once it no |
| 3 | # longer has as many false-positives. |
George Burgess IV | 1fdfdeb | 2019-10-24 18:53:29 | [diff] [blame] | 4 | Checks: '-*, |
Tal Pressman | 89a0e82 | 2020-12-01 09:01:39 | [diff] [blame] | 5 | bugprone-argument-comment, |
George Burgess IV | 9f7338f | 2022-03-17 19:28:57 | [diff] [blame] | 6 | bugprone-assert-side-effect, |
Miyoung Shin | a288609 | 2024-01-11 02:40:20 | [diff] [blame] | 7 | bugprone-bool-pointer-implicit-conversion, |
Jan Wilken Dörrie | 9414992 | 2020-12-15 18:44:55 | [diff] [blame] | 8 | bugprone-dangling-handle, |
Miyoung Shin | fa728e68 | 2024-03-02 08:27:50 | [diff] [blame] | 9 | bugprone-forward-declaration-namespace, |
Jan Wilken Dörrie | 9414992 | 2020-12-15 18:44:55 | [diff] [blame] | 10 | bugprone-inaccurate-erase, |
| 11 | bugprone-string-constructor, |
George Burgess IV | 37c32865 | 2020-10-01 19:40:18 | [diff] [blame] | 12 | bugprone-string-integer-assignment, |
Daniel Cheng | 387e323 | 2022-11-25 19:43:56 | [diff] [blame] | 13 | bugprone-undefined-memory-manipulation, |
Julie Jeongeun Kim | cf7829b | 2024-01-04 03:12:24 | [diff] [blame] | 14 | bugprone-unique-ptr-array-mismatch, |
George Burgess IV | 37c32865 | 2020-10-01 19:40:18 | [diff] [blame] | 15 | bugprone-unused-raii, |
Maksim Ivanov | d8f65ed | 2020-08-29 03:28:21 | [diff] [blame] | 16 | bugprone-use-after-move, |
Julie Jeongeun Kim | 2fe67fc | 2024-01-19 13:41:43 | [diff] [blame] | 17 | bugprone-virtual-near-miss, |
George Burgess IV | 0cea06c | 2020-01-14 03:31:04 | [diff] [blame] | 18 | google-build-explicit-make-pair, |
Julie Jeongeun Kim | de7ae67 | 2024-01-04 02:10:06 | [diff] [blame] | 19 | google-default-arguments, |
George Burgess IV | 0cea06c | 2020-01-14 03:31:04 | [diff] [blame] | 20 | google-explicit-constructor, |
Avi Drissman | 5207f8d | 2023-12-26 20:08:26 | [diff] [blame] | 21 | google-objc-avoid-nsobject-new, |
Julie Jeongeun Kim | 2679bc7 | 2024-01-24 08:23:43 | [diff] [blame] | 22 | google-upgrade-googletest-case, |
Ryan Beltran | d4f38b67 | 2023-01-18 23:00:53 | [diff] [blame] | 23 | misc-misleading-identifier, |
| 24 | misc-homoglyph, |
George Burgess IV | d4c5e82a | 2020-05-19 19:24:00 | [diff] [blame] | 25 | modernize-avoid-bind, |
Avi Drissman | efca412 | 2022-01-05 23:59:36 | [diff] [blame] | 26 | modernize-concat-nested-namespaces, |
George Burgess IV | 0cea06c | 2020-01-14 03:31:04 | [diff] [blame] | 27 | modernize-loop-convert, |
| 28 | modernize-make-shared, |
George Burgess IV | d4c5e82a | 2020-05-19 19:24:00 | [diff] [blame] | 29 | modernize-make-unique, |
George Burgess IV | 1fdfdeb | 2019-10-24 18:53:29 | [diff] [blame] | 30 | modernize-redundant-void-arg, |
| 31 | modernize-replace-random-shuffle, |
| 32 | modernize-shrink-to-fit, |
| 33 | modernize-use-bool-literals, |
George Burgess IV | f3f6a55 | 2023-11-13 18:03:12 | [diff] [blame] | 34 | modernize-use-default-member-init, |
George Burgess IV | d4c5e82a | 2020-05-19 19:24:00 | [diff] [blame] | 35 | modernize-use-emplace, |
George Burgess IV | 1fdfdeb | 2019-10-24 18:53:29 | [diff] [blame] | 36 | modernize-use-equals-default, |
| 37 | modernize-use-equals-delete, |
George Burgess IV | d4c5e82a | 2020-05-19 19:24:00 | [diff] [blame] | 38 | modernize-use-noexcept, |
George Burgess IV | 1fdfdeb | 2019-10-24 18:53:29 | [diff] [blame] | 39 | modernize-use-nullptr, |
| 40 | modernize-use-override, |
George Burgess IV | 0cea06c | 2020-01-14 03:31:04 | [diff] [blame] | 41 | modernize-use-transparent-functors, |
| 42 | readability-redundant-member-init' |
George Burgess IV | d4c5e82a | 2020-05-19 19:24:00 | [diff] [blame] | 43 | CheckOptions: |
George Burgess IV | 9f7338f | 2022-03-17 19:28:57 | [diff] [blame] | 44 | - key: bugprone-assert-side-effect.AssertMacros |
| 45 | value: assert,DCHECK |
Jan Wilken Dörrie | 9414992 | 2020-12-15 18:44:55 | [diff] [blame] | 46 | - key: bugprone-dangling-handle.HandleClasses |
Peter Boström | 25a5358 | 2021-08-31 04:28:35 | [diff] [blame] | 47 | value: ::std::basic_string_view;::std::span;::absl::string_view;::base::BasicStringPiece;::base::span |
Jan Wilken Dörrie | 9414992 | 2020-12-15 18:44:55 | [diff] [blame] | 48 | - key: bugprone-string-constructor.StringNames |
George Burgess IV | 4f18f3f | 2022-07-05 14:24:57 | [diff] [blame] | 49 | value: ::std::basic_string;::std::basic_string_view;::base::BasicStringPiece;::absl::string_view |
Peter Kasting | 0dc3348 | 2020-10-19 01:48:29 | [diff] [blame] | 50 | - key: modernize-use-default-member-init.UseAssignment |
| 51 | value: 1 |
George Burgess IV | a01425e4 | 2022-07-14 02:00:58 | [diff] [blame] | 52 | # crbug.com/1342136, crbug.com/1343915: At times, this check makes |
| 53 | # suggestions that break builds. Safe mode allows us to sidestep that. |
| 54 | - key: modernize-use-transparent-functors.SafeMode |
| 55 | value: 1 |
George Burgess IV | d4c5e82a | 2020-05-19 19:24:00 | [diff] [blame] | 56 | # This relaxes modernize-use-emplace in some cases; we might want to make it |
| 57 | # more aggressive in the future. See discussion on |
| 58 | # https://groups.google.com/a/chromium.org/g/cxx/c/noMMTNYiM0w . |
| 59 | - key: modernize-use-emplace.IgnoreImplicitConstructors |
| 60 | value: 1 |
John Admanski | b364528 | 2024-02-21 19:57:49 | [diff] [blame] | 61 | # Use of `std::ranges::reverse_view` is inconsistent with |
| 62 | # Chromium style. Recommend `base::Reversed` instead. |
| 63 | - key: modernize-loop-convert.MakeReverseRangeFunction |
| 64 | value: base::Reversed |
| 65 | - key: modernize-loop-convert.MakeReverseRangeHeader |
| 66 | value: base/containers/adapters.h |
Takuto Ikuta | 6d781e1 | 2024-04-26 11:52:03 | [diff] [blame] | 67 | # Exclude some third_party headers from modification as file paths are not |
| 68 | # starting from repository root in replacement suggestion. |
Takuto Ikuta | 2d6a4db8 | 2024-05-13 04:51:34 | [diff] [blame] | 69 | # 'build/linux/debian' excludes system headers as they don't have |
| 70 | # appropriate IWYU pragmas. |
Takuto Ikuta | 6d781e1 | 2024-04-26 11:52:03 | [diff] [blame] | 71 | # https://clang.llvm.org/extra/clang-tidy/checks/misc/include-cleaner.html |
| 72 | - key: misc-include-cleaner.IgnoreHeaders |
Takuto Ikuta | 2d6a4db8 | 2024-05-13 04:51:34 | [diff] [blame] | 73 | value: (gmock/gmock|gtest/gtest|third_party|build/linux/debian).* |
George Burgess IV | 1fdfdeb | 2019-10-24 18:53:29 | [diff] [blame] | 74 | ... |