[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/download file bug #119

Merged
merged 12 commits into from
Apr 16, 2023
Merged

Fix/download file bug #119

merged 12 commits into from
Apr 16, 2023

Conversation

DanielZhangReal
Copy link
Contributor
@DanielZhangReal DanielZhangReal commented Apr 15, 2023 •
edited
Loading
  • Fix private-transfer.lfs file download failure in Manta Wallet
  • Add HttpProvider
  • Fix the error that the download failed on Ledger api @zqhxuyuan

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate L- label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

@DanielZhangReal DanielZhangReal added L-fixed fixed Changelog: add these changes to the `fixed` section of the changelog L-added Changelog: add these changes to the `added` section of the changelog labels Apr 15, 2023
@DanielZhangReal DanielZhangReal marked this pull request as ready for review April 15, 2023 06:08
Apokalip
Apokalip previously approved these changes Apr 15, 2023
View reviewed changes
ferrell-code
ferrell-code reviewed Apr 15, 2023
View reviewed changes
Copy link
Contributor
@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment looks good

manta-js/examples/extension-example/src/App.tsx Show resolved Hide resolved
@Apokalip Apokalip self-requested a review April 15, 2023 21:34
@DanielZhangReal DanielZhangReal merged commit f3dbd4f into signer_extension Apr 16, 2023
@DanielZhangReal DanielZhangReal deleted the fix/download-file-bug branch April 16, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apokalip Apokalip Apokalip approved these changes

@ferrell-code ferrell-code ferrell-code approved these changes

@SupremoUGH SupremoUGH Awaiting requested review from SupremoUGH

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

@ghzlatarev ghzlatarev Awaiting requested review from ghzlatarev

Assignees
No one assigned
Labels
L-added Changelog: add these changes to the `added` section of the changelog L-fixed fixed Changelog: add these changes to the `fixed` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DanielZhangReal @Apokalip @ferrell-code @zqhxuyuan