Add support for 1.20.5 servers #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xism4
approved these changes
Apr 24, 2024
|
Tested and looks good to me 👍🏻 |
|
LGTM, just waiting for a Paper 1.20.5 build for testing on Paper before release |
I should have stated... my picture there was tested on paper. |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ClientboundSetScorePacketandClientboundSetObjectivePacketclasses now useOptionalinstead ofnull.This PR uses the fact that the
setFieldmethod will silently fail if there is no field with this type.Tested on a fresh Spigot 1.20.5 build, and on Paper 1.20.4.