This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
optimize extract_unaligned_uint128 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e32466
to
11fad77
Compare
Profiling `BaseJumpRateModelV2.utilizationRate` has shown that ~37% of
steps are spent inside of `extract_unaligned_uint128`, in
particular uint256 multiplication. We remove uint256 operations
and instead use bitwise operations and masks to perform the
extraction. It results in almost universal ~25-30% reduction in
the number of steps.
11fad77
to
9faee9e
Compare
swapnilraj
reviewed
Dec 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling
BaseJumpRateModelV2.utilizationRatehas shown that ~37% ofsteps are spent inside of
extract_unaligned_uint128, inparticular uint256 multiplication. We remove uint256 operations
and instead use bitwise operations and masks to perform the
extraction. It results in almost universal ~25-30% reduction in
the number of steps.