-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement more features in Brian2 #48
Conversation
Changed equations and methods in brian2 backend to implement: *Reset by subtraction *Non-Poisson (constant current injection) input layer *Neuron biases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this is a fantastic contribution and very valuable to the community. Thank you for sharing. I just have a few comments / questions, then I'm happy to release this.
Removed unnecessary parenthesis
Refactored 'current' variable to 'bias' (matches convention of package better)
Changed generic AttributeError to assertion
Removed convolution weight permutation code for flatten layers - negatively impacted performance.
required for newer TF/keras versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, all settled then! Thanks again.
Changed equations and methods in brian2 backend to implement:
*Reset by subtraction
*Non-Poisson (constant current injection) input layer
*Neuron biases