[go: nahoru, domu]

Skip to content

Commit

Permalink
chromium: don't use pkgsBuildTarget
Browse files Browse the repository at this point in the history
I'm pretty sure this was a mistake — in Nixpkgs the target platform is
the platform that the program being built should output executables
for — i.e., it's only relevant for a compiler, which Chromium is not.

Tested that cross-compilation of Electron still works.
  • Loading branch information
alyssais committed Jun 10, 2024
1 parent 3df6bb2 commit a269b98
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions pkgs/applications/networking/browsers/chromium/common.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
, buildPackages
, buildPlatform
, pkgsBuildBuild
, pkgsBuildTarget
# Channel data:
, channel, upstream-info
# Helper functions:
Expand Down Expand Up @@ -382,8 +381,8 @@ let
llvmCcAndBintools = symlinkJoin {
name = "llvmCcAndBintools";
paths = [
pkgsBuildTarget.${llvmPackages_attrName}.llvm
pkgsBuildTarget.${llvmPackages_attrName}.stdenv.cc
buildPackages.${llvmPackages_attrName}.llvm
buildPackages.${llvmPackages_attrName}.stdenv.cc
];
};

Expand Down

0 comments on commit a269b98

Please sign in to comment.