[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.materialyoucolor: init at 2.0.9 #318929

Merged
merged 1 commit into from
Jul 10, 2024
Merged

python312Packages.materialyoucolor: init at 2.0.9 #318929

merged 1 commit into from
Jul 10, 2024

Conversation

TomaSajt
Copy link
Contributor

Description of changes

Closes #318557

This PR adds the materialyoucolor python package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Moraxyc
Copy link
Contributor
Moraxyc commented Jun 12, 2024

Result of nixpkgs-review pr 318929 run on x86_64-linux 1

4 packages built:
  • python311Packages.materialyoucolor
  • python311Packages.materialyoucolor.dist
  • python312Packages.materialyoucolor
  • python312Packages.materialyoucolor.dist

Moraxyc
Moraxyc approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor
@Moraxyc Moraxyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@lVentus
Copy link
lVentus commented Jun 22, 2024

when can we merge it?

@lVentus
Copy link
lVentus commented Jul 8, 2024

Hello? Anyone? @wegank

@wegank wegank requested a review from natsukium as a code owner July 10, 2024 11:29
@natsukium
Copy link
Member

Result of nixpkgs-review pr 318929 at 4b19fe2 run on aarch64-darwin 1

2 packages built successfully:
  • python311Packages.materialyoucolor
  • python312Packages.materialyoucolor

natsukium
natsukium approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member
@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit c94583e into NixOS:master Jul 10, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lVentus lVentus lVentus left review comments

@wegank wegank wegank approved these changes

@natsukium natsukium natsukium approved these changes

@WoLeo-Z WoLeo-Z WoLeo-Z approved these changes

@Moraxyc Moraxyc Moraxyc approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: materialyoucolor-python
6 participants
@TomaSajt @Moraxyc @lVentus @natsukium @wegank @WoLeo-Z