[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.render-markdown: init at 2024-07-07 #325112

Merged
merged 1 commit into from
Jul 10, 2024
Merged

vimPlugins.render-markdown: init at 2024-07-07 #325112

merged 1 commit into from
Jul 10, 2024

Conversation

linsui
Copy link
Contributor
@linsui linsui commented Jul 6, 2024

Description of changes

Close #322117

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@linsui linsui requested a review from figsoda as a code owner July 6, 2024 19:51
@linsui linsui requested review from teto and GaetanLepage July 8, 2024 17:44
@GaetanLepage
Copy link
Contributor

Is there a reason to change the name of this plugin from markdown-nvim to render-markdown ?
Usually, we try to stick to upstream's name.

@linsui
Copy link
Contributor Author
linsui commented Jul 9, 2024

We already have a plugin named markdown.nvim so I use the name suggested in https://github.com/MeanderingProgrammer/markdown.nvim/?tab=readme-ov-file#lazynvim.

@GaetanLepage
Copy link
Contributor

We already have a plugin named markdown.nvim so I use the name suggested in https://github.com/MeanderingProgrammer/markdown.nvim/?tab=readme-ov-file#lazynvim.

Oh, OK.
@teto are you OK with this change ? Would you have it named differently ?

@teto
Copy link
Member
teto commented Jul 10, 2024

We already have a plugin named markdown.nvim so I use the name suggested in https://github.com/MeanderingProgrammer/markdown.nvim/?tab=readme-ov-file#lazynvim.

Thanks for the pointer. render-markdown makes sense and I am fine with using that for nixpkgs.
I would also suggest to the plugin author to rename his plugin to just that. Would make packaging simpler down the line (putting it on www.luarocks.org for instance). Or renaming it to nvim-markdown.

@linsui
Copy link
Contributor Author
linsui commented Jul 10, 2024

I would also suggest to the plugin author to rename his plugin to just that. Would make packaging simpler down the line (putting it on www.luarocks.org for instance). Or renaming it to nvim-markdown

Given that the author is aware this problem maybe they just like this name...

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 325112 run on x86_64-linux 1

1 package built:
  • vimPlugins.render-markdown

@GaetanLepage GaetanLepage merged commit 8b0eb0b into NixOS:master Jul 10, 2024
31 checks passed
@linsui linsui deleted the markdown branch July 10, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@figsoda figsoda Awaiting requested review from figsoda figsoda is a code owner

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: vimPlugins.render-markdown-nvim
3 participants
@linsui @GaetanLepage @teto