feat: support for normalize japanese hiragana and katakana title #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
added 2 commits
February 14, 2023 13:10
# Conflicts: # packages/notion-utils/src/normalize-title.ts
transitive-bullshit
approved these changes
Feb 14, 2023
|
Thanks @mosugi 🙏 |
chuyun
pushed a commit
to chuyun/react-notion-x
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I love using react-notion-x on my blog. Thanks again.
I would like to add Japanese hiragana and katakana to solve the problem similar to #176.
Japanese is written in a mixture of kanji, hiragana and katakana.
Example: https://jsfiddle.net/uw5m9kts/6/
In RFC-1738, It basically supports us-ascii sets, browsers will encode japanese charaters automatically too.