feat(add support for private Notion page assets) #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traverses a page's blocks (for `collection_view` support) to generate Signed URLs for images. Also expands `defaultMapImageUrl` to support lookups for UGC (user-generated content) on Page Covers and Page Icons. (Which will follow a form similar to `https://notion.so/<UUID>/<filename>.<ext>`. Since the OG implementation maps these assets to `block.id`, which refers to the Page, only one of Cover / Icon were allowed to be UGC.)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@transitive-bullshit Since you refactored the |
|
@transitive-bullshit A friendly ping about this. 🙂 Anything I can do to speed things along? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Traverses a page's blocks (for
collection_viewsupport) to generate Signed URLs for images. Also expandsdefaultMapImageUrlto support lookups for UGC (user-generated content) on Page Covers and Page Icons. (Which will follow a form similar tohttps://notion.so/<UUID>/<filename>.<ext>. Since the OG implementation maps these assets toblock.id, which refers to the Page, only one of Cover / Icon were allowed to be UGC.)Notion Test Page ID
I used the shipped examples in
examples/full, so067dd719a912471ea9a3ac10710e7fdf.This is intended to work on private pages and didn't appear to alter public pages.
Note: It seems that image loading is slower from AWS now. But, I believe this is due to one of the GIFs on my test page being ~30MB. 😅