Refactored EK80 data XML parser and also removed the usage of dict_to_dict method
#1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8e24f2
to
a8bc113
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1186 +/- ##
==========================================
- Coverage 81.89% 77.01% -4.88%
==========================================
Files 67 19 -48
Lines 5887 3059 -2828
==========================================
- Hits 4821 2356 -2465
+ Misses 1066 703 -363
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 49 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
30272ee
to
ea66098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #468 by improving parsing for EK80 XML data and also removed the usage of
dict_to_dictmethod, also Fixes #1184 and now 'PingSequence' XML datagram is parsed and stored in the output ofopen_raw.CC @leewujung @emiliom