chromium: Add UPower to RDPENDS #502
Conversation
|
Note: I looked at Gentoo: should this be a rrecommends then? |
| RDEPENDS_${PN} = "bash" | ||
| RDEPENDS_${PN} = " \ | ||
| bash \ | ||
| upower \ |
There was a problem hiding this comment.
I'd add it using a PACKAGECONFIG so people can choose to add it or not.
There was a problem hiding this comment.
@otavio should it really be that optional? If UPower is not present, there's at least one Web API that will not work as expected. Is UPower not commonly shipped in embedded systems/is it too big?
There was a problem hiding this comment.
If the application runs without it, it is optional. As suggested below, I think it should be enabled by default.
|
Any updates on the review? |
4973f32
to
8dbe25b
Compare
Chromium uses D-Bus to communicate with UPower.
It uses it to query battery status among many things.
see:
services/device/battery/battery_status_manager_linux.cc
Fixes error/warning messages related to UPower:
```
Failed to call method: org.freedesktop.UPower.GetDisplayDevice
The name org.freedesktop.UPower was not provided by any .service files
```
Signed-off-by: Yi Fan Yu <yifan.yu@windriver.com>
Chromium uses D-Bus to communicate with UPower.
It uses it to query battery among many things.
see:
services/device/battery/battery_status_manager_linux.cc
Fixes error/warning messages related to UPower:
Signed-off-by: Yi Fan Yu yifan.yu@windriver.com