firefox: Fix host library contamination on x86_64 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On x86_64 build system starts to poke into build system libraries and its especially seen with glibc 2.26 since it has deprecated certain symbols which are not available in libc e.g. /usr/lib/libresolv.so.2: undefined reference to `__res_maybe_init@GLIBC_PRIVATE' collect2: error: ld returned 1 exit status So its linking to libresolv.so from host system is clear due to this error because its then using libc.so from cross build which is glibc 2.26 and doesnt have that symbol. Explicilty specify -lresolv on linker cmdline for components where its needed. Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On x86_64 build system starts to poke into build system libraries
and its especially seen with glibc 2.26 since it has deprecated
certain symbols which are not available in libc
e.g.
/usr/lib/libresolv.so.2: undefined reference to `__res_maybe_init@GLIBC_PRIVATE'
collect2: error: ld returned 1 exit status
So its linking to libresolv.so from host system is clear due to this error
because its then using libc.so from cross build which is glibc 2.26
and doesnt have that symbol.
Explicilty specify -lresolv on linker cmdline for components where its
needed.
Signed-off-by: Khem Raj raj.khem@gmail.com