chromium: Drop clang 12-specific patches #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build and patch changes: ------------------------ The following patches were only needed to get clang 12 to build Chromium, which we previously used on dunfell. We recently switched to using clang 14 on dunfell, and have now dropped dunfell support, so they can be removed: * 0001-limit-number-of-LTO-jobs.patch * 0007-Revert-Use-ffile-compilation-dir-instead-of-fdebug-c.patch * 0008-drop-gsimple-template-names.patch * 0009-cast-to-bool-to-avoid-constexpr-error.patch * 0010-Revert-Fix-std-span-autodetection-7805.patch * 0011-Only-default-operator-on-declaration.patch Renamed the remaining patches to fit the numbering scheme. License changes: ---------------- None. Test-built: ----------- * chromium-ozone-wayland: - nanbield, clang, MACHINE=qemuarm64 - kirkstone, clang, MACHINE=raspberrypi4-64 Signed-off-by: Max Ihlenfeldt <max@igalia.com>
|
Did the mentioned test builds already, but without the "rename the remaining patches" part (so that I didn't have to fix the numbering again, should it turn out that we still need one or more of the removed patches). To make sure I didn't mess up anything while renaming, one more build is currently running. |
rakuco
approved these changes
Feb 5, 2024
|
Build went through, seems I got the renaming right! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build and patch changes:
The following patches were only needed to get clang 12 to build Chromium, which we previously used on dunfell. We recently switched to using clang 14 on dunfell, and have now dropped dunfell support, so they can be removed:
Renamed the remaining patches to fit the numbering scheme.
License changes:
None.
Test-built: