chromium: Backport missing dependency in NewTabPage #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency is missing in NewTabPage module. This can cause random build errors. Error occurrence depends on the order in which packages were build. It seems to occur more frequently with lower BB_NUMBER_THREADS values. Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
If that's ok for you, I can create a PR for master once #806 is merged. |
That's fine for me. Thank you. |
MaxIhlenfeldt
pushed a commit
to MaxIhlenfeldt/meta-browser
that referenced
this pull request
May 22, 2024
Cherry-pick of OSSystems#815. Dependency is missing in NewTabPage module. This can cause random build errors. Error occurrence depends on the order in which packages were build. It seems to occur more frequently with lower BB_NUMBER_THREADS values. Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
MaxIhlenfeldt
pushed a commit
to MaxIhlenfeldt/meta-browser
that referenced
this pull request
May 22, 2024
Cherry-pick of OSSystems#815. Build and patch changes: ------------------------ Add one backported patch to fix a build race condition that would sometimes lead to build errors. License changes: ---------------- Added licenses: none. Removed licenses: none. Updated licenses: none. Test-built: ----------- * chromium-x11: - scarthgap, clang, MACHINE=qemux86-64 Signed-off-by: Max Ihlenfeldt <max@igalia.com>
MaxIhlenfeldt
added a commit
that referenced
this pull request
May 22, 2024
Cherry-pick of #815. Build and patch changes: ------------------------ Add one backported patch to fix a build race condition that would sometimes lead to build errors. License changes: ---------------- Added licenses: none. Removed licenses: none. Updated licenses: none. Test-built: ----------- * chromium-x11: - scarthgap, clang, MACHINE=qemux86-64 Signed-off-by: Max Ihlenfeldt <max@igalia.com> Co-authored-by: Daniel Semkowicz <158140967+dsemkowicz-tt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency is missing in NewTabPage module. This can cause random build errors. Error occurrence depends on the order in which packages were build. It seems to occur more frequently with lower BB_NUMBER_THREADS values.
Build failed in my case usually with following error:
This issue most likely occurs also on master (Chromium 122 at the moment of writing), because fix was merged in version 125. I experienced this problem only on kirkstone branch and didn't test the master. If you think this fix is also beneficial on master, I can do a rebase on 122 and push the second MR.