firefox: README: mention fork with newer firefox #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
|
I've asked about upstreaming in that fork webdino#2 Lets see if @BIGfalco @anyakichi reply. |
kraj
reviewed
Jun 13, 2024
| I haven't tried it and I have no idea why they never sent | ||
| any PR back, but at least it has newer version and higher | ||
| chance that it will actually build than the firefox-68 here. | ||
|
|
There was a problem hiding this comment.
I think it would be better to ecourage upstreaming the changes. Or perhaps removing firefox recipes from meta-browser instead of pointing to a fork.
There was a problem hiding this comment.
This PR (and issue ticket in their fork) is trying to encourage them to upstream the changes, but if they don't then better to at least point there as people are more likely to find this layer in layerindex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.