chromium-ozone-wayland: Disable Jumbo builds by default. #85
Conversation
|
Maybe I am wrong here: You write changes are applied in chromium-gn.inc but the patch applies on chromium-ozone-wayland only. What did I miss? |
|
I write that, should we decide to pass |
|
Ahh - not enough coffee... If you make it common, I promise to play around with it for ..x11 :) |
|
Well, the idea is not to touch the setting at all, but allow anyone who'd like to enable it to do so in their own |
recipes-browser/chromium/README
Outdated
| If you would like to enable Jumbo builds locally, you can pass additional flags | ||
| to GN (in local.conf, for example): | ||
|
|
||
| GN_ARGS_append_pn-chromium-x11 = " use_jumbo_build=true" |
There was a problem hiding this comment.
I understand that this is what happens behind the scene but I think we ought to use the PACKAGECONFIG mechanism to change this as this is the standard way of configuring the package.
Doing so, adding a comment on the recipe before the block adding the config does help.
There was a problem hiding this comment.
I thought PACKAGECONFIG was normally used for knobs which have an effect on the generated package (support for additional features, changes to the build or runtime dependencies).
Jumbo builds only affect the build itself, not what is generated in it.
I'm fine with PACKAGECONFIG, but I wanted to double-check we're not abusing it.
There was a problem hiding this comment.
It is intended to configure the package. It can be for:
- enabling / disabling a feature
- change behaviour
In this case, it enables the jumbo build support. Fits well IMO.
There was a problem hiding this comment.
Fair enough; I've switched to a PACKAGECONFIG knob, please take another look.
Whether to use Jumbo builds or not should be up to each user; while it may decrease build times, it can require more RAM (it tends to cause problems for me specifically when using GCC because of the amount of memory it requires). Additionally, it's not an Ozone-Wayland-specific setting, so it should've been in chromium-gn.inc had it been the case. We now provide a PACKAGECONFIG knob (off by default) to control that. Signed-off-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
a90f126
to
33c3549
Compare
Whether to use Jumbo builds or not should be up to each user; while it may
decrease build times, it can require more RAM (it tends to cause problems
for me specifically when using GCC because of the amount of memory it
requires).
Additionally, it's not an Ozone-Wayland-specific setting, so it should've
been in chromium-gn.inc had it been the case.
We now provide a PACKAGECONFIG knob (off by default) to control that.
Signed-off-by: Raphael Kubo da Costa raphael.kubo.da.costa@intel.com