Ozone/Wayland: Update branch to version 71.0.3545.0 aka ToT #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otavio
requested changes
Sep 12, 2018
There was a problem hiding this comment.
Thanks for updating the recipe and keeping working on this important feature. I did send few requests for changes to keep the level of quality of our metadata but so far it looks very good.
Please do those adjustment and force push it to the very same branch so we can do a new review.
Thanks in advance
...omium/chromium-ozone-wayland/0001-Fix-GCC-build-remove-constexpr-for-non-resolved-comp.patch
Outdated
Show resolved
Hide resolved
...r/chromium/chromium-ozone-wayland/0001-Fix-a-GCC-error-about-undeclared-std-unique_ptr.patch
Outdated
Show resolved
Hide resolved
...omium/chromium-ozone-wayland/0001-OmniboxTextView-fix-gcc-error-for-structure-initiali.patch
Outdated
Show resolved
Hide resolved
...omium/chromium-ozone-wayland/0001-ScrollPaintPropertyNode-Rename-SnapContainerData-to-.patch
Outdated
Show resolved
Hide resolved
...ser/chromium/chromium-ozone-wayland/0001-ozone-wayland-Fix-fpermissive-problem-for-GCC.patch
Outdated
Show resolved
Hide resolved
|
please review again |
otavio
requested changes
Sep 12, 2018
...omium/chromium-ozone-wayland/0001-Fix-GCC-build-remove-constexpr-for-non-resolved-comp.patch
Outdated
Show resolved
Hide resolved
otavio
reviewed
Sep 12, 2018
...omium/chromium-ozone-wayland/0001-Fix-GCC-build-remove-constexpr-for-non-resolved-comp.patch
Outdated
Show resolved
Hide resolved
The branch is based on a weekly-rebased repo located at github.com/Igalia/chromium Test-built with: * Yocto sumo, GCC 7 and MACHINE="raspberrypi3" Signed-off-by: Maksim Sisov <msisov@igalia.com>
otavio
approved these changes
Sep 12, 2018
|
@rakuco ping |
|
Sorry for the delay, I'll try to take a look at the PR tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch is based on a weekly-rebased repo located at github.com/Igalia/chromium
Currently, around 85% of patches are upstreamed. We've reworked the design of the ozone/wayland
and it's no longer based on mus aka ui service. The work can be tracked from the ToT crbug -
https://bugs.chromium.org/p/chromium/issues/detail?id=578890
We ported various patches to the newest design and re implemented many features. It's hard to say
the exact changes now, but this recipe is a ground to support a multiprocess mode with all the possible
wayland performance features including: frame callback, presentation feedback, partial swap, native
gpu memory buffers and etc. Though, the chromium in this recipe is built with all these features enabled,
the browser is run with --in-process-gpu flag. The reason behind this is lack of certain patches and optimizations, which I don't want to publish yet. I will update them soon.
Test-built with:
It's hard to describe why licences changed as long as the last version of the browser was
m64, which is 7 milestones behind the current m71 milestone.
Removed licence files:
The explanations are taken from the last commit messages:
Changed licence files:
zlib-aarch64.patch is now added to chromium-gn, but oe-clang patch had to be rebased and is not compatible with chromium m68. Thus, there is a different patch for chromium m71
Signed-off-by: Maksim Sisov msisov@igalia.com