[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Add validate webhook for all apis #641

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

drivebyer
Copy link
Collaborator
@drivebyer drivebyer commented Sep 22, 2023

Description

#490.

This PR is add scaffold for admission webhook. Maybe we need more validation in the feture. We don't need validate all fields, becouse some fields will be validate by k8s itself.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
@shubham-cmyk shubham-cmyk added this to the v0.16.0 milestone Sep 22, 2023
@shubham-cmyk
Copy link
Member

This is going to be part of v0.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants