[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete a user doesn't delete associated tokens #133

Closed
richard-julien opened this issue Jul 9, 2019 · 0 comments
Closed

Delete a user doesn't delete associated tokens #133

richard-julien opened this issue Jul 9, 2019 · 0 comments
Assignees
@richard-julien
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 1.1.0

Comments

@richard-julien
Copy link
Member
richard-julien commented Jul 9, 2019 •
edited
Loading

Description

Delete a user doesn't delete associated tokens

Environment

OpenCTI 1.0.2

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Create a user
  2. Delete the user

Expected Output

I think we need to stop to hard delete users.
We need to have a logical deletion instead and keep the user and the token

Actual Output

Token of the user still exists in database

Todo

  • Create a migration that cleanup existing tokens not linked to any user
  • Introduce logical deletion instead and keep the user and the token
@richard-julien richard-julien added this to the Release 1.1.0 milestone Jul 9, 2019
@richard-julien richard-julien added the bug use for describing something not working as expected label Jul 9, 2019
SamuelHassine pushed a commit that referenced this issue Jul 17, 2019
[api] Delete token when deleting user (#133)
2d60704
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-julien richard-julien

Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 1.1.0
Development

No branches or pull requests
2 participants
@richard-julien @SamuelHassine