[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple state management for connectors. #291

Closed
SamuelHassine opened this issue Oct 25, 2019 · 1 comment
Closed

Add simple state management for connectors. #291

SamuelHassine opened this issue Oct 25, 2019 · 1 comment
Assignees
@richard-julien @SamuelHassine
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 2.0.1

Comments

@SamuelHassine
Copy link
Member
SamuelHassine commented Oct 25, 2019 •
edited by richard-julien
Loading

Problem to Solve

Implement a method in the API to store a state for a connector

Current Workaround

None.

Proposed Solution

Add a state in the new connector API implementation.
On the client python, get the state at connector registration and then push it to the API every time the connector do a ping/pong with the API. The state will be automatically updated every 30 seconds.
@SamuelHassine SamuelHassine self-assigned this Oct 25, 2019
@SamuelHassine SamuelHassine added the feature use for describing a new feature to develop label Oct 25, 2019
@SamuelHassine SamuelHassine added this to the Release 2.0.1 milestone Oct 25, 2019
SamuelHassine pushed a commit that referenced this issue Oct 25, 2019
[api] Introduce a key/value management methods with the Redis backend (…
63d4b97 
…#291)
SamuelHassine pushed a commit that referenced this issue Oct 25, 2019
[api] Introduce a key/value management methods with the Redis backend (…
b455ebe 
…#291)
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Oct 25, 2019
@richard-julien
Copy link
Member

We should propose a simple API around connector state instead

@richard-julien richard-julien self-assigned this Oct 26, 2019
@richard-julien richard-julien removed the solved use to identify issue that has been solved (must be linked to the solving PR) label Oct 26, 2019
@richard-julien richard-julien changed the title Implement a method to store simple key/value in Redis Add simple state management for connectors. Oct 26, 2019
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Oct 26, 2019
SamuelHassine pushed a commit that referenced this issue Oct 26, 2019
@richard-julien
[api] Introduce a state management for connector (#291)
dc95fa4 
* [api] Introduce a key/value management methods with the Redis backend (#291)

* Handle timeout in keyvalue management

* Introduce API for state management in connector

* [api] Modify workers to take new connectors & change Grakn version

* [api] Handle alias at the entities creation

* [api] Delete the resolvers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-julien richard-julien

@SamuelHassine SamuelHassine

Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 2.0.1
Development

No branches or pull requests
2 participants
@richard-julien @SamuelHassine