[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent worker for consuming messages if the API is down #309

Closed
SamuelHassine opened this issue Oct 29, 2019 · 0 comments
Closed

Prevent worker for consuming messages if the API is down #309

SamuelHassine opened this issue Oct 29, 2019 · 0 comments
Assignees
@SamuelHassine
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 2.0.2

Comments

@SamuelHassine
Copy link
Member

Problem to Solve

If the API is down, the Python worker still consumes messages and acknowledge them even if entities/relations are not created.

Current Workaround

None.

Proposed Solution

Do not ack message in case of error.

Additional Information

None.
@SamuelHassine SamuelHassine self-assigned this Oct 29, 2019
@SamuelHassine SamuelHassine added the feature use for describing a new feature to develop label Oct 29, 2019
@SamuelHassine SamuelHassine added this to the Release 2.0.2 milestone Oct 29, 2019
SamuelHassine pushed a commit that referenced this issue Oct 31, 2019
[worker] Do not acknowledge messages if API is down (#309)
b207d77 
* First work on worker.py
* Add callback to handle ack
* [worker] Do not acknowledge messages if API is down
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamuelHassine SamuelHassine

Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 2.0.2
Development

No branches or pull requests
1 participant
@SamuelHassine