[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] fix missing activ users count in telemetry exports (#7211) #7212

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[backend] fix missing activ users count in telemetry exports (#7211) #7212

merged 1 commit into from
Jun 6, 2024

Conversation

Archidoit
Copy link
Member

issue: #7211

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Jun 3, 2024
@Archidoit Archidoit self-assigned this Jun 3, 2024
@Archidoit Archidoit marked this pull request as draft June 3, 2024 14:33
@Archidoit Archidoit linked an issue Jun 3, 2024 that may be closed by this pull request
Missing activ users count metric in telemetry file exports #7211
Closed
@Archidoit Archidoit marked this pull request as ready for review June 3, 2024 14:56
@codecov Codecov
Copy link
codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 67.54%. Comparing base (e9dbebf) to head (9cde756).
Report is 1 commits behind head on master.

Files Patch % Lines
...cti-graphql/src/telemetry/TelemetryMeterManager.ts 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7212      +/-   ##
==========================================
- Coverage   67.54%   67.54%   -0.01%     
==========================================
  Files         561      561              
  Lines       68727    68754      +27     
  Branches     5835     5837       +2     
==========================================
+ Hits        46425    46443      +18     
- Misses      22302    22311       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard self-assigned this Jun 6, 2024
aHenryJard
aHenryJard approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member
@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, the opencti_active_users_count is present in support package telemetry logs with this fix, so all good to me.

@Archidoit Archidoit merged commit cfb12e8 into master Jun 6, 2024
5 checks passed
@Archidoit Archidoit deleted the issue/7211 branch June 6, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aHenryJard aHenryJard aHenryJard approved these changes

Assignees

@aHenryJard aHenryJard

@Archidoit Archidoit

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing activ users count metric in telemetry file exports
2 participants
@Archidoit @aHenryJard