[backend] Change external reference resolution for OpenBAS integration #7233
Conversation
| @@ -176,19 +175,11 @@ export const getScenarioResult = async (id: string) => { | |||
| } | |||
| const httpClient = buildXTmOpenBasHttpClient(); | |||
| try { | |||
| const { data: scenario } = await httpClient.get(`/scenarios/external_reference/${id}`); | |||
| if (!scenario || !scenario.scenario_id) { | |||
| const { data: exercise } = await httpClient.get(`/scenarios/external_reference/${id}`); | |||
There was a problem hiding this comment.
just to understand: this openBAS API has changed its signature and returns now an exercise instead of a scenario, right ?
So if openBAS and openCTI are not both updated to the latest version, this code will fail I guess ?
There was a problem hiding this comment.
Exactly, we need to have a good synchronisation between the two products
There was a problem hiding this comment.
Do we write somewhere which version of octi is compatible with which version of obas?
There was a problem hiding this comment.
We are thinking about a robuste plan to handle this.
Good point :)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7233 +/- ##
=======================================
Coverage 67.54% 67.55%
=======================================
Files 561 561
Lines 68754 68745 -9
Branches 5837 5837
=======================================
- Hits 46441 46440 -1
+ Misses 22313 22305 -8 ☔ View full report in Codecov by Sentry. |
Proposed changes
OpenCTI should get the latest ended simulation based on scenarios instead of the latest simulation based on the first scenario.
Related issues
Testing
OpenBAS PR -> OpenBAS-Platform/openbas#1048