[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openmage #7

Merged
merged 4 commits into from
Aug 21, 2020
Merged

Openmage #7

merged 4 commits into from
Aug 21, 2020

Conversation

splendidinternet
Copy link
Collaborator
@splendidinternet splendidinternet commented Aug 19, 2020

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

We have renamed the Magento devdocs to OpenMage devdocs and changed colors and logos. We changed the styling, fonts, colors and some layout files, such that it closer resembles the style of the openmage website, and less the style of the old magento sites.

The content was updated with the content of this repository: https://github.com/OpenMage/devdocs-m1

@colinmollenhour colinmollenhour merged commit 4826897 into OpenMage:master Aug 21, 2020
@colinmollenhour
Copy link
Member

Thanks for the PR! Unfortunately the page still doesn't build. Can you look into this? The error is:

The page build failed for the master branch with the following error:
 
The tag glossarytooltip on line 27 in mftf/2.2/getting-started.md is not a recognized Liquid tag. For more information, see https://docs.github.com/github/working-with-github-pages/troubleshooting-jekyll-build-errors-for-github-pages-sites#unknown-tag-error.
 
For information on troubleshooting Jekyll see:
 
https://docs.github.com/articles/troubleshooting-jekyll-builds
 
If you have any questions you can submit a request on the Contact GitHub page at https://support.github.com/contact?repo_id=265988482&page_build_id=198517276

@colinmollenhour
Copy link
Member

I've just added you as a maintainer so you can push directly to master as needed, hopefully that will make it easier.

@splendidinternet
Copy link
Collaborator Author

Hi Collin,

Do you build the documentation with "github pages"? If so, I'm afraid we can't do much
about it:

The documentation of github-pages states:

Unsupported plugins are a common source of unrecognized tags

On ·this page Github links to a list of supported plugins:

Unfortunately glossarytooltip is not a part of it.

What you / we can do is this, as stated in the documentation:

GitHub Pages cannot build sites using unsupported plugins. If you want to use unsupported plugins, generate your site locally and then push your site's static files to GitHub.

Does that make sense to you?

Regards

@splendidinternet
Copy link
Collaborator Author

If you absolutely want or need to use github pages, we could also replace the tags with corresp. html-code.

@colinmollenhour
Copy link
Member

Ahh ok, that makes sense. I'm fine either way:

  1. Make the site compatible with GitHub Pages and get free and easy hosting
  2. Use another host, and perhaps another build tool (although I think Github Actions could still be used to do a custom build)

I'll defer to you.

@splendidinternet
Copy link
Collaborator Author
splendidinternet commented Aug 27, 2020

We already have an instance of the openmage devdocs running.

We are still waiting for information from openmage to set up the DNS entries for us. In the meantime, we have registered www.devdocs-openmage.org for our instance. We are also willing to put s.th. into place with github actions.

So we are going for option #2. But we'd keep Jekyll in place for the time being. On our host it works fine.

@colinmollenhour
Copy link
Member

Sounds good @splendidinternet, we'll hopefully get the DNS added soon, thanks for getting this working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants