[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some window settings do not work when configured inside openspace.cfg #2364

Closed
GPayne opened this issue Dec 1, 2022 · 2 comments · Fixed by #2380
Closed

Some window settings do not work when configured inside openspace.cfg #2364

GPayne opened this issue Dec 1, 2022 · 2 comments · Fixed by #2380
Assignees
Labels
Type: Bug Bugs on already existing features
Milestone

Comments

@GPayne
Copy link
Contributor
GPayne commented Dec 1, 2022

Some window settings will not work if configured inside the openspace.cfg file rather than in a .json window configuration file. This includes fullscreen, border, and others.

Some background:
SGCT uses a .json file to define all possible window settings. A .json file in the config/ directory can be used, or manually edited in a custom configuration. Another option is to use the window config GUI from the launcher, which creates a .json file in user/config/.

There are two ways to specify settings inside openspace.cfg. The first is to simply reference an existing .json file. Another way is to call the sgct.config.single or sgct.config.fisheye functions which reside in scripts/configuration_helper.lua. Arguments can be passed to the function, which will then generate a .json file in the filesystem /tmp directory. The issue is that some of these arguments are incorrectly ignored.

The problem is likely in the function generateWindow, where arguments such as border and fullscreen are handled.

@WeirdRubberDuck
Copy link
Contributor
WeirdRubberDuck commented Dec 2, 2022

Note that fullscreen works, but it has to be fullScreen when given to the configuration_helper, i.e. with a large S

We should probably make it so that the keys are consistent with the SGCT documentation and the config files

@WeirdRubberDuck WeirdRubberDuck self-assigned this Dec 8, 2022
@WeirdRubberDuck WeirdRubberDuck added the Type: Bug Bugs on already existing features label Dec 8, 2022
@WeirdRubberDuck
Copy link
Contributor

The problem is that bool properties that are set to "false" are not included in the configuration due to the checks in the configuration_helper.

@WeirdRubberDuck WeirdRubberDuck added this to the 0.18.2 milestone Dec 8, 2022
WeirdRubberDuck added a commit that referenced this issue Dec 8, 2022
…#2380)

* Add nil checks for boolean parameters in config helper (closes #2364)

* remove some trailing spaces
alexanderbock pushed a commit that referenced this issue Dec 21, 2022
…#2380)

* Add nil checks for boolean parameters in config helper (closes #2364)

* remove some trailing spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bugs on already existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants