[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align with current CMAF version mentioing cmf2 brand #170

Merged
merged 6 commits into from
Sep 22, 2023
Merged

align with current CMAF version mentioing cmf2 brand #170

merged 6 commits into from
Sep 22, 2023

Conversation

podborski
Copy link
Collaborator
@podborski podborski commented May 15, 2023 •
edited by pr-preview bot
Loading

@podborski podborski linked an issue May 15, 2023 that may be closed by this pull request
Consider updating the CMAF section to mention cmf2 #158
Closed
@podborski podborski marked this pull request as ready for review August 18, 2023 20:21
cconcolato
cconcolato requested changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator
@cconcolato cconcolato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the change log.
The sentence starting with "it is important to note" could be made a NOTE, but not the following sentence as it contains a "should".
Also "should" should be upper case.

@cconcolato cconcolato merged commit 5c92d62 into main Sep 22, 2023
github-actions bot added a commit that referenced this pull request Sep 22, 2023
@cconcolato @github-actions
Merge pull request #170 from AOMediaCodec/158-cmf2
9d51fca 
SHA: 5c92d62
Reason: push, by cconcolato

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@cconcolato cconcolato deleted the 158-cmf2 branch December 11, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cconcolato cconcolato cconcolato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider updating the CMAF section to mention cmf2
2 participants
@podborski @cconcolato