[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note for encryption description limit #195

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Conversation

cconcolato
Copy link
Collaborator
@cconcolato cconcolato commented Feb 19, 2024

@cconcolato
Copy link
Collaborator Author

Related to #193

@podborski
Copy link
Collaborator
podborski commented Feb 23, 2024

@cconcolato I feel like this would be better as a clear warning and not a note? Could we change it to ISSUE instead of NOTE so that it renders as:

image

And we probably can update the link to the ISOBMFF to https://www.iso.org/standard/83102.html

index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link
Collaborator
@podborski podborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cconcolato cconcolato merged commit 743dc4b into main Mar 4, 2024
1 check passed
@cconcolato cconcolato deleted the encryption_limit branch March 4, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants