[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Update examples to use arm_test_data repo and remove old test files. #763

Merged
merged 3 commits into from
Dec 4, 2023
Merged

ENH: Update examples to use arm_test_data repo and remove old test files. #763

merged 3 commits into from
Dec 4, 2023

Conversation

zssherman
Copy link
Collaborator
@zssherman zssherman commented Dec 2, 2023 •
edited
Loading

After discussion, filenames are seen in full in examples during the fetch for transparency on files used. Old files are removed to reduce repo size.

  • Closes Exclude Test Data from Packaging #470
  • Tests added
  • Documentation reflects changes
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mgrover1
mgrover1 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator
@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks @zssherman

@zssherman zssherman merged commit d402526 into ARM-DOE:main Dec 4, 2023
16 checks passed
@zssherman zssherman deleted the arm_data_repo_examples branch January 23, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

@AdamTheisen AdamTheisen Awaiting requested review from AdamTheisen AdamTheisen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude Test Data from Packaging
2 participants
@zssherman @mgrover1