[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: formpopover container ref for improved placement #506

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix: formpopover container ref for improved placement #506

merged 2 commits into from
Jul 22, 2024

Conversation

yoannfleurydev
Copy link
Member
@yoannfleurydev yoannfleurydev commented Jul 17, 2024 •
edited
Loading

Describe your changes

  • Add ref props to give the containerRef to the FormPopover Portal.
  • Removed the implementation in admin interface as there are little issues with it.

Documentation

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the pnpm storybook command and everything is working
  • If applicable, I updated the translations for english and french files
    (If you cannot update the french language, just let us know in the PR description)
  • If applicable, I updated the README.md
  • If applicable, I created a PR or an issue on the documentation repository
  • If applicable, I’m sure that my feature or my component is mobile first and available correctly on desktop

@vercel Vercel
Copy link
vercel bot commented Jul 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 9:13am

@yoannfleurydev yoannfleurydev force-pushed the fix/formpopover-placement branch 2 times, most recently from 71fe7e3 to f14ed1f Compare July 17, 2024 20:16
@sonarcloud SonarCloud
Copy link
sonarcloud bot commented Jul 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ivan-dalmet ivan-dalmet merged commit 6fe188b into master Jul 22, 2024
7 checks passed
@ivan-dalmet ivan-dalmet deleted the fix/formpopover-placement branch July 22, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-dalmet ivan-dalmet ivan-dalmet approved these changes

@DecampsRenan DecampsRenan Awaiting requested review from DecampsRenan

@JeanneGrenet JeanneGrenet Awaiting requested review from JeanneGrenet

Assignees

@yoannfleurydev yoannfleurydev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoannfleurydev @ivan-dalmet