[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back depot #1698

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Add back depot #1698

merged 2 commits into from
Jul 25, 2024

Conversation

Sbozzolo
Copy link
Member

This got removed somewhere, but there's no strong reason not to have it to cut down instantiation time.

charleskawczynski
charleskawczynski approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member
@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Simon preferred CI to be stateless. I don't have strong feelings either way. It's kind of nice when instantiation takes less than a minute

@Sbozzolo
Copy link
Member Author

I think Simon preferred CI to be stateless. I don't have strong feelings either way. It's kind of nice when instantiation takes less than a minute

I agree that it would be nice (and often depots lead to failures), but I think that there's a lot of time and frustration saved in a faster turnaround time. Init will soon be ~15 minutes, and it could be reduced to ~2

@Sbozzolo Sbozzolo enabled auto-merge July 25, 2024 10:02
@Sbozzolo Sbozzolo merged commit 3611a0f into main Jul 25, 2024
18 of 20 checks passed
@Sbozzolo Sbozzolo deleted the gb/depot branch July 25, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sbozzolo @charleskawczynski